From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: "Zhou1, Tao" <Tao.Zhou1@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [bug report] drm/amdgpu: add amdgpu_ras.c to support ras (v2)
Date: Wed, 6 May 2020 14:33:03 +0300 [thread overview]
Message-ID: <20200506113303.GJ1992@kadam> (raw)
In-Reply-To: <SN1PR12MB2558A472D85D6296CE250BBF87A40@SN1PR12MB2558.namprd12.prod.outlook.com>
On Wed, May 06, 2020 at 10:10:56AM +0000, Pan, Xinhui wrote:
> [AMD Official Use Only - Internal Distribution Only]
>
> no. below function checks if block is valid or not.
> I think you need check your code_checker. or you were checking on a very old codebase?
>
> /* check if ras is supported on block, say, sdma, gfx */
> static inline int amdgpu_ras_is_supported(struct amdgpu_device *adev,
> unsigned int block)
Ah! That's right. Thanks.
What happens here is that Smatch thinks amdgpu_ras_is_supported() always
returns false because there is a bug in how it tracks ras->supported.
I will fix this.
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-05-06 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 9:12 [bug report] drm/amdgpu: add amdgpu_ras.c to support ras (v2) Dan Carpenter
2020-05-05 12:37 ` Dan Carpenter
2020-05-06 7:26 ` Zhou1, Tao
2020-05-06 9:17 ` Dan Carpenter
2020-05-06 10:10 ` Pan, Xinhui
2020-05-06 11:33 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-20 13:23 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506113303.GJ1992@kadam \
--to=dan.carpenter@oracle.com \
--cc=Tao.Zhou1@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.