From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83363C28CBC for ; Wed, 6 May 2020 12:06:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56FBE20714 for ; Wed, 6 May 2020 12:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588766776; bh=Cnp72gZDSXB8fmfb3YiD6pjx7zR+G2HEJElDv28YT6M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=w/rfDC4ougFvlLgRbn4B5iq81L6nidbhhlp0hL2DvB3XNdGWZHoeemURBDMgfIJAV lrPlbWPmO9AiRyJ7740sooxF+wl6Jw9h1cZIYd8dFQVT4++mUoMQClvA/y+uohyxd0 FyAzhpzmocCBZeFpNOF20+9YNpofrJyPM8C7iy5E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbgEFMGQ (ORCPT ); Wed, 6 May 2020 08:06:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:40350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbgEFMGP (ORCPT ); Wed, 6 May 2020 08:06:15 -0400 Received: from coco.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 482A5206DD; Wed, 6 May 2020 12:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588766775; bh=Cnp72gZDSXB8fmfb3YiD6pjx7zR+G2HEJElDv28YT6M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=y2JlDFBMfsT6Jd0mCFP1BtcfpgZbUvODxvZGvAH8eJAgobWN6UNRpndZldiQ9okZf ym0sPEyoUnaak5W1axNsfOlT/1Udnr7hC5vgXLUoyponLwbu7y7YIAXAgA6M0uw6fN oiJACsVGc2HbsW5o2jI3ctIkl0YGRo/Sgtej3xtc= Date: Wed, 6 May 2020 14:06:10 +0200 From: Mauro Carvalho Chehab To: Hans Verkuil Cc: Linux Media Mailing List , Laurent Pinchart , Alexandre Courbot , Paul Kocialkowski , Ezequiel Garcia , Maxime Jourdan , Niklas =?UTF-8?B?U8O2ZGVybHVuZA==?= Subject: Re: [PATCHv2] media: vidioc-enum-fmt.rst: make the ENUM_FMT text clearer Message-ID: <20200506140610.51bbf0c8@coco.lan> In-Reply-To: References: X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Wed, 6 May 2020 13:40:52 +0200 Hans Verkuil escreveu: > + > +2) ``V4L2_CAP_IO_MC`` is set (also known as an 'MC-centric' driver) > + > + If the ``mbus_code`` field is zero, then all image formats > + shall be enumerated. > + > + If the ``mbus_code`` field is initialized to a valid (non-zero) > + :ref:`media bus format code `, then drivers > + shall restrict enumeration to only the image formats that can produce > + (for video output devices) or be produced from (for video capture > + devices) that media bus code. Patch looks ok, but I guess we need to add one more thing to have a fully defined behavior. I mean: What happens otherwise? E. g. if application uses a non-zero value for mbus_code that it is not valid / or it is valid but unsupported? Should it return an empty list or an error code? Thanks, Mauro