From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: use strcmp() in parse_options()
Date: Wed, 6 May 2020 07:41:55 -0700 [thread overview]
Message-ID: <20200506144155.GC107238@google.com> (raw)
In-Reply-To: <d44cb4c9-ad2b-2f21-06eb-ad386ebf2c18@huawei.com>
On 05/06, Chao Yu wrote:
> On 2020/5/2 7:35, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Remove the pointless string length checks. Just use strcmp().
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>
> [...]
>
> > - } else if (strlen(name) == 4 &&
> > - !strcmp(name, "zstd")) {
> > + } else if (!strcmp(name, "zstd")) {
> > F2FS_OPTION(sbi).compress_algorithm =
> > COMPRESS_ZSTD;
>
> lzo-rle will be added, Jaegeuk, please notice that the late applied patch
> should adjust a bit here.
Sure.
>
> Thanks,
>
> > } else {
> >
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2020-05-06 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 23:35 [f2fs-dev] [PATCH] f2fs: use strcmp() in parse_options() Eric Biggers
2020-05-06 6:27 ` Chao Yu
2020-05-06 14:41 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506144155.GC107238@google.com \
--to=jaegeuk@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.