Re: [Intel-gfx] [PATCH] drm/i915/dgfx: avoid opregion calls and messages

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Mar 06, 2020 at 05:26:00PM -0800, Lucas De Marchi wrote:
> This avoids the annoying message
> "Failed to get panel details from OpRegion (-19)" while initializing.
> On DGFX there is no access to OpRegion, so just avoid any calls related
> to it.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_opregion.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c
> index cc6b00959586..daadad046810 100644
> --- a/drivers/gpu/drm/i915/display/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/display/intel_opregion.c
> @@ -1006,6 +1006,10 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
>  	u32 panel_details;
>  	int ret;
>  
> +	/* No access to OpRegion */
> +	if (IS_DGFX(dev_priv))
> +		return -ENODEV;
> +
>  	ret = swsci(dev_priv, SWSCI_GBDA_PANEL_DETAILS, 0x0, &panel_details);
>  	if (ret) {
>  		drm_dbg_kms(&dev_priv->drm,

I think we could just remove this debug message entirely. There are
only two silent failures modes for swsci(): no swsci, and the specific
function not being supported. Should be easy to figure out which case
it is without this debug if necessary. And all the cases where the
swcsi() succeed seem to have enough debugs to tell us that we did get
the panel type from opregion but decided to ignore it anyway.

> -- 
> 2.25.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx