From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-7262-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 2FBD5985E0E for ; Thu, 7 May 2020 11:34:00 +0000 (UTC) Date: Thu, 7 May 2020 07:33:51 -0400 From: "Michael S. Tsirkin" Message-ID: <20200507073302-mutt-send-email-mst@kernel.org> References: <20200507103119.11219-1-david@redhat.com> <20200507103119.11219-8-david@redhat.com> <20200507064558-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Subject: [virtio-dev] Re: [PATCH v3 07/15] mm/memory_hotplug: Introduce offline_and_remove_memory() Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko , Andrew Morton , Michal Hocko , Pankaj Gupta , Oscar Salvador , Pavel Tatashin , Wei Yang , Dan Williams , Qian Cai List-ID: On Thu, May 07, 2020 at 01:24:38PM +0200, David Hildenbrand wrote: > On 07.05.20 12:46, Michael S. Tsirkin wrote: > > On Thu, May 07, 2020 at 12:31:11PM +0200, David Hildenbrand wrote: > >> virtio-mem wants to offline and remove a memory block once it unplugge= d > >> all subblocks (e.g., using alloc_contig_range()). Let's provide > >> an interface to do that from a driver. virtio-mem already supports to > >> offline partially unplugged memory blocks. Offlining a fully unplugged > >> memory block will not require to migrate any pages. All unplugged > >> subblocks are PageOffline() and have a reference count of 0 - so > >> offlining code will simply skip them. > >> > >> All we need is an interface to offline and remove the memory from kern= el > >> module context, where we don't have access to the memory block devices > >> (esp. find_memory_block() and device_offline()) and the device hotplug > >> lock. > >> > >> To keep things simple, allow to only work on a single memory block. > >> > >> Acked-by: Michal Hocko > >> Tested-by: Pankaj Gupta > >> Cc: Andrew Morton > >> Cc: David Hildenbrand > >> Cc: Oscar Salvador > >> Cc: Michal Hocko > >> Cc: Pavel Tatashin > >> Cc: Wei Yang > >> Cc: Dan Williams > >> Cc: Qian Cai > >> Signed-off-by: David Hildenbrand > >=20 > >=20 > > didn't you lose Andrew Morton's ack here? >=20 > Yeah, thanks for noticing. >=20 > >=20 > >> --- > >> include/linux/memory_hotplug.h | 1 + > >> mm/memory_hotplug.c | 37 +++++++++++++++++++++++++++++++++= + > >> 2 files changed, 38 insertions(+) > >=20 > > I get: > >=20 > > error: sha1 information is lacking or useless (mm/memory_hotplug.c). > > error: could not build fake ancestor > >=20 > > which version is this against? Pls post patches on top of some tag > > in Linus' tree if possible. >=20 > As the cover states, latest linux-next. To be precise >=20 > commit 6b43f715b6379433e8eb30aa9bcc99bd6a585f77 (tag: next-20200507, > next/master) > Author: Stephen Rothwell > Date: Thu May 7 18:11:31 2020 +1000 >=20 > Add linux-next specific files for 20200507 >=20 Don't base on linux-next please. Generally base on the tree you are targeting, or Linus' tree. > --=20 > Thanks, >=20 > David / dhildenb --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v3 07/15] mm/memory_hotplug: Introduce offline_and_remove_memory() Date: Thu, 7 May 2020 07:33:51 -0400 Message-ID: <20200507073302-mutt-send-email-mst@kernel.org> References: <20200507103119.11219-1-david@redhat.com> <20200507103119.11219-8-david@redhat.com> <20200507064558-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko , Andrew Morton , Michal Hocko , Pankaj Gupta , Oscar Salvador , Pavel Tatashin , Wei Yang , Dan Williams , Qian Cai List-Id: virtualization@lists.linuxfoundation.org On Thu, May 07, 2020 at 01:24:38PM +0200, David Hildenbrand wrote: > On 07.05.20 12:46, Michael S. Tsirkin wrote: > > On Thu, May 07, 2020 at 12:31:11PM +0200, David Hildenbrand wrote: > >> virtio-mem wants to offline and remove a memory block once it unplugged > >> all subblocks (e.g., using alloc_contig_range()). Let's provide > >> an interface to do that from a driver. virtio-mem already supports to > >> offline partially unplugged memory blocks. Offlining a fully unplugged > >> memory block will not require to migrate any pages. All unplugged > >> subblocks are PageOffline() and have a reference count of 0 - so > >> offlining code will simply skip them. > >> > >> All we need is an interface to offline and remove the memory from kernel > >> module context, where we don't have access to the memory block devices > >> (esp. find_memory_block() and device_offline()) and the device hotplug > >> lock. > >> > >> To keep things simple, allow to only work on a single memory block. > >> > >> Acked-by: Michal Hocko > >> Tested-by: Pankaj Gupta > >> Cc: Andrew Morton > >> Cc: David Hildenbrand > >> Cc: Oscar Salvador > >> Cc: Michal Hocko > >> Cc: Pavel Tatashin > >> Cc: Wei Yang > >> Cc: Dan Williams > >> Cc: Qian Cai > >> Signed-off-by: David Hildenbrand > > > > > > didn't you lose Andrew Morton's ack here? > > Yeah, thanks for noticing. > > > > >> --- > >> include/linux/memory_hotplug.h | 1 + > >> mm/memory_hotplug.c | 37 ++++++++++++++++++++++++++++++++++ > >> 2 files changed, 38 insertions(+) > > > > I get: > > > > error: sha1 information is lacking or useless (mm/memory_hotplug.c). > > error: could not build fake ancestor > > > > which version is this against? Pls post patches on top of some tag > > in Linus' tree if possible. > > As the cover states, latest linux-next. To be precise > > commit 6b43f715b6379433e8eb30aa9bcc99bd6a585f77 (tag: next-20200507, > next/master) > Author: Stephen Rothwell > Date: Thu May 7 18:11:31 2020 +1000 > > Add linux-next specific files for 20200507 > Don't base on linux-next please. Generally base on the tree you are targeting, or Linus' tree. > -- > Thanks, > > David / dhildenb