From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F6C3C38A2A for ; Thu, 7 May 2020 15:08:56 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 008D12073A for ; Thu, 7 May 2020 15:08:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="QLPKtMif" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 008D12073A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 96C174B29E; Thu, 7 May 2020 11:08:55 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZhqtONCnOhNL; Thu, 7 May 2020 11:08:54 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 365054B3D0; Thu, 7 May 2020 11:08:54 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C491F4B2A4 for ; Thu, 7 May 2020 11:08:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6X+StM91dAcv for ; Thu, 7 May 2020 11:08:51 -0400 (EDT) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 7D0CC4B29E for ; Thu, 7 May 2020 11:08:51 -0400 (EDT) Received: by mail-wr1-f68.google.com with SMTP id y4so6802511wrm.11 for ; Thu, 07 May 2020 08:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TQa81UcYxl76b0HSzt9euhUmUepcpv3Z6r/LM6Ln5KE=; b=QLPKtMifAlPpfvwJKFqGd26kBFWPILMeiCXFGFuEBE548R8w7lgb/0jsPh1bu3DHka breNdX586T44AB8m87A/JFIhSjk18lq8Ve/dJA8HOPPUdvxMajShm3p9OrMioRH7BjNk OtO/C7ZoIrq3QXqeHbPkDtJj/UCSnMPHzfmtbcFPKku/qJ3SLGEvDZfQNIGTDQOHihp2 RZUnfXmJAg5LekkpLJLHtjTC60tVDp/QS+HCO4fpBcJAltENqV7gK5zsOYx3ba2n1ytG Gid9G0dnaQqFzt1Mv4dH7ozS4PPRWrE3NnI+YiPyf0hsTtLfCKlYI43SN/29CxJTkK6U Irsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TQa81UcYxl76b0HSzt9euhUmUepcpv3Z6r/LM6Ln5KE=; b=dpesNTOJxfFx2cPvD2a5XXa2KN3aeoPAhIzaPNO1JnHlEgGh7ZhO3/a8/ju2bwEykU TTDQqZT0NnRYJxFCblcyIG+HjpsUjBzU3RKmw6jbC0i0gyD8pC6gd3j5kOB61FxEcI71 jQFue0AmYspV1x3g7LRXW4B+ZmNHWK6ldhLocJlc0wB3xWYuxkawdOMOiKDmUnllw7SY k+XvpPSD7OT3W91ZAfKr/bF8UAgq9U1cXIphnheNhnx3hgUJ25eW1Y19/Ucc6WP4zj9g 9OIZCGfSQzoUIbtBJN5tCdJDTMli5aQJ4GZWv086HWX55sMWbLRUqYBRYnK2D71O0J5q dbwA== X-Gm-Message-State: AGi0PuZzuNAI8O2bvxQM0x4faNl57neyE+HMkV/29ndTag7OTcIFe5RI mNjwv4T7QwQeVQg6ueKauVprXFQfoW8= X-Google-Smtp-Source: APiQypIHxYj17NVfmcnSuGrpk40/cA1y0gsCzWWQg9AehmmC7nw/0HsXW/bsHDdO/dPr7ICzSJ0SUQ== X-Received: by 2002:a5d:5445:: with SMTP id w5mr15635148wrv.422.1588864130021; Thu, 07 May 2020 08:08:50 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:355c:447d:ad3d:ac5c]) by smtp.gmail.com with ESMTPSA id u2sm10491869wrd.40.2020.05.07.08.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 08:08:49 -0700 (PDT) Date: Thu, 7 May 2020 16:08:43 +0100 From: Andrew Scull To: Marc Zyngier Subject: Re: [PATCH 07/26] KVM: arm64: Add a level hint to __kvm_tlb_flush_vmid_ipa Message-ID: <20200507150843.GG237572@google.com> References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-8-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200422120050.3693593-8-maz@kernel.org> Cc: kvm@vger.kernel.org, Andre Przywara , kvmarm@lists.cs.columbia.edu, George Cherian , "Zengtao \(B\)" , Catalin Marinas , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu > -void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu, phys_addr_t ipa) > +void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu, > + phys_addr_t ipa, int level) The level feels like a good opportunity for an enum to add some documentation from the type. > static void kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu, phys_addr_t ipa) > { > - kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu, ipa); > + kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu, ipa, 0); With the constants from the next patch brought forward, the magic 0 can be given a name, although it's very temporary so.. Otherwise, looks good. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD7BC47247 for ; Thu, 7 May 2020 15:08:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 739CA2073A for ; Thu, 7 May 2020 15:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UBT4QDt+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="QLPKtMif" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 739CA2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iFxYrtV4t3XzMAPTluZ6fS2dCjm7tTi/C5CaF1eYPR8=; b=UBT4QDt+YXiJUJ JmjxSiebYpzkTNlrcoMMtTyZnWGQOTMv3c5sIIXB4SDYtd8A0EJ2Z5/9dKnDQc1QOBxisxyiQT1lr 6wHbHETRhNQBu+UMiVMKbUeXEwnaM+Fp5KEOURLgcdBG9U40xSwlpxUovLvzgmvNBezPDdoMbqjLb wW01RqKxVmJ8Kd6QZpj0qFe1Z0bvMddBHOP0hwW8PLAoVj0xRPaKeAfwZdeTHYUo76Sc7VV3ix5WA q6qdQQckzpALmOfdRItx/7DuBKLxr+IDPpn37UlHcQo0iN+i+i6tR5mo1C/nLNVcVFf3MZ/AuRsLt UCuNlovNVzXGzmbbR+IA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWi8v-00055Y-4w; Thu, 07 May 2020 15:08:57 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWi8s-00054M-K5 for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 15:08:55 +0000 Received: by mail-wr1-x444.google.com with SMTP id j5so6827819wrq.2 for ; Thu, 07 May 2020 08:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TQa81UcYxl76b0HSzt9euhUmUepcpv3Z6r/LM6Ln5KE=; b=QLPKtMifAlPpfvwJKFqGd26kBFWPILMeiCXFGFuEBE548R8w7lgb/0jsPh1bu3DHka breNdX586T44AB8m87A/JFIhSjk18lq8Ve/dJA8HOPPUdvxMajShm3p9OrMioRH7BjNk OtO/C7ZoIrq3QXqeHbPkDtJj/UCSnMPHzfmtbcFPKku/qJ3SLGEvDZfQNIGTDQOHihp2 RZUnfXmJAg5LekkpLJLHtjTC60tVDp/QS+HCO4fpBcJAltENqV7gK5zsOYx3ba2n1ytG Gid9G0dnaQqFzt1Mv4dH7ozS4PPRWrE3NnI+YiPyf0hsTtLfCKlYI43SN/29CxJTkK6U Irsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TQa81UcYxl76b0HSzt9euhUmUepcpv3Z6r/LM6Ln5KE=; b=lf9Oalqf9zTSX4PpUxV3wxcLQu/X6paIgAcLYfdSm91RAnU5jfSfwDtuesb6fDkpNu xjohPU8qA/79VW+xRUNlRVyGzqSqoErUGft5Mj/9j7kvTV9dNAE/D6xAXlpEHk+FbmI0 d5Cv0WP+/NyeKeB8T9WkQl5GVUraZ8hS+6isEsq9EAXwdSzZcztkEKW3aexNXFaf29hI ajnxoka62x+lF6DHGdA11bvDaUtadu9EAgBVuz+ImaGEy2Ulc+d/xqOZ9EYlLpXf4fQh 7fBHv9QzvDkaEEdLQGJckQeiywlqlmGJiVKgruhTIcMaLheZLQD0ziRXpR9KeH8xx+Ke KWeA== X-Gm-Message-State: AGi0PuYZOy1YVJ+sENp+q3v27UoIKxtzlqsArGGbu1CPogQ5H6Jrcnt3 qUfZl6eFs0YoowVJoMHt24+qDw== X-Google-Smtp-Source: APiQypIHxYj17NVfmcnSuGrpk40/cA1y0gsCzWWQg9AehmmC7nw/0HsXW/bsHDdO/dPr7ICzSJ0SUQ== X-Received: by 2002:a5d:5445:: with SMTP id w5mr15635148wrv.422.1588864130021; Thu, 07 May 2020 08:08:50 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:355c:447d:ad3d:ac5c]) by smtp.gmail.com with ESMTPSA id u2sm10491869wrd.40.2020.05.07.08.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 08:08:49 -0700 (PDT) Date: Thu, 7 May 2020 16:08:43 +0100 From: Andrew Scull To: Marc Zyngier Subject: Re: [PATCH 07/26] KVM: arm64: Add a level hint to __kvm_tlb_flush_vmid_ipa Message-ID: <20200507150843.GG237572@google.com> References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-8-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200422120050.3693593-8-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_080854_681787_561F31FA X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Andre Przywara , kvmarm@lists.cs.columbia.edu, George Cherian , "Zengtao \(B\)" , Catalin Marinas , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu, phys_addr_t ipa) > +void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu, > + phys_addr_t ipa, int level) The level feels like a good opportunity for an enum to add some documentation from the type. > static void kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu, phys_addr_t ipa) > { > - kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu, ipa); > + kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu, ipa, 0); With the constants from the next patch brought forward, the magic 0 can be given a name, although it's very temporary so.. Otherwise, looks good. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE79C38A2A for ; Thu, 7 May 2020 15:08:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 194412073A for ; Thu, 7 May 2020 15:08:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QLPKtMif" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbgEGPIw (ORCPT ); Thu, 7 May 2020 11:08:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726074AbgEGPIw (ORCPT ); Thu, 7 May 2020 11:08:52 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A73A2C05BD43 for ; Thu, 7 May 2020 08:08:51 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id y3so6855680wrt.1 for ; Thu, 07 May 2020 08:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TQa81UcYxl76b0HSzt9euhUmUepcpv3Z6r/LM6Ln5KE=; b=QLPKtMifAlPpfvwJKFqGd26kBFWPILMeiCXFGFuEBE548R8w7lgb/0jsPh1bu3DHka breNdX586T44AB8m87A/JFIhSjk18lq8Ve/dJA8HOPPUdvxMajShm3p9OrMioRH7BjNk OtO/C7ZoIrq3QXqeHbPkDtJj/UCSnMPHzfmtbcFPKku/qJ3SLGEvDZfQNIGTDQOHihp2 RZUnfXmJAg5LekkpLJLHtjTC60tVDp/QS+HCO4fpBcJAltENqV7gK5zsOYx3ba2n1ytG Gid9G0dnaQqFzt1Mv4dH7ozS4PPRWrE3NnI+YiPyf0hsTtLfCKlYI43SN/29CxJTkK6U Irsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TQa81UcYxl76b0HSzt9euhUmUepcpv3Z6r/LM6Ln5KE=; b=EWYY4hiI9NIfu7sSjrPpvkrVE4Nvi0PUNQfiySohX2nfsaYGyGnbTPRWLeDaQQHu0i E4JU6TsMK2BcsYHLVk01c5t22zvn12WlCqIUHEMi0N1TRsngP1l2G/YZH6jC14046s0u A+9snzgSIIN9sNQzWSv0eE5IOztGDTtd72TtljnqaeB5czzYkffzKumyhPkjciFiN6pE z1MXft/pNe5OgB4vJuXVYqQFqn7xq64O2egnK0cKCOYx4eD4ewBjVa1f259UaeA4G9ds Ph0Yo1jVkJg66Qgdqnt1erhvSAZzp4qhMsUn1wRwi9415szrerdrLmouHr3J9qw+3HTV J+Lg== X-Gm-Message-State: AGi0PuakOliQsxuavhMiyzCR+mvCiXFaCOZdsF0aCWdsR7xq2uBckBx1 MhNp9Tm9iXDUa7b5g2aDewU3fQ== X-Google-Smtp-Source: APiQypIHxYj17NVfmcnSuGrpk40/cA1y0gsCzWWQg9AehmmC7nw/0HsXW/bsHDdO/dPr7ICzSJ0SUQ== X-Received: by 2002:a5d:5445:: with SMTP id w5mr15635148wrv.422.1588864130021; Thu, 07 May 2020 08:08:50 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:355c:447d:ad3d:ac5c]) by smtp.gmail.com with ESMTPSA id u2sm10491869wrd.40.2020.05.07.08.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 08:08:49 -0700 (PDT) Date: Thu, 7 May 2020 16:08:43 +0100 From: Andrew Scull To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Will Deacon , Andre Przywara , Dave Martin , George Cherian , "Zengtao (B)" , Catalin Marinas Subject: Re: [PATCH 07/26] KVM: arm64: Add a level hint to __kvm_tlb_flush_vmid_ipa Message-ID: <20200507150843.GG237572@google.com> References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-8-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422120050.3693593-8-maz@kernel.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > -void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu, phys_addr_t ipa) > +void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu, > + phys_addr_t ipa, int level) The level feels like a good opportunity for an enum to add some documentation from the type. > static void kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu, phys_addr_t ipa) > { > - kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu, ipa); > + kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu, ipa, 0); With the constants from the next patch brought forward, the magic 0 can be given a name, although it's very temporary so.. Otherwise, looks good.