From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 991EEC38A2A for ; Thu, 7 May 2020 15:13:33 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 23E862063A for ; Thu, 7 May 2020 15:13:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="KTP/UuKn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23E862063A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DBACB4B3D8; Thu, 7 May 2020 11:13:31 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fVy5kjgIPyul; Thu, 7 May 2020 11:13:30 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CA68C4B274; Thu, 7 May 2020 11:13:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 619F14B274 for ; Thu, 7 May 2020 11:13:29 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EgFzaFzPOTLz for ; Thu, 7 May 2020 11:13:28 -0400 (EDT) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4BB914B24E for ; Thu, 7 May 2020 11:13:28 -0400 (EDT) Received: by mail-wr1-f66.google.com with SMTP id h9so6862712wrt.0 for ; Thu, 07 May 2020 08:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=S2uo98FwAjVg5CWP5Av+uIlNFRj0bTJ/Soj3by7c/U4=; b=KTP/UuKnmFq2SPCo2FGyvoGogXVtgtFTX5B4pJ8o/uSdf2i17qIMcFtyhsPPurcepl TbE5Rgj3LKq1EPMC9Co4rtvTM66GKJ56TWPuka3aSQqzUCOVcYjbiDExz6JDELbOQDAG wSB2FwSYtEWaFVYj6juw+K/c+6PgofSbKHcoRnalTJBpuFTSlfwRcSjqHzZbRpKqboFw tMOt470dTW4GQir+16tCiljhjjBZt3GqcbkmGJGPM2qE2G50yC2baZINqrYNUQCpWGYq CLuFbuEi3wSxnL0lNFoOAgCyVRtv1Fr1W/+sFw0ohgtjSiGprk1+wysg1+kwJ37SpF32 Ocaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S2uo98FwAjVg5CWP5Av+uIlNFRj0bTJ/Soj3by7c/U4=; b=Ouz7bNsNB2GnA/yCy5lHr1+7pLxjF0eZBEdxvs0FkQEwHL8HVGxYdaUaFNL8a3JfeL 8G7amF9UIkiigngB3tZiw1W381QiLHy5N9XeSny3S06svlTXFLBaUsMTfuravYnlpsD+ RpBbF94P2jyz6fX5MauyWMBIiD8+kDgjIV1mt1JR35xnkgYxb7H76yRgsQ2K/PkxVUk4 Qwc2Olf+1sKydgxQtvCw8/Vhp/Py50t+xkXOrmpuoMgktno/T3yV/fH1l2I3fb92GRzn u766FtTPxnhVCujn56MGufwIA3eKXWIJbRkjQDuuo7U2I+Y4Q8Y0iaQawoy3KqtgsSMh kJig== X-Gm-Message-State: AGi0PubpXFrBMXsao6+zholLhz/4wCPWxlGCmA+pSzZUPA6l51ZKhnaj xV/zGnKamy+7PF9QP+UN1RimGQ== X-Google-Smtp-Source: APiQypLNfmFFEmEkdVcn8CcdE0QmpbeyzViDZ82NLnSF0CRXgetg8FYsnaOyp6ozrpX3U1nd3rIVtg== X-Received: by 2002:a5d:6705:: with SMTP id o5mr9808907wru.426.1588864406980; Thu, 07 May 2020 08:13:26 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:355c:447d:ad3d:ac5c]) by smtp.gmail.com with ESMTPSA id t16sm8235479wmi.27.2020.05.07.08.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 08:13:26 -0700 (PDT) Date: Thu, 7 May 2020 16:13:21 +0100 From: Andrew Scull To: Marc Zyngier Subject: Re: [PATCH 08/26] KVM: arm64: Use TTL hint in when invalidating stage-2 translations Message-ID: <20200507151321.GH237572@google.com> References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-9-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200422120050.3693593-9-maz@kernel.org> Cc: kvm@vger.kernel.org, Andre Przywara , kvmarm@lists.cs.columbia.edu, George Cherian , "Zengtao \(B\)" , Catalin Marinas , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu > @@ -176,7 +177,7 @@ static void clear_stage2_pud_entry(struct kvm_s2_mmu *mmu, pud_t *pud, phys_addr > pmd_t *pmd_table __maybe_unused = stage2_pmd_offset(kvm, pud, 0); > VM_BUG_ON(stage2_pud_huge(kvm, *pud)); > stage2_pud_clear(kvm, pud); > - kvm_tlb_flush_vmid_ipa(mmu, addr); > + kvm_tlb_flush_vmid_ipa(mmu, addr, S2_NO_LEVEL_HINT); > stage2_pmd_free(kvm, pmd_table); > put_page(virt_to_page(pud)); > } > @@ -186,7 +187,7 @@ static void clear_stage2_pmd_entry(struct kvm_s2_mmu *mmu, pmd_t *pmd, phys_addr > pte_t *pte_table = pte_offset_kernel(pmd, 0); > VM_BUG_ON(pmd_thp_or_huge(*pmd)); > pmd_clear(pmd); > - kvm_tlb_flush_vmid_ipa(mmu, addr); > + kvm_tlb_flush_vmid_ipa(mmu, addr, S2_NO_LEVEL_HINT); > free_page((unsigned long)pte_table); > put_page(virt_to_page(pmd)); > } Going by the names, is it possible to give a better level hint for these cases? _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D188CC47247 for ; Thu, 7 May 2020 15:13:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A713C2063A for ; Thu, 7 May 2020 15:13:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QXsHB0cJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="KTP/UuKn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A713C2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zCwGlWm/hZ2HFIB9JxPZLPrFQp/+UYE8uP/4Q/gDo7s=; b=QXsHB0cJ4WR2Fs cxjtEuhNxg24vkXXrnLDqoEbyuay/JQS+OQccvt/4/KLlba/28JyhMoOLizObNxhcpmZUJahSYQcn lDDKwlSuapZdR2/KFQwkhurTyTpab/1lNhoT/RJIw2A/M1I4If+6l2PmrGmuQhFMdH9RWmI9LmQ+u T4RL1XZTYr/nlsRYfzktQTCrtoYOYhRdx+qMLk/wdDdzhvMIWuEU9uG4vEiURfBz2hi4F+dobwsdA WX/HpfFBMQZoGCmKW5DgE9mKYqZk8fTqye0aLprtpioIqLCjy9a3tdOgkm9aMealr0b3Mg9lRSIt7 CVfNJg5+v22WYTCVrABQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWiDM-00015Y-9T; Thu, 07 May 2020 15:13:32 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWiDI-00012H-OR for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 15:13:30 +0000 Received: by mail-wr1-x441.google.com with SMTP id i15so6411595wrx.10 for ; Thu, 07 May 2020 08:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=S2uo98FwAjVg5CWP5Av+uIlNFRj0bTJ/Soj3by7c/U4=; b=KTP/UuKnmFq2SPCo2FGyvoGogXVtgtFTX5B4pJ8o/uSdf2i17qIMcFtyhsPPurcepl TbE5Rgj3LKq1EPMC9Co4rtvTM66GKJ56TWPuka3aSQqzUCOVcYjbiDExz6JDELbOQDAG wSB2FwSYtEWaFVYj6juw+K/c+6PgofSbKHcoRnalTJBpuFTSlfwRcSjqHzZbRpKqboFw tMOt470dTW4GQir+16tCiljhjjBZt3GqcbkmGJGPM2qE2G50yC2baZINqrYNUQCpWGYq CLuFbuEi3wSxnL0lNFoOAgCyVRtv1Fr1W/+sFw0ohgtjSiGprk1+wysg1+kwJ37SpF32 Ocaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S2uo98FwAjVg5CWP5Av+uIlNFRj0bTJ/Soj3by7c/U4=; b=aXdBEjiomi2/+Lg7cAwAU2OfW1Iyes5dgboqGmvTu+r5S/OgrcnrJIEyWBapQ6fyEJ k6bW/2K5YGWgJ/aDZYmcX4t8liet/irE69q7VxjHkE2JewR3FJAtCnNN+oFqujqK7ohW ZY6ofbbRb2/RlTElzMDvBrm4ybNYjSG+f8TmS/JOfhnBoH2agKwa21+neWJ3lttjyVap HE1HROMXUkZt7rXUiw2RgjWzH4simXodZwT5UnbVyPgpE9X6f99JHZ7nvyS2jzpT/oEt Eu28jVHbUzahbZC+1v4hOW/Adlvqj6qETaY61rBzVVcg8UvuDT+dwE7TDb1Lkqvk36/Y E6Jw== X-Gm-Message-State: AGi0PuaGlzGFG6pOrrYY5cU6DHIN+9FqfNeU9/TLx2dK0jGiB0Y2A/7w ph4cJFpPRqi/XAHa0obep+k4/Q== X-Google-Smtp-Source: APiQypLNfmFFEmEkdVcn8CcdE0QmpbeyzViDZ82NLnSF0CRXgetg8FYsnaOyp6ozrpX3U1nd3rIVtg== X-Received: by 2002:a5d:6705:: with SMTP id o5mr9808907wru.426.1588864406980; Thu, 07 May 2020 08:13:26 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:355c:447d:ad3d:ac5c]) by smtp.gmail.com with ESMTPSA id t16sm8235479wmi.27.2020.05.07.08.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 08:13:26 -0700 (PDT) Date: Thu, 7 May 2020 16:13:21 +0100 From: Andrew Scull To: Marc Zyngier Subject: Re: [PATCH 08/26] KVM: arm64: Use TTL hint in when invalidating stage-2 translations Message-ID: <20200507151321.GH237572@google.com> References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-9-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200422120050.3693593-9-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_081328_873345_FEE84F51 X-CRM114-Status: GOOD ( 10.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Andre Przywara , kvmarm@lists.cs.columbia.edu, George Cherian , "Zengtao \(B\)" , Catalin Marinas , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > @@ -176,7 +177,7 @@ static void clear_stage2_pud_entry(struct kvm_s2_mmu *mmu, pud_t *pud, phys_addr > pmd_t *pmd_table __maybe_unused = stage2_pmd_offset(kvm, pud, 0); > VM_BUG_ON(stage2_pud_huge(kvm, *pud)); > stage2_pud_clear(kvm, pud); > - kvm_tlb_flush_vmid_ipa(mmu, addr); > + kvm_tlb_flush_vmid_ipa(mmu, addr, S2_NO_LEVEL_HINT); > stage2_pmd_free(kvm, pmd_table); > put_page(virt_to_page(pud)); > } > @@ -186,7 +187,7 @@ static void clear_stage2_pmd_entry(struct kvm_s2_mmu *mmu, pmd_t *pmd, phys_addr > pte_t *pte_table = pte_offset_kernel(pmd, 0); > VM_BUG_ON(pmd_thp_or_huge(*pmd)); > pmd_clear(pmd); > - kvm_tlb_flush_vmid_ipa(mmu, addr); > + kvm_tlb_flush_vmid_ipa(mmu, addr, S2_NO_LEVEL_HINT); > free_page((unsigned long)pte_table); > put_page(virt_to_page(pmd)); > } Going by the names, is it possible to give a better level hint for these cases? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06010C54E4A for ; Thu, 7 May 2020 15:13:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4211207DD for ; Thu, 7 May 2020 15:13:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KTP/UuKn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728045AbgEGPN3 (ORCPT ); Thu, 7 May 2020 11:13:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726495AbgEGPN2 (ORCPT ); Thu, 7 May 2020 11:13:28 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80219C05BD43 for ; Thu, 7 May 2020 08:13:28 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id x17so6840231wrt.5 for ; Thu, 07 May 2020 08:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=S2uo98FwAjVg5CWP5Av+uIlNFRj0bTJ/Soj3by7c/U4=; b=KTP/UuKnmFq2SPCo2FGyvoGogXVtgtFTX5B4pJ8o/uSdf2i17qIMcFtyhsPPurcepl TbE5Rgj3LKq1EPMC9Co4rtvTM66GKJ56TWPuka3aSQqzUCOVcYjbiDExz6JDELbOQDAG wSB2FwSYtEWaFVYj6juw+K/c+6PgofSbKHcoRnalTJBpuFTSlfwRcSjqHzZbRpKqboFw tMOt470dTW4GQir+16tCiljhjjBZt3GqcbkmGJGPM2qE2G50yC2baZINqrYNUQCpWGYq CLuFbuEi3wSxnL0lNFoOAgCyVRtv1Fr1W/+sFw0ohgtjSiGprk1+wysg1+kwJ37SpF32 Ocaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S2uo98FwAjVg5CWP5Av+uIlNFRj0bTJ/Soj3by7c/U4=; b=n9/gOS21Kx4PmSfmNb3slgRinmlpBCZDIbGMFqp1msLwIG47sMQNqcJNFgAQ5+Q4uN b0/gu/KA0v3z+SbhTxwp74/bydJwCS1/wezni/3KVZjkhQWZQ2nvwROMHpjSiMpYf1VB +dI59gsD+r16R3jHtLxoXxrTPRwmCIuickBYa2N1jhJEFXJstEoocQlekEUJVDUnP7bi PmEhhio6e4pcF4eLlVXfTvfDiQp9T2b61Ak69QG09rOo7PooyOax5BjCubCA9pTxllSY +9HnQlMesfnSjjn2LtWw6gzLbf9FaSTA+kwRrnpUhAhvDv7dOvSnmM1HjJexZm1WgLRP eHQg== X-Gm-Message-State: AGi0PuaLWPDVsw7W978B7zywas5w0Kt8OuaFbrMB5iyLKXhfaJfIXC4h FiFUBucNuyuv26EYYg4kg01yQ/BGNKs= X-Google-Smtp-Source: APiQypLNfmFFEmEkdVcn8CcdE0QmpbeyzViDZ82NLnSF0CRXgetg8FYsnaOyp6ozrpX3U1nd3rIVtg== X-Received: by 2002:a5d:6705:: with SMTP id o5mr9808907wru.426.1588864406980; Thu, 07 May 2020 08:13:26 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:355c:447d:ad3d:ac5c]) by smtp.gmail.com with ESMTPSA id t16sm8235479wmi.27.2020.05.07.08.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 08:13:26 -0700 (PDT) Date: Thu, 7 May 2020 16:13:21 +0100 From: Andrew Scull To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Will Deacon , Andre Przywara , Dave Martin , George Cherian , "Zengtao (B)" , Catalin Marinas Subject: Re: [PATCH 08/26] KVM: arm64: Use TTL hint in when invalidating stage-2 translations Message-ID: <20200507151321.GH237572@google.com> References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-9-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422120050.3693593-9-maz@kernel.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > @@ -176,7 +177,7 @@ static void clear_stage2_pud_entry(struct kvm_s2_mmu *mmu, pud_t *pud, phys_addr > pmd_t *pmd_table __maybe_unused = stage2_pmd_offset(kvm, pud, 0); > VM_BUG_ON(stage2_pud_huge(kvm, *pud)); > stage2_pud_clear(kvm, pud); > - kvm_tlb_flush_vmid_ipa(mmu, addr); > + kvm_tlb_flush_vmid_ipa(mmu, addr, S2_NO_LEVEL_HINT); > stage2_pmd_free(kvm, pmd_table); > put_page(virt_to_page(pud)); > } > @@ -186,7 +187,7 @@ static void clear_stage2_pmd_entry(struct kvm_s2_mmu *mmu, pmd_t *pmd, phys_addr > pte_t *pte_table = pte_offset_kernel(pmd, 0); > VM_BUG_ON(pmd_thp_or_huge(*pmd)); > pmd_clear(pmd); > - kvm_tlb_flush_vmid_ipa(mmu, addr); > + kvm_tlb_flush_vmid_ipa(mmu, addr, S2_NO_LEVEL_HINT); > free_page((unsigned long)pte_table); > put_page(virt_to_page(pmd)); > } Going by the names, is it possible to give a better level hint for these cases?