From: Christoph Hellwig <hch@lst.de>
To: Stefan Haberland <sth@linux.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org,
hoeppner@linux.ibm.com, linux-s390@vger.kernel.org,
heiko.carstens@de.ibm.com, gor@linux.ibm.com,
borntraeger@de.ibm.com, linux-kernel@vger.kernel.org,
Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver
Date: Thu, 7 May 2020 17:29:06 +0200 [thread overview]
Message-ID: <20200507152906.GA31257@lst.de> (raw)
In-Reply-To: <10918cd1-a4a9-7872-9672-efcd28ef0751@linux.ibm.com>
On Thu, May 07, 2020 at 05:22:28PM +0200, Stefan Haberland wrote:
> OK, just thought again about your suggestion and also that
> you have already been talking about a symbol lookup I just
> have written a prototype that took your first two patches
> as base, exports the symbol of dasd_biodasdinfo and in
> ibm.c I do a kallsyms_lookup_name("dasd_biodasdinfo").
>
> So I would not have to define a structure twice or rely on
> MAJORs. Also we would not have to define an own file
> operation only for DASD devices.
>
> What do you think about this? If you agree I will polish
> the patches, test them and send them for review.
How do you figure out a given gendisk is a DASD device? I guess
dasd_biodasdinfo could just check the block_device_operations
pointer first thing. That's still a little ugly, but seems the
least bad idea so far, so please at least post it for discussion.
next prev parent reply other threads:[~2020-05-07 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 11:17 [PATCH 0/1] remove ioclt_by_bdev from DASD Stefan Haberland
2020-04-30 11:17 ` [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver Stefan Haberland
2020-04-30 13:13 ` Christoph Hellwig
2020-04-30 14:02 ` Stefan Haberland
2020-05-04 8:45 ` Stefan Haberland
2020-05-05 12:44 ` Christoph Hellwig
2020-05-05 15:09 ` Stefan Haberland
2020-05-06 4:52 ` Christoph Hellwig
2020-05-07 15:22 ` Stefan Haberland
2020-05-07 15:29 ` Christoph Hellwig [this message]
2020-05-07 15:43 ` Stefan Haberland
2020-05-07 15:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507152906.GA31257@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=sth@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.