From: sdf@google.com
To: Martin KaFai Lau <kafai@fb.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
ast@kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH bpf-next v3 3/5] selftests/bpf: move existing common networking parts into network_helpers
Date: Thu, 7 May 2020 09:14:07 -0700 [thread overview]
Message-ID: <20200507161407.GJ241848@google.com> (raw)
In-Reply-To: <20200507061244.63ztqtmiid64xptv@kafai-mbp>
On 05/06, Martin KaFai Lau wrote:
> On Wed, May 06, 2020 at 03:32:08PM -0700, Stanislav Fomichev wrote:
> > 1. Move pkt_v4 and pkt_v6 into network_helpers and adjust the users.
> > 2. Copy-paste spin_lock_thread into two tests that use it.
> Instead of copying it into two tests,
> can spin_lock_thread be moved to network-helpers.c?
spin_lock_thread doesn't look like something that can be reused
by other networking tests and looks very specific to
prog_tests/spinlock.c and prog_tests/map_lock.c. It might be
better with the copy-paste now because that thread definition
is closer to the place that uses it.
I don't feel strongly about it and can put it into network_helpers.
Let me know if you prefer it that way.
next prev parent reply other threads:[~2020-05-07 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 22:32 [PATCH bpf-next v3 0/5] bpf: allow any port in bpf_bind helper Stanislav Fomichev
2020-05-06 22:32 ` [PATCH bpf-next v3 1/5] selftests/bpf: generalize helpers to control background listener Stanislav Fomichev
2020-05-07 6:09 ` Martin KaFai Lau
2020-05-07 15:56 ` Jakub Sitnicki
2020-05-07 16:15 ` sdf
2020-05-06 22:32 ` [PATCH bpf-next v3 2/5] selftests/bpf: adopt accept_timeout from sockmap_listen Stanislav Fomichev
2020-05-06 22:32 ` [PATCH bpf-next v3 3/5] selftests/bpf: move existing common networking parts into network_helpers Stanislav Fomichev
2020-05-07 6:12 ` Martin KaFai Lau
2020-05-07 16:14 ` sdf [this message]
2020-05-07 16:18 ` Andrii Nakryiko
2020-05-06 22:32 ` [PATCH bpf-next v3 4/5] net: refactor arguments of inet{,6}_bind Stanislav Fomichev
2020-05-07 6:15 ` Martin KaFai Lau
2020-05-06 22:32 ` [PATCH bpf-next v3 5/5] bpf: allow any port in bpf_bind helper Stanislav Fomichev
2020-05-07 6:29 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507161407.GJ241848@google.com \
--to=sdf@google.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.