From: Greg KH <gregkh@linuxfoundation.org>
To: Edward Cree <ecree@solarflare.com>
Cc: "Saleem, Shiraz" <shiraz.saleem@intel.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Ertman, David M" <david.m.ertman@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"ranjani.sridharan@linux.intel.com"
<ranjani.sridharan@linux.intel.com>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Bowers, AndrewX" <andrewx.bowers@intel.com>,
Martin Habets <mhabets@solarflare.com>
Subject: Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA
Date: Thu, 7 May 2020 18:35:31 +0200 [thread overview]
Message-ID: <20200507163531.GA2100062@kroah.com> (raw)
In-Reply-To: <ef4bb479-1669-7611-81c8-cd21497d9103@solarflare.com>
On Thu, May 07, 2020 at 04:24:32PM +0100, Edward Cree wrote:
> On 07/05/2020 16:06, Greg KH wrote:
> > I can't accept that this series is using a virtual bus properly without
> > actually using the virtual bus driver code, can you?
> I might be misunderstanding, but I *think* a hardware driver likeice is
> the 'provider' of a virtbus, and it's only 'consumers' of it (like an
> RDMA device talking to that ice instance) that are virtbus_drivers.
> Though tbh I'm not entirely happy either with a series that adds the
> provider side but not any users... and either way, the documentation
> *really* doesn't make it clear whether it works the way I think it does
> or not.
Exactly, I can't tell anything from the documentation at all, so I
looked at how the code was used. That just made things worse...
This needs more work.
greg k-h
next prev parent reply other threads:[~2020-05-07 16:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 21:04 [net-next v3 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-05 Jeff Kirsher
2020-05-06 21:04 ` [net-next v3 1/9] Implementation of Virtual Bus Jeff Kirsher
2020-05-07 8:06 ` Greg KH
2020-05-06 21:04 ` [net-next v3 2/9] ice: Create and register virtual bus for RDMA Jeff Kirsher
2020-05-07 8:17 ` Greg KH
2020-05-07 14:04 ` Saleem, Shiraz
2020-05-07 15:06 ` Greg KH
2020-05-07 15:24 ` Edward Cree
2020-05-07 16:35 ` Greg KH [this message]
2020-05-06 21:04 ` [net-next v3 3/9] ice: Complete RDMA peer registration Jeff Kirsher
2020-05-06 21:05 ` [net-next v3 4/9] ice: Support resource allocation requests Jeff Kirsher
2020-05-06 21:05 ` [net-next v3 5/9] ice: Enable event notifications Jeff Kirsher
2020-05-06 21:05 ` [net-next v3 6/9] ice: Allow reset operations Jeff Kirsher
2020-05-06 21:05 ` [net-next v3 7/9] ice: Pass through communications to VF Jeff Kirsher
2020-05-06 21:05 ` [net-next v3 8/9] i40e: Move client header location Jeff Kirsher
2020-05-06 21:05 ` [net-next v3 9/9] i40e: Register a virtbus device to provide RDMA Jeff Kirsher
2020-05-07 7:00 ` [net-next v3 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-05 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507163531.GA2100062@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrewx.bowers@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=ecree@solarflare.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sassmann@redhat.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.