From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC4CC38A24 for ; Thu, 7 May 2020 15:25:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CB7A207DD for ; Thu, 7 May 2020 15:25:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YEDQJ5Wk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CB7A207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n0z+Pu3UxP8a9LjxwyN84xqxgk6/1DAdyVphfPQ4xbQ=; b=YEDQJ5WkA9pMkG GO8xXz8+cQA+LO0aVbnlMJOk5DmT6VkgREhQlZCppXoiHaQCOgFziKhldV41n+e1d5qxi6+VFVKzQ HsBEzYZiAUu8pXDfYhyD8W0b88XFyPKmXyWrkrSSZIfVY5gdsVUCo0+CwNTdfT+oiOPfAnxZm9GZ5 LC/5QDNZ5Tijuc9kf8YBSXvCF2SSMnp1LxueicEYemud/Xm6fy12etIdlCDXjzNGLFEzm6Ku4KJ6L HPEk82AAPsn98HBdCF4xozsGAdoJaLnRSIKMYfsoIuZku4BFRXpPtivr1VNHrf0gBQd2LpJzWUvh+ v+WfY3knvMhtqdn4teYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWiOV-0001aJ-4v; Thu, 07 May 2020 15:25:03 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWiOS-0001V2-BW for linux-mtd@lists.infradead.org; Thu, 07 May 2020 15:25:01 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id DECBF2A204A; Thu, 7 May 2020 16:24:55 +0100 (BST) Date: Thu, 7 May 2020 17:24:53 +0200 From: Boris Brezillon To: Miquel Raynal , Vignesh Raghavendra Subject: Re: [PATCH v3 7/8] mtd: rawnand: arasan: Add new Arasan NAND controller Message-ID: <20200507172453.15a03574@collabora.com> In-Reply-To: <20200507171311.7669d0db@xps13> References: <20200507110034.14736-1-miquel.raynal@bootlin.com> <20200507110034.14736-8-miquel.raynal@bootlin.com> <20200507141103.0c241877@collabora.com> <20200507171311.7669d0db@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_082500_527975_4F504A86 X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Michal Simek , Tudor Ambarus , Richard Weinberger , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Naga Sureshkumar Relli Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gVGh1LCA3IE1heSAyMDIwIDE3OjEzOjExICswMjAwCk1pcXVlbCBSYXluYWwgPG1pcXVlbC5y YXluYWxAYm9vdGxpbi5jb20+IHdyb3RlOgoKPiBIaSBCb3JpcywKPiAKPiBCb3JpcyBCcmV6aWxs b24gPGJvcmlzLmJyZXppbGxvbkBjb2xsYWJvcmEuY29tPiB3cm90ZSBvbiBUaHUsIDcgTWF5Cj4g MjAyMCAxNDoxMTowMyArMDIwMDoKPiAKPiA+IE9uIFRodSwgIDcgTWF5IDIwMjAgMTM6MDA6MzMg KzAyMDAKPiA+IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+IHdyb3Rl Ogo+ID4gCj4gPiAgIAo+ID4gPiArCj4gPiA+ICtzdGF0aWMgdm9pZCBhbmZjX2NoaXBzX2NsZWFu dXAoc3RydWN0IGFyYXNhbl9uZmMgKm5mYykKPiA+ID4gK3sKPiA+ID4gKwlzdHJ1Y3QgYW5hbmQg KmFuYW5kLCAqdG1wOwo+ID4gPiArCj4gPiA+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKGFu YW5kLCB0bXAsICZuZmMtPmNoaXBzLCBub2RlKSB7Cj4gPiA+ICsJCW5hbmRfcmVsZWFzZSgmYW5h bmQtPmNoaXApOyAgICAKPiA+IAo+ID4gCQlyZXQgPSBtdGRfZGV2aWNlX3VucmVnaXN0ZXIobmFu ZF90b19tdGQoJmFuYW5kLT5jaGlwKSk7Cj4gPiAJCVdBUk5fT04ocmV0KTsKPiA+IAkJbmFuZF9j bGVhbnVwKCZhbmFuZC0+Y2hpcCk7Cj4gPiAKPiA+IE9yIG1heWJlIGFkZCB0aGlzIFdBUk5fT04o KSB0byBuYW5kX3JlbGVhc2UoKSBzbyB3ZSBkb24ndCBoYXZlIHRvIGFzawo+ID4gcGVvcGxlIHRv IHVzZSBtdGRfZGV2aWNlX3VucmVnaXN0ZXIoKSArIG5hbmRfY2xlYW51cCgpLiAgCj4gCj4gSSBk b24ndCBnZXQgeW91ciBwb2ludCBoZXJlPyBJJ20gbm90IGFnYWluc3QgYWRkaW5nIGEgd2Fybl9v biBiZXR3ZWVuCj4gYm90aCBmdW5jdGlvbnMgYnV0IGl0J3Mgbm90IHJlbGF0ZWQgdG8gdGhpcyBk cml2ZXI/CgpXZSd2ZSBhc2tlZCBwZW9wbGUgdG8gbm90IGNhbGwgbmFuZF9yZWxlYXNlKCkgYnV0 IGluc3RlYWQgY2FsbAptdGRfZGV2aWNlX3VucmVnaXN0ZXIoKStuYW5kX2NsZWFudXAoKSwgd2hp Y2ggaXMgbm90IGRvbmUgaGVyZS4gTXkKcG9pbnQgaXMsIGlmIGV2ZW4gdXMgY2FuJ3QgZ2V0IGl0 IHJpZ2h0LCBtYXliZSBpdCdzIGEgc2lnbiB3ZSBzaG91bGQKaW5zdGVhZCBwYXRjaCBuYW5kX3Jl bGVhc2UoKSB0byBkbyB0aGUgcmlnaHQgdGhpbmcuCgo+IAo+ID4gV2UgcmVhbGx5Cj4gPiBzaG91 bGQgZml4IHRoYXQgYXQgc29tZSBwb2ludCAoYWxsb2NhdGUgbmFuZF9jaGlwIGFuZCBtdGRfaW5m bwo+ID4gc2VwYXJhdGVseSBhbmQgbGVhdmUgYSBkdW1teSBtdGRfaW5mbyBvYmplY3Qgd2l0aCBh bGwgaG9va3MgcmV0dXJuaW5nCj4gPiBFTk9ERVYgd2hlbiB0aGUgdW5yZWdpc3RlciBmYWlscyku ICAKPiAKPiBZZXMsIHdlIHNob3VsZCBmaXggdGhhdC4KPiAKPiA+ICAgCj4gPiA+ICsJCWxpc3Rf ZGVsKCZhbmFuZC0+bm9kZSk7Cj4gPiA+ICsJfQo+ID4gPiArfSAgICAKPiAKPiBUaGFua3MsCj4g TWlxdcOobAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FE6C38A24 for ; Thu, 7 May 2020 15:25:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E303B207DD for ; Thu, 7 May 2020 15:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbgEGPY7 convert rfc822-to-8bit (ORCPT ); Thu, 7 May 2020 11:24:59 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:39856 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgEGPY7 (ORCPT ); Thu, 7 May 2020 11:24:59 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id DECBF2A204A; Thu, 7 May 2020 16:24:55 +0100 (BST) Date: Thu, 7 May 2020 17:24:53 +0200 From: Boris Brezillon To: Miquel Raynal , Vignesh Raghavendra Cc: Mark Rutland , Rob Herring , , Richard Weinberger , Tudor Ambarus , , Thomas Petazzoni , Michal Simek , Naga Sureshkumar Relli Subject: Re: [PATCH v3 7/8] mtd: rawnand: arasan: Add new Arasan NAND controller Message-ID: <20200507172453.15a03574@collabora.com> In-Reply-To: <20200507171311.7669d0db@xps13> References: <20200507110034.14736-1-miquel.raynal@bootlin.com> <20200507110034.14736-8-miquel.raynal@bootlin.com> <20200507141103.0c241877@collabora.com> <20200507171311.7669d0db@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 7 May 2020 17:13:11 +0200 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Thu, 7 May > 2020 14:11:03 +0200: > > > On Thu, 7 May 2020 13:00:33 +0200 > > Miquel Raynal wrote: > > > > > > > + > > > +static void anfc_chips_cleanup(struct arasan_nfc *nfc) > > > +{ > > > + struct anand *anand, *tmp; > > > + > > > + list_for_each_entry_safe(anand, tmp, &nfc->chips, node) { > > > + nand_release(&anand->chip); > > > > ret = mtd_device_unregister(nand_to_mtd(&anand->chip)); > > WARN_ON(ret); > > nand_cleanup(&anand->chip); > > > > Or maybe add this WARN_ON() to nand_release() so we don't have to ask > > people to use mtd_device_unregister() + nand_cleanup(). > > I don't get your point here? I'm not against adding a warn_on between > both functions but it's not related to this driver? We've asked people to not call nand_release() but instead call mtd_device_unregister()+nand_cleanup(), which is not done here. My point is, if even us can't get it right, maybe it's a sign we should instead patch nand_release() to do the right thing. > > > We really > > should fix that at some point (allocate nand_chip and mtd_info > > separately and leave a dummy mtd_info object with all hooks returning > > ENODEV when the unregister fails). > > Yes, we should fix that. > > > > > > + list_del(&anand->node); > > > + } > > > +} > > Thanks, > Miquèl