Re: [PATCH 2/2] libmultipath: create libdir on install

[Christian Hesse <list@eworm.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1831 bytes --]

Martin Wilck <mwilck@suse.com> on Thu, 2020/05/07 23:13:
> On Wed, 2020-05-06 at 09:48 +0200, Christian Hesse wrote:
> > Christian Hesse <list@eworm.de> on Wed, 2020/05/06 09:35:  
> > > From: Christian Hesse <mail@eworm.de>
> > > 
> > > Without this installation fails with:
> > > 
> > > install: target '$DESTDIR/usr/lib/multipath' is not a directory
> > > Signed-off-by: Christian Hesse <mail@eworm.de>
> > > ---
> > >  libmultipath/prioritizers/Makefile | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/libmultipath/prioritizers/Makefile
> > > b/libmultipath/prioritizers/Makefile index 9d0fe03c..11da5be2
> > > 100644
> > > --- a/libmultipath/prioritizers/Makefile
> > > +++ b/libmultipath/prioritizers/Makefile
> > > @@ -35,6 +35,7 @@ libprio%.so: %.o
> > >  	$(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^
> > >  
> > >  install: $(LIBS)
> > > +	$(INSTALL_PROGRAM) -d $(DESTDIR)$(libdir)
> > >  	$(INSTALL_PROGRAM) -m 755 libprio*.so $(DESTDIR)$(libdir)
> > >  
> > >  uninstall:  
> > 
> > Ignore this one... It does not fix the issue. The build system has to
> > be
> > fixed for simultaneous jobs when installing.
> > 
> > For now installing with just one job (`make -j1`).  
> 
> Right. Feel free to send patches for this. I've never felt the urge to
> run "make install" parallelized; it takes less then 1s on my laptop.

Well, doing things in parallel is the default on our build servers... Via
environment variable MAKEFLAGS="-j#". Running just one job is extra work. :-p

If I have some spare time I will have a look again.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]