From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AC4EC47247 for ; Fri, 8 May 2020 09:54:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5054120A8B for ; Fri, 8 May 2020 09:54:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="fZZ1hS1a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="IVz5NEuA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5054120A8B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCA2C6E083; Fri, 8 May 2020 09:54:39 +0000 (UTC) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC1BF6E083 for ; Fri, 8 May 2020 09:54:38 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 44EE05800E1; Fri, 8 May 2020 05:54:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 08 May 2020 05:54:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=fNKb2E3cngycuSCYlu4bdd4ggu3 a874dABTj/kMWUm0=; b=fZZ1hS1aaqVwquRtjcmtV1uwMAChocqg77h2wS5q+6S CTysKclNK/nv1Ft+POR8eY2bzp6wyx1jkI1pa4yKymYwQ3lSeVCpgKskekxOwW3V rYg6ASUEIRO3CZdc+xmfLgwrTD51JKxI5uH23frrKvJlMI5sctciSycR5co756gT O6RCa8jTgEK5lxWREhRAQSSQL0uZ5lS1ncnghdP+ak1Fn+mjn4+4WvUL36MB08U4 AsInFYHnz+r1lMwf9MwqOJE/VSxkw42eaqNgThGWYleWyQBZKEXysu0D+zo4dpk9 O9jsRiF2Fo6dYxpDxvSJkLnW6Zch17Pg1XQQh417vig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=fNKb2E 3cngycuSCYlu4bdd4ggu3a874dABTj/kMWUm0=; b=IVz5NEuAd8YNG9zOll2WGv LVMirSGHhkmKzHsqzIRU4vmwPY06iaA0ZVqkLHvTQQbSKqK+ZuXHLRLcpXm/x7Yc Eyu8tN5q0QQpK4I+Pjbfjx6PBYHceqm3zupvXr3RUF6DJaEMnRPRL2OSzF2bWU1e ghvZprSJtjEiZwczQ9eDWI5xn9nAfhKvHAj7SvYdg09cONqYpQRzqpKuM/nwUf2R UlHaPU7Fx2fp2DtesP6A4dQUUP27/EL7jaoMyJGB5vE8Snss5VdaEkAR4wsn5WzC z9PG2hV24VVGvxLatb9PHfAcKTNzbvECGCT1VyNiwIvi0zlU3JMMxB0PcVcet4EQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkedvgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuheejgf ffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecukfhppeekfedr keeirdekledruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 85EC73280066; Fri, 8 May 2020 05:54:32 -0400 (EDT) Date: Fri, 8 May 2020 11:54:26 +0200 From: Greg KH To: Yves-Alexis Perez Subject: Re: [PATCH] drm/atomic: Take the atomic toys away from X Message-ID: <20200508095426.GA3778290@kroah.com> References: <20190903190642.32588-1-daniel.vetter@ffwll.ch> <20190905185318.31363-1-daniel.vetter@ffwll.ch> <2a05f4c4362d386d298a06a67f2f528ef603a734.camel@debian.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2a05f4c4362d386d298a06a67f2f528ef603a734.camel@debian.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development , Michel =?iso-8859-1?Q?D=E4nzer?= , stable@vger.kernel.org, Daniel Vetter , Sean Paul , Nicholas Kazlauskas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 08, 2020 at 11:06:56AM +0200, Yves-Alexis Perez wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On Thu, 2019-09-05 at 20:53 +0200, Daniel Vetter wrote: > > The -modesetting ddx has a totally broken idea of how atomic works: > > - doesn't disable old connectors, assuming they get auto-disable like > > with the legacy setcrtc > > - assumes ASYNC_FLIP is wired through for the atomic ioctl > > - not a single call to TEST_ONLY > > > > Iow the implementation is a 1:1 translation of legacy ioctls to > > atomic, which is a) broken b) pointless. > > > > We already have bugs in both i915 and amdgpu-DC where this prevents us > > from enabling neat features. > > > > If anyone ever cares about atomic in X we can easily add a new atomic > > level (req->value == 2) for X to get back the shiny toys. > > > > Since these broken versions of -modesetting have been shipping, > > there's really no other way to get out of this bind. > > Hi Daniel and Greg (especially). It seems that this patch was never applied to > stable, maybe it fell through the cracks? What patch is "this patch"? > It doesn't apply as-is in 4.19 branch but a small change in the context makes > it apply. I'm experiencing issues with lightdm and vt-switch in Debian Buster > (which has a 4.19 kernel) so I'd appreciate if the patch was included in at > least that release. What is the git commit id of the patch in Linus's tree? If you have a working backport, that makes it much easier than hoping I can fix it up... thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA774C38A2A for ; Fri, 8 May 2020 10:03:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCDFB215A4 for ; Fri, 8 May 2020 10:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="fZZ1hS1a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="IVz5NEuA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCDFB215A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 267696EACE; Fri, 8 May 2020 10:03:14 +0000 (UTC) X-Greylist: delayed 514 seconds by postgrey-1.36 at gabe; Fri, 08 May 2020 10:03:12 UTC Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 264C86EACC for ; Fri, 8 May 2020 10:03:12 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 44EE05800E1; Fri, 8 May 2020 05:54:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 08 May 2020 05:54:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=fNKb2E3cngycuSCYlu4bdd4ggu3 a874dABTj/kMWUm0=; b=fZZ1hS1aaqVwquRtjcmtV1uwMAChocqg77h2wS5q+6S CTysKclNK/nv1Ft+POR8eY2bzp6wyx1jkI1pa4yKymYwQ3lSeVCpgKskekxOwW3V rYg6ASUEIRO3CZdc+xmfLgwrTD51JKxI5uH23frrKvJlMI5sctciSycR5co756gT O6RCa8jTgEK5lxWREhRAQSSQL0uZ5lS1ncnghdP+ak1Fn+mjn4+4WvUL36MB08U4 AsInFYHnz+r1lMwf9MwqOJE/VSxkw42eaqNgThGWYleWyQBZKEXysu0D+zo4dpk9 O9jsRiF2Fo6dYxpDxvSJkLnW6Zch17Pg1XQQh417vig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=fNKb2E 3cngycuSCYlu4bdd4ggu3a874dABTj/kMWUm0=; b=IVz5NEuAd8YNG9zOll2WGv LVMirSGHhkmKzHsqzIRU4vmwPY06iaA0ZVqkLHvTQQbSKqK+ZuXHLRLcpXm/x7Yc Eyu8tN5q0QQpK4I+Pjbfjx6PBYHceqm3zupvXr3RUF6DJaEMnRPRL2OSzF2bWU1e ghvZprSJtjEiZwczQ9eDWI5xn9nAfhKvHAj7SvYdg09cONqYpQRzqpKuM/nwUf2R UlHaPU7Fx2fp2DtesP6A4dQUUP27/EL7jaoMyJGB5vE8Snss5VdaEkAR4wsn5WzC z9PG2hV24VVGvxLatb9PHfAcKTNzbvECGCT1VyNiwIvi0zlU3JMMxB0PcVcet4EQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkedvgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuheejgf ffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecukfhppeekfedr keeirdekledruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 85EC73280066; Fri, 8 May 2020 05:54:32 -0400 (EDT) Date: Fri, 8 May 2020 11:54:26 +0200 From: Greg KH To: Yves-Alexis Perez Message-ID: <20200508095426.GA3778290@kroah.com> References: <20190903190642.32588-1-daniel.vetter@ffwll.ch> <20190905185318.31363-1-daniel.vetter@ffwll.ch> <2a05f4c4362d386d298a06a67f2f528ef603a734.camel@debian.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2a05f4c4362d386d298a06a67f2f528ef603a734.camel@debian.org> Subject: Re: [Intel-gfx] [PATCH] drm/atomic: Take the atomic toys away from X X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development , Michel =?iso-8859-1?Q?D=E4nzer?= , Adam Jackson , stable@vger.kernel.org, Alex Deucher , Daniel Vetter , Nicholas Kazlauskas , Ilia Mirkin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, May 08, 2020 at 11:06:56AM +0200, Yves-Alexis Perez wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On Thu, 2019-09-05 at 20:53 +0200, Daniel Vetter wrote: > > The -modesetting ddx has a totally broken idea of how atomic works: > > - doesn't disable old connectors, assuming they get auto-disable like > > with the legacy setcrtc > > - assumes ASYNC_FLIP is wired through for the atomic ioctl > > - not a single call to TEST_ONLY > > > > Iow the implementation is a 1:1 translation of legacy ioctls to > > atomic, which is a) broken b) pointless. > > > > We already have bugs in both i915 and amdgpu-DC where this prevents us > > from enabling neat features. > > > > If anyone ever cares about atomic in X we can easily add a new atomic > > level (req->value == 2) for X to get back the shiny toys. > > > > Since these broken versions of -modesetting have been shipping, > > there's really no other way to get out of this bind. > > Hi Daniel and Greg (especially). It seems that this patch was never applied to > stable, maybe it fell through the cracks? What patch is "this patch"? > It doesn't apply as-is in 4.19 branch but a small change in the context makes > it apply. I'm experiencing issues with lightdm and vt-switch in Debian Buster > (which has a 4.19 kernel) so I'd appreciate if the patch was included in at > least that release. What is the git commit id of the patch in Linus's tree? If you have a working backport, that makes it much easier than hoping I can fix it up... thanks, greg k-h _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754ADC38A2A for ; Fri, 8 May 2020 09:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42D0420A8B for ; Fri, 8 May 2020 09:54:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="fZZ1hS1a"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="IVz5NEuA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725825AbgEHJyh (ORCPT ); Fri, 8 May 2020 05:54:37 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:37679 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgEHJyh (ORCPT ); Fri, 8 May 2020 05:54:37 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 44EE05800E1; Fri, 8 May 2020 05:54:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 08 May 2020 05:54:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=fNKb2E3cngycuSCYlu4bdd4ggu3 a874dABTj/kMWUm0=; b=fZZ1hS1aaqVwquRtjcmtV1uwMAChocqg77h2wS5q+6S CTysKclNK/nv1Ft+POR8eY2bzp6wyx1jkI1pa4yKymYwQ3lSeVCpgKskekxOwW3V rYg6ASUEIRO3CZdc+xmfLgwrTD51JKxI5uH23frrKvJlMI5sctciSycR5co756gT O6RCa8jTgEK5lxWREhRAQSSQL0uZ5lS1ncnghdP+ak1Fn+mjn4+4WvUL36MB08U4 AsInFYHnz+r1lMwf9MwqOJE/VSxkw42eaqNgThGWYleWyQBZKEXysu0D+zo4dpk9 O9jsRiF2Fo6dYxpDxvSJkLnW6Zch17Pg1XQQh417vig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=fNKb2E 3cngycuSCYlu4bdd4ggu3a874dABTj/kMWUm0=; b=IVz5NEuAd8YNG9zOll2WGv LVMirSGHhkmKzHsqzIRU4vmwPY06iaA0ZVqkLHvTQQbSKqK+ZuXHLRLcpXm/x7Yc Eyu8tN5q0QQpK4I+Pjbfjx6PBYHceqm3zupvXr3RUF6DJaEMnRPRL2OSzF2bWU1e ghvZprSJtjEiZwczQ9eDWI5xn9nAfhKvHAj7SvYdg09cONqYpQRzqpKuM/nwUf2R UlHaPU7Fx2fp2DtesP6A4dQUUP27/EL7jaoMyJGB5vE8Snss5VdaEkAR4wsn5WzC z9PG2hV24VVGvxLatb9PHfAcKTNzbvECGCT1VyNiwIvi0zlU3JMMxB0PcVcet4EQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkedvgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuheejgf ffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecukfhppeekfedr keeirdekledruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 85EC73280066; Fri, 8 May 2020 05:54:32 -0400 (EDT) Date: Fri, 8 May 2020 11:54:26 +0200 From: Greg KH To: Yves-Alexis Perez Cc: Daniel Vetter , DRI Development , Intel Graphics Development , Ilia Mirkin , Maarten Lankhorst , Nicholas Kazlauskas , Michel =?iso-8859-1?Q?D=E4nzer?= , Alex Deucher , Adam Jackson , Sean Paul , David Airlie , Rob Clark , stable@vger.kernel.org, Daniel Vetter Subject: Re: [PATCH] drm/atomic: Take the atomic toys away from X Message-ID: <20200508095426.GA3778290@kroah.com> References: <20190903190642.32588-1-daniel.vetter@ffwll.ch> <20190905185318.31363-1-daniel.vetter@ffwll.ch> <2a05f4c4362d386d298a06a67f2f528ef603a734.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a05f4c4362d386d298a06a67f2f528ef603a734.camel@debian.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, May 08, 2020 at 11:06:56AM +0200, Yves-Alexis Perez wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On Thu, 2019-09-05 at 20:53 +0200, Daniel Vetter wrote: > > The -modesetting ddx has a totally broken idea of how atomic works: > > - doesn't disable old connectors, assuming they get auto-disable like > > with the legacy setcrtc > > - assumes ASYNC_FLIP is wired through for the atomic ioctl > > - not a single call to TEST_ONLY > > > > Iow the implementation is a 1:1 translation of legacy ioctls to > > atomic, which is a) broken b) pointless. > > > > We already have bugs in both i915 and amdgpu-DC where this prevents us > > from enabling neat features. > > > > If anyone ever cares about atomic in X we can easily add a new atomic > > level (req->value == 2) for X to get back the shiny toys. > > > > Since these broken versions of -modesetting have been shipping, > > there's really no other way to get out of this bind. > > Hi Daniel and Greg (especially). It seems that this patch was never applied to > stable, maybe it fell through the cracks? What patch is "this patch"? > It doesn't apply as-is in 4.19 branch but a small change in the context makes > it apply. I'm experiencing issues with lightdm and vt-switch in Debian Buster > (which has a 4.19 kernel) so I'd appreciate if the patch was included in at > least that release. What is the git commit id of the patch in Linus's tree? If you have a working backport, that makes it much easier than hoping I can fix it up... thanks, greg k-h