From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3EA1C38A2A for ; Fri, 8 May 2020 12:49:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAA8F218AC for ; Fri, 8 May 2020 12:49:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588942175; bh=Hl1LxDpnfMYnR22dTbVNhRHjrc+J+pqClyoq8nfljSU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=W8NUu+8jiIbWzh4tCoKIrb+YxrtnHHr8XzR5Do02IcBaswvAuu0klHMlquxWaBsUQ 5QvPtK9yq6ZCetpW4HppO5HWFi1CUCYp6tNFThvMEvK8NsV7fPvlDxs3fNa3tDoGDq Ku7FJSimcWFQvtPWagj76/aOl1csZzwETFDHmIfY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729315AbgEHMte (ORCPT ); Fri, 8 May 2020 08:49:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:55256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729751AbgEHMtb (ORCPT ); Fri, 8 May 2020 08:49:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 458B521473; Fri, 8 May 2020 12:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588942170; bh=Hl1LxDpnfMYnR22dTbVNhRHjrc+J+pqClyoq8nfljSU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JngP224gWiYOxuEeV/wLTAohkOqUzyELVnUKnPsLAaewvGbxFT/Y4B3pzKVow+Rg6 UrlJ21MfVV6JynVD8Gq0BdPSruPgBLCQpZlFktIoJLMApICg5yQNfHWB7FHigQ++Wp hXwMgVhVXkD86xnhSCWdkk66ytiJ/YP7qlQDIv50= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Doug Berger , Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 13/18] net: systemport: suppress warnings on failed Rx SKB allocations Date: Fri, 8 May 2020 14:35:16 +0200 Message-Id: <20200508123033.662294858@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200508123030.497793118@linuxfoundation.org> References: <20200508123030.497793118@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Doug Berger [ Upstream commit 3554e54a46125030c534820c297ed7f6c3907e24 ] The driver is designed to drop Rx packets and reclaim the buffers when an allocation fails, and the network interface needs to safely handle this packet loss. Therefore, an allocation failure of Rx SKBs is relatively benign. However, the output of the warning message occurs with a high scheduling priority that can cause excessive jitter/latency for other high priority processing. This commit suppresses the warning messages to prevent scheduling problems while retaining the failure count in the statistics of the network interface. Signed-off-by: Doug Berger Acked-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bcmsysport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -504,7 +504,8 @@ static struct sk_buff *bcm_sysport_rx_re dma_addr_t mapping; /* Allocate a new SKB for a new packet */ - skb = netdev_alloc_skb(priv->netdev, RX_BUF_LENGTH); + skb = __netdev_alloc_skb(priv->netdev, RX_BUF_LENGTH, + GFP_ATOMIC | __GFP_NOWARN); if (!skb) { priv->mib.alloc_rx_buff_failed++; netif_err(priv, rx_err, ndev, "SKB alloc failed\n");