From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F70C38A2A for ; Fri, 8 May 2020 13:13:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E08024999 for ; Fri, 8 May 2020 13:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729620AbgEHMsB (ORCPT ); Fri, 8 May 2020 08:48:01 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2167 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729607AbgEHMr6 (ORCPT ); Fri, 8 May 2020 08:47:58 -0400 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 708D1EDF60E665A57672; Fri, 8 May 2020 13:47:56 +0100 (IST) Received: from localhost (10.47.95.97) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 8 May 2020 13:47:55 +0100 Date: Fri, 8 May 2020 13:47:33 +0100 From: Jonathan Cameron To: Jonathan Bakker CC: Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Rob Herring , linux-iio , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Dmitry Torokhov , Kate Stewart , Greg KH , Thomas Gleixner , Linux Input Subject: Re: [PATCH 0/5] iio: accel: Add bma023 support to bma180 Message-ID: <20200508134733.0000233a@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.95.97] X-ClientProxiedBy: lhreml743-chm.china.huawei.com (10.201.108.193) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, 6 May 2020 20:49:17 -0700 Jonathan Bakker wrote: > Hi Linus, > > On 2020-05-06 5:47 a.m., Linus Walleij wrote: > > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker wrote: > > > >> This patchset adds support for the bma023 three axis accelerometer > >> to the bma180 IIO driver. The bma023 is found on several ~2010 > >> phones, including the first-gen Galaxy S series. > >> > >> The bma023 differs from later chips (bma180, bma25x) in that it > >> has no low power but still working mode and no temperature > >> channel. > >> > >> The bma023 is already supported by a misc input driver (bma150), so > >> when both are enabled, the iio driver is preferred. The bma150 > >> is very similar to the bma023, but has a temperature channel. > >> Support for the bma150 is not added in this patchset. > > > > I'd say, if it's not too much trouble please also patch in > > support for BMA150 and SMB380 to the IIO driver so > > we can delete this old Input driver, we have done this > > before and thes "input drivers" are just causing headaches > > and wasting time for the Input maintainer. > > > > Looking at the bma150, it looks the same. The temperature is implemented > slightly differently than on the bma180+ (unsigned vs signed) but should > be quite easy to add. I'll add a new patch for it in v2. Great. Series looks fine to me as well, so should be fine to apply v2. (subject to Dmitry Ack). Jonathan > > > It can be in a separate patch set from this one if you > > don't want to get stuck on this. > > > > Yours, > > Linus Walleij > > > > Thanks, > Jonathan