From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Damien LeMoal <damien.lemoal@wdc.com>,
Bob Liu <bob.liu@oracle.com>,
dm-devel@redhat.com
Subject: Re: [PATCH 01/14] dm-zoned: add 'status' and 'message' callbacks
Date: Fri, 8 May 2020 17:00:29 -0400 [thread overview]
Message-ID: <20200508210029.GA19773@redhat.com> (raw)
In-Reply-To: <9dee23c7-76ed-d80b-bfe2-9d2930488316@suse.de>
On Fri, May 08 2020 at 2:25pm -0400,
Hannes Reinecke <hare@suse.de> wrote:
> On 5/8/20 6:29 PM, Mike Snitzer wrote:
> >On Fri, May 08 2020 at 5:03am -0400,
> >Hannes Reinecke <hare@suse.de> wrote:
> >
> >>Add callbacks to supply information for 'dmsetup status'
> >>and 'dmsetup info', and implement the message 'reclaim'
> >>to start the reclaim worker.
> >
> >Same feedback from before:
> >https://www.redhat.com/archives/dm-devel/2020-March/msg00189.html
> >
> >Who/What will use the 'reclaim' message? Shouldn't it be documented?
> >Think the dmz_status changes should be split out from this reclaim
> >message?
> >
> 'reclaim' means that dm-zoned should start moving zones from the
> random zones to the sequential zones to free up more random zones.
> There's a threshold after which it'll start automatically, but this
> allows you to start reclaim even if the threshold isn't reached.
> You might be right, it should be documented.
> (Where? In the code?)
Documentation/admin-guide/device-mapper/dm-zoned.rst
Anything else worthy of sharing with others about v2 metadata format
would also be wise to document as part of those changes,
> As for splitting things off; yeah, I could; maybe I should if the
> 'reclaim' message turns out to be controversial...
Not controversial per se, but its disjoint from the rest of this series.
So best to split it out I think.
Thanks,
Mike
next prev parent reply other threads:[~2020-05-08 21:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 9:03 [PATCHv5 00/14] dm-zoned: metadata version 2 Hannes Reinecke
2020-05-08 9:03 ` [PATCH 01/14] dm-zoned: add 'status' and 'message' callbacks Hannes Reinecke
2020-05-08 16:29 ` Mike Snitzer
2020-05-08 18:25 ` Hannes Reinecke
2020-05-08 21:00 ` Mike Snitzer [this message]
2020-05-08 9:03 ` [PATCH 02/14] dm-zoned: store zone id within the zone structure and kill dmz_id() Hannes Reinecke
2020-05-08 9:03 ` [PATCH 03/14] dm-zoned: use array for superblock zones Hannes Reinecke
2020-05-08 9:03 ` [PATCH 04/14] dm-zoned: store device in struct dmz_sb Hannes Reinecke
2020-05-08 9:03 ` [PATCH 05/14] dm-zoned: move fields from struct dmz_dev to dmz_metadata Hannes Reinecke
2020-05-08 9:03 ` [PATCH 06/14] dm-zoned: introduce dmz_metadata_label() to format device name Hannes Reinecke
2020-05-08 9:03 ` [PATCH 07/14] dm-zoned: Introduce dmz_dev_is_dying() and dmz_check_dev() Hannes Reinecke
2020-05-08 9:03 ` [PATCH 08/14] dm-zoned: remove 'dev' argument from reclaim Hannes Reinecke
2020-05-08 9:03 ` [PATCH 09/14] dm-zoned: replace 'target' pointer in the bio context Hannes Reinecke
2020-05-08 9:03 ` [PATCH 10/14] dm-zoned: use dmz_zone_to_dev() when handling metadata I/O Hannes Reinecke
2020-05-08 9:03 ` [PATCH 11/14] dm-zoned: add metadata logging functions Hannes Reinecke
2020-05-08 9:03 ` [PATCH 12/14] dm-zoned: Reduce logging output on startup Hannes Reinecke
2020-05-11 2:48 ` Damien Le Moal
2020-05-08 9:03 ` [PATCH 13/14] dm-zoned: ignore metadata zone in dmz_alloc_zone() Hannes Reinecke
2020-05-08 9:03 ` [PATCH 14/14] dm-zoned: metadata version 2 Hannes Reinecke
2020-05-08 16:38 ` Mike Snitzer
2020-05-11 3:00 ` Damien Le Moal
2020-05-11 2:46 ` [PATCHv5 00/14] " Damien Le Moal
2020-05-11 6:31 ` Hannes Reinecke
2020-05-11 6:41 ` Damien Le Moal
2020-05-11 6:55 ` Damien Le Moal
2020-05-12 16:49 ` Mike Snitzer
2020-05-11 10:55 ` Damien Le Moal
2020-05-11 11:19 ` Hannes Reinecke
2020-05-11 11:25 ` Damien Le Moal
2020-05-11 11:24 ` Hannes Reinecke
2020-05-11 11:46 ` Damien Le Moal
2020-05-11 13:23 ` Damien Le Moal
2020-05-13 23:56 ` Damien Le Moal
2020-05-14 0:20 ` Martin K. Petersen
2020-05-14 0:55 ` Damien Le Moal
2020-05-14 2:19 ` Martin K. Petersen
2020-05-14 2:22 ` Damien Le Moal
2020-05-14 5:56 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508210029.GA19773@redhat.com \
--to=snitzer@redhat.com \
--cc=bob.liu@oracle.com \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.