From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] efi: Replace zero-length array with flexible-array
Date: Fri, 8 May 2020 18:41:42 -0500 [thread overview]
Message-ID: <20200508234142.GA27139@embeddedor> (raw)
In-Reply-To: <CAHk-=wh-Ym=onfkMyMmOZUr6cFGQUD8kMowX6OcE-A-H2efkMg@mail.gmail.com>
On Fri, May 08, 2020 at 10:26:40AM -0700, Linus Torvalds wrote:
> On Thu, May 7, 2020 at 12:22 PM Gustavo A. R. Silva
> <gustavoars@kernel.org> wrote:
> >
> > The current codebase makes use of the zero-length array language
> > extension to the C90 standard, but the preferred mechanism to declare
> > variable-length types such as these ones is a flexible array member[1][2],
> > introduced in C99 [...]
>
> Why is this called an "efi" patch, when it doesn't appear to be so at all:
>
> > include/linux/dma/ti-cppi5.h | 4 ++--
> > include/linux/efi.h | 2 +-
> > include/linux/mailbox/zynqmp-ipi-message.h | 2 +-
> > include/linux/platform_data/cros_ec_commands.h | 4 ++--
> > include/linux/platform_data/cros_ec_proto.h | 2 +-
> > kernel/params.c | 2 +-
> > kernel/tracepoint.c | 2 +-
> > scripts/kallsyms.c | 2 +-
> > 8 files changed, 10 insertions(+), 10 deletions(-)
>
> Yes, one line of the patch is EFI code. The rest are not.
>
Yeah. It seems the script needs some improvement. I'll split this
patch up into multiple patches.
Thanks
--
Gustavo
prev parent reply other threads:[~2020-05-08 23:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 19:27 [PATCH] efi: Replace zero-length array with flexible-array Gustavo A. R. Silva
2020-05-08 17:26 ` Linus Torvalds
2020-05-08 23:41 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508234142.GA27139@embeddedor \
--to=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.