From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7834C28CBC for ; Sat, 9 May 2020 08:17:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D7BE2495A for ; Sat, 9 May 2020 08:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbgEIIRS (ORCPT ); Sat, 9 May 2020 04:17:18 -0400 Received: from verein.lst.de ([213.95.11.211]:56071 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbgEIIRS (ORCPT ); Sat, 9 May 2020 04:17:18 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 10A1168C7B; Sat, 9 May 2020 10:17:16 +0200 (CEST) Date: Sat, 9 May 2020 10:17:15 +0200 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 08/12] xfs: remove xfs_ifork_ops Message-ID: <20200509081715.GA21748@lst.de> References: <20200508063423.482370-1-hch@lst.de> <20200508063423.482370-9-hch@lst.de> <20200508150543.GF27577@bfoster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508150543.GF27577@bfoster> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, May 08, 2020 at 11:05:43AM -0400, Brian Foster wrote: > On Fri, May 08, 2020 at 08:34:19AM +0200, Christoph Hellwig wrote: > > xfs_ifork_ops add up to two indirect calls per inode read and flush, > > despite just having a single instance in the kernel. In xfsprogs > > phase6 in xfs_repair overrides the verify_dir method to deal with inodes > > that do not have a valid parent, but that can be fixed pretty easily > > by ensuring they always have a valid looking parent. > > > > Signed-off-by: Christoph Hellwig > > --- > > Code looks fine, but I assume we'll want a repair fix completed and > merged before wiping this out: With the xfsprogs merge delays I'm not sure merged will work, but I'll happily take your patch and get it in shape for submission.