All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com,
	mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz
Subject: Re: ofono for d4: less hcked and more working version was Re: USB networking news, ofono for d4: less hacked version
Date: Sat, 9 May 2020 06:57:42 -0700	[thread overview]
Message-ID: <20200509135742.GA37466@atomide.com> (raw)
In-Reply-To: <20200508100211.GA19646@amd>

* Pavel Machek <pavel@ucw.cz> [200508 10:03]:
> Hi!
> 
> > > But I might be confused. I recall some audio patches were needed for
> > > basic phone calls (setting up mixers to connect gsm<->audio), but
> > > those worked before gsmux support was enabled. (Maybe some hardcoded
> > > commands were needed to be sent to gsmmux somewhere).
> > 
> > We're currently reconfiguring the TDM transport that based on the
> > unsolicited messages on dlci1. I still need to figure out how to add
> > that back while keeping the serdev-ngsm driver generic.
> 
> Is it really neccessary? I believe I was simply configuring codecs for
> voice call and left them like that.

Yes something needs to call set_tdm_slot() for voice calls. AFAIK we have
only the dlci1 messages indicating a voice call is happening.

So I got that added directly into the snd-soc-motmdm driver where it now
listens to notifications on dlci1 while we still have /dev/gsmtty1 for
userspace. Looks like I still need to fix the mixer controls before I can
test voice calls again though.. Will post the patches as soon as I get
that done.

I'm not yet sure what's the preferred way to do notifications with ALSA,
but based on the earlier comments the piece of code calling set_tdm_slot()
should not be the codec driver. Instead, it should be called by either
snd-soc-audio-graph-card or a custom card driver for the device.

> I pushed new version of ofono: I'm still not sure about those incoming
> sms (but _some_ sms are received). Rest should be better.

OK

Regards,

Tony

  reply	other threads:[~2020-05-09 13:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 10:11 USB networking news, ofono for d4: less hacked version Pavel Machek
2020-05-06 14:43 ` Tony Lindgren
2020-05-06 23:05   ` Pavel Machek
2020-05-07 14:07     ` Tony Lindgren
2020-05-08 10:02       ` ofono for d4: less hcked and more working version was " Pavel Machek
2020-05-09 13:57         ` Tony Lindgren [this message]
2020-05-09 14:31         ` Tony Lindgren
2020-05-09 19:36           ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200509135742.GA37466@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=martin_rysavy@centrum.cz \
    --cc=merlijn@wizzup.org \
    --cc=mpartap@gmx.net \
    --cc=nekit1000@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.