From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 1/4] net: phy: broadcom: add exp register access methods without buslock
Date: Sun, 10 May 2020 16:32:56 +0200 [thread overview]
Message-ID: <20200510143256.GG362499@lunn.ch> (raw)
In-Reply-To: <20200509223714.30855-2-michael@walle.cc>
On Sun, May 10, 2020 at 12:37:11AM +0200, Michael Walle wrote:
> Add helper to read and write expansion registers without taking the mdio
> lock.
>
> Please note, that this changes the semantics of the read and write.
> Before there was no lock between selecting the expansion register and
> the actual read/write. This may lead to access failures if there are
> parallel accesses. Instead take the bus lock during the whole access
> cycle.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-05-10 14:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 22:37 [PATCH net-next 0/4] net: phy: broadcom: cable tester support Michael Walle
2020-05-09 22:37 ` [PATCH net-next 1/4] net: phy: broadcom: add exp register access methods without buslock Michael Walle
2020-05-09 23:47 ` Florian Fainelli
2020-05-10 14:32 ` Andrew Lunn [this message]
2020-05-09 22:37 ` [PATCH net-next 2/4] net: phy: broadcom: add bcm_phy_modify_exp() Michael Walle
2020-05-09 23:48 ` Florian Fainelli
2020-05-10 14:33 ` Andrew Lunn
2020-05-09 22:37 ` [PATCH net-next 3/4] net: phy: broadcom: add cable test support Michael Walle
2020-05-10 0:09 ` Florian Fainelli
2020-05-10 2:20 ` kbuild test robot
2020-05-10 2:20 ` kbuild test robot
2020-05-10 14:44 ` Andrew Lunn
2020-05-10 14:51 ` Michael Walle
2020-05-09 22:37 ` [PATCH net-next 4/4] net: phy: bcm54140: add cable diagnostics support Michael Walle
2020-05-10 0:05 ` kbuild test robot
2020-05-10 0:05 ` kbuild test robot
2020-05-10 0:09 ` Florian Fainelli
2020-05-10 5:37 ` kbuild test robot
2020-05-10 5:37 ` kbuild test robot
2020-05-10 14:44 ` Andrew Lunn
2020-05-10 18:21 ` [PATCH net-next 0/4] net: phy: broadcom: cable tester support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510143256.GG362499@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.