From: Segher Boessenkool <segher@kernel.crashing.org>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: linuxppc-dev@ozlabs.org, Michael Neuling <mikey@neuling.org>,
Benjamin Herrenschmidt <benh@ozlabs.org>
Subject: Re: [PATCH RFC 3/4] powerpc/microwatt: Add early debug UART support for Microwatt
Date: Mon, 11 May 2020 02:07:21 -0500 [thread overview]
Message-ID: <20200511070721.GQ31009@gate.crashing.org> (raw)
In-Reply-To: <20200509050340.GD1464954@thinks.paulus.ozlabs.org>
Hi!
On Sat, May 09, 2020 at 03:03:40PM +1000, Paul Mackerras wrote:
> + __asm__ volatile("mtmsrd %3,0; ldcix %0,%1,%2; mtmsrd %4,0"
> + : "=r" (val) : "b" (potato_uart_base), "r" (offset),
> + "r" (msr & ~MSR_DR), "r" (msr));
That should be "=&r"(val) (an earlyclobber), because when %0 is
written, %4 will still be used later.
Looks fine otherwise.
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
Segher
next prev parent reply other threads:[~2020-05-11 7:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 5:01 [PATCH RFC 0/4] Add support for Microwatt-based SoCs Paul Mackerras
2020-05-09 5:02 ` [PATCH RFC 1/4] powerpc/radix: Fix compilation for radix with CONFIG_SMP=n Paul Mackerras
2020-05-09 7:52 ` Nicholas Piggin
2020-05-14 8:26 ` Joel Stanley
2020-05-09 5:02 ` [PATCH RFC 2/4] powerpc: Add Microwatt platform Paul Mackerras
2020-05-09 7:58 ` Nicholas Piggin
2020-05-09 8:36 ` Alistair Popple
2020-05-09 9:10 ` Nicholas Piggin
2020-05-12 1:56 ` Michael Ellerman
2020-05-09 5:03 ` [PATCH RFC 3/4] powerpc/microwatt: Add early debug UART support for Microwatt Paul Mackerras
2020-05-11 7:07 ` Segher Boessenkool [this message]
2020-05-12 1:57 ` Michael Ellerman
2020-05-09 5:04 ` [PATCH RFC 4/4] powerpc/radix: Add support for microwatt's PRTBL SPR Paul Mackerras
2020-05-09 8:02 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511070721.GQ31009@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.