From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E94C54E4B for ; Mon, 11 May 2020 11:57:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11ABB2075E for ; Mon, 11 May 2020 11:57:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TYCFULo2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729591AbgEKL53 (ORCPT ); Mon, 11 May 2020 07:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729490AbgEKL52 (ORCPT ); Mon, 11 May 2020 07:57:28 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48730C05BD0B for ; Mon, 11 May 2020 04:57:28 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id h4so17749697wmb.4 for ; Mon, 11 May 2020 04:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ETEJzrILDWcEXSuqI8CJBLVfITRJvsWlV8DeIS56yUg=; b=TYCFULo2Suie8IQQbYjij0fXBQIVOUeI8xv90SKGhM5ONz2C0tOD+JZgJvXZWV8rj1 hVyNLva1zf1dfngbRmXj5nWT2LYLmXJYm7Vc5N0WBGJoZUG4D4sPk5K0DqdkpXUKs68N yNDAJiHCn8A02TXqcQ9lyTuTFNdWzUQNC3me3u/1RYQdyg8ABZSWn/yXuzOWlOc3IBmW kL+9ZFtfe+DRrR5ZQYEZqeLUyuRzdG+R/pYtfjhI/9bYEanyw2jau41e8wJJxf9efG+h 7MEwuIBDRDzZqwEk16N8f4DzETeYRYp8/8fZ1m1afV8wanrkOItDXwjd39jiUMqFuWRK U3+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ETEJzrILDWcEXSuqI8CJBLVfITRJvsWlV8DeIS56yUg=; b=ZqDI8h0C74gUinrQY7xD+wJ0xfYU2QWLQr+f7/lMhaPoaahANlegOq4CqoL9w0REiU ERnU0AHLkH5cp1ouZ0Vwh9HGs7WBywcG/ptX3ue4wcari8aGIJetEPeJPsotRWe0ns2D onKwtV6VmRysqdX1euZfINyhItpSlGrYNM0SZ+Qo5SqUt286G0Wmf+yoJojZwNsXuM2c 8CTy3bO3VZNWMLLwZeCCQWYtt1tIWb5VjzR2pBPclbvBiGI84oUeihN3X2RYuvE0wofh OFeHaLX7vqXfdlsjf+v2KoZQBo0P1s3OL2YIOQfuPloGCjEdqz1NYghiePdnCLTFiwle wXJQ== X-Gm-Message-State: AGi0PubTnBVZmZzHL0TQ6hY/p2MJw3KDpopslglcXg1a/lqp8B4lSJDy S4pOUWrbA9GqoIkHTg4cKLXtiQ== X-Google-Smtp-Source: APiQypIA/BhPOSlxxVRft/M3ndyAAD/wbrIqEL1T+jhl+AK/cIZYzzYwO39nyIGbtRrwMvdTRb8hHw== X-Received: by 2002:a7b:c755:: with SMTP id w21mr30469520wmk.120.1589198246663; Mon, 11 May 2020 04:57:26 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id y70sm27811096wmc.36.2020.05.11.04.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 04:57:25 -0700 (PDT) Date: Mon, 11 May 2020 12:57:22 +0100 From: Quentin Perret To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Dietmar.Eggemann@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net, orjan.eide@arm.com, rdunlap@infradead.org, mka@chromium.org Subject: Re: [PATCH v7 03/15] PM / EM: update callback structure and add device pointer Message-ID: <20200511115722.GA13741@google.com> References: <20200511111912.3001-1-lukasz.luba@arm.com> <20200511111912.3001-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200511111912.3001-4-lukasz.luba@arm.com> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Monday 11 May 2020 at 12:19:00 (+0100), Lukasz Luba wrote: > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index 61623e2ff149..11ee24e06d12 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -103,17 +103,12 @@ scmi_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask) > } > > static int __maybe_unused > -scmi_get_cpu_power(unsigned long *power, unsigned long *KHz, int cpu) > +scmi_get_cpu_power(unsigned long *power, unsigned long *KHz, > + struct device *cpu_dev) > { > - struct device *cpu_dev = get_cpu_device(cpu); > unsigned long Hz; > int ret, domain; > > - if (!cpu_dev) { > - pr_err("failed to get cpu%d device\n", cpu); > - return -ENODEV; > - } > - > domain = handle->perf_ops->device_domain_id(cpu_dev); > if (domain < 0) > return domain; > @@ -200,7 +195,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) > > policy->fast_switch_possible = true; > > - em_register_perf_domain(policy->cpus, nr_opp, &em_cb); So this one has no users after this patch right? I suppose you could squash patch 05 in this one. But no big deal. Acked-by: Quentin Perret > + em_dev_register_perf_domain(cpu_dev, nr_opp, &em_cb, policy->cpus); > > return 0; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E057DC47255 for ; Mon, 11 May 2020 11:57:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B32752075E for ; Mon, 11 May 2020 11:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DMmwS+mA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="TYCFULo2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B32752075E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4CRBDkQ2VmnIJr+/ljm0ORYp0io9SPzMiL1kbReIdFg=; b=DMmwS+mAuU4dIQ GoCYOlsUjOGxln+Kw8YTxNPyVv3b17ueuXck/e83lqBCdfCEKWUFvdmEnWZot2WcHBPGHzJVztdO3 wdsNevGJhAFrY4FA2C11tql2DySuguXlnG/iDFsdCRiADE+ZMeWtgUuWsUlsNFX6dBfNi202E0GtJ 4WN5MgtOTkgtkN7rIW/L+HkieiDZeeNctZ8ScMVfKncWIvo9Y+ZNaw4lLuQOFzExbx4YsjhdLtZ5X LfhgNHJ7l/iHdDEiiA3ReOrveqGFW+gRS7ETbUq6H9K4j9dLyaJ5utTiZQ7g3gUf9qMjXqYE6ePfI oUbPzxMaP3SiULWAW+pg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY73x-00070j-9C; Mon, 11 May 2020 11:57:37 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY73o-0006om-Kv for linux-mediatek@lists.infradead.org; Mon, 11 May 2020 11:57:29 +0000 Received: by mail-wm1-x341.google.com with SMTP id e26so17749105wmk.5 for ; Mon, 11 May 2020 04:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ETEJzrILDWcEXSuqI8CJBLVfITRJvsWlV8DeIS56yUg=; b=TYCFULo2Suie8IQQbYjij0fXBQIVOUeI8xv90SKGhM5ONz2C0tOD+JZgJvXZWV8rj1 hVyNLva1zf1dfngbRmXj5nWT2LYLmXJYm7Vc5N0WBGJoZUG4D4sPk5K0DqdkpXUKs68N yNDAJiHCn8A02TXqcQ9lyTuTFNdWzUQNC3me3u/1RYQdyg8ABZSWn/yXuzOWlOc3IBmW kL+9ZFtfe+DRrR5ZQYEZqeLUyuRzdG+R/pYtfjhI/9bYEanyw2jau41e8wJJxf9efG+h 7MEwuIBDRDzZqwEk16N8f4DzETeYRYp8/8fZ1m1afV8wanrkOItDXwjd39jiUMqFuWRK U3+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ETEJzrILDWcEXSuqI8CJBLVfITRJvsWlV8DeIS56yUg=; b=hiX38ewlSvwK+HHl+5snzIVAAPDejLiyOcQukGVbe1rtHgOvfeYvEZh2CTkhJKHvD5 kcVCb2jL7lMl8CHOMkbqOK3LVtMdk3/WAX1V/qzAIeX1Awl0Yv7pxw7ILHRu00B5LOcZ Sw8B7j9h+dwIijWYO2VVBWzNyXEmekBZwaNofeTX31HClp5hPY9fjIvWkSryX8Kz9V+G VlI5qVTGZleYqk28PzGvkYEh3oZF2gX+kfhkdG5ztqC5Wll1KkjYIlok9g4Xq1lwSuDi gHYyVwFyE9k7uSBj1dOgvL6eTqIhWrqUJdCc5BMxZms5/aHczr3ilER4A8GycytjUznv Cv+A== X-Gm-Message-State: AGi0PuYiF/kKmPx80oXe7WpWeRgio8shV2V/1BZocTyjJPhZTP/zouuV 5sU7mNt5v+6D9AGA9qjuvSKXYg== X-Google-Smtp-Source: APiQypIA/BhPOSlxxVRft/M3ndyAAD/wbrIqEL1T+jhl+AK/cIZYzzYwO39nyIGbtRrwMvdTRb8hHw== X-Received: by 2002:a7b:c755:: with SMTP id w21mr30469520wmk.120.1589198246663; Mon, 11 May 2020 04:57:26 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id y70sm27811096wmc.36.2020.05.11.04.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 04:57:25 -0700 (PDT) Date: Mon, 11 May 2020 12:57:22 +0100 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v7 03/15] PM / EM: update callback structure and add device pointer Message-ID: <20200511115722.GA13741@google.com> References: <20200511111912.3001-1-lukasz.luba@arm.com> <20200511111912.3001-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511111912.3001-4-lukasz.luba@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_045728_713148_E97C4CBB X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, mka@chromium.org, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Monday 11 May 2020 at 12:19:00 (+0100), Lukasz Luba wrote: > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index 61623e2ff149..11ee24e06d12 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -103,17 +103,12 @@ scmi_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask) > } > > static int __maybe_unused > -scmi_get_cpu_power(unsigned long *power, unsigned long *KHz, int cpu) > +scmi_get_cpu_power(unsigned long *power, unsigned long *KHz, > + struct device *cpu_dev) > { > - struct device *cpu_dev = get_cpu_device(cpu); > unsigned long Hz; > int ret, domain; > > - if (!cpu_dev) { > - pr_err("failed to get cpu%d device\n", cpu); > - return -ENODEV; > - } > - > domain = handle->perf_ops->device_domain_id(cpu_dev); > if (domain < 0) > return domain; > @@ -200,7 +195,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) > > policy->fast_switch_possible = true; > > - em_register_perf_domain(policy->cpus, nr_opp, &em_cb); So this one has no users after this patch right? I suppose you could squash patch 05 in this one. But no big deal. Acked-by: Quentin Perret > + em_dev_register_perf_domain(cpu_dev, nr_opp, &em_cb, policy->cpus); > > return 0; _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C011BC54E4B for ; Mon, 11 May 2020 11:57:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83DBB2075E for ; Mon, 11 May 2020 11:57:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jCCQRko6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="TYCFULo2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83DBB2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+PZXaGe/4Bl2D9RkgdO0L78JsbD3BVCZ5IB6T547E9M=; b=jCCQRko6e/R77a VGDYyh15cI9PWpCD46v7ZIYQdra88PRSrdrdLF1v6UicFAnzFXZ0KnneZTfk1OlxjfPFhhqJFECVs knYrt+oUgdgxPOz8Vhz0xETgHwNd3iW8gMMy22DZJTR3Y+ZubZqtHmDjvEyk721GfFmwtAYJUiFD4 yLtUTcYK7ZVt0xe5F2hsySIJXLQYSapCkwx7mtDaIehVOna69WWxhjHii1wgEj0GJBlF2647itCox 5zOgdGXeUHSm67U+ury12yMzkJBH3QEUiUI3/B/g6QjRdEutTHNdkCQeIuYSG83ZJus7GplJZMZkb ctBSM0E3vwjfEgq4w1bw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY73r-0006ra-Rm; Mon, 11 May 2020 11:57:31 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY73o-0006on-Kt for linux-arm-kernel@lists.infradead.org; Mon, 11 May 2020 11:57:30 +0000 Received: by mail-wm1-x341.google.com with SMTP id y24so18920730wma.4 for ; Mon, 11 May 2020 04:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ETEJzrILDWcEXSuqI8CJBLVfITRJvsWlV8DeIS56yUg=; b=TYCFULo2Suie8IQQbYjij0fXBQIVOUeI8xv90SKGhM5ONz2C0tOD+JZgJvXZWV8rj1 hVyNLva1zf1dfngbRmXj5nWT2LYLmXJYm7Vc5N0WBGJoZUG4D4sPk5K0DqdkpXUKs68N yNDAJiHCn8A02TXqcQ9lyTuTFNdWzUQNC3me3u/1RYQdyg8ABZSWn/yXuzOWlOc3IBmW kL+9ZFtfe+DRrR5ZQYEZqeLUyuRzdG+R/pYtfjhI/9bYEanyw2jau41e8wJJxf9efG+h 7MEwuIBDRDzZqwEk16N8f4DzETeYRYp8/8fZ1m1afV8wanrkOItDXwjd39jiUMqFuWRK U3+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ETEJzrILDWcEXSuqI8CJBLVfITRJvsWlV8DeIS56yUg=; b=jlKx9B3DzqqOFP4JYfQR/OfBpVqUcDJt/p9KSj9Ks2YPG51z+LAwjy/qKPn4LIiK3v bSWwmzkmaZM6kumnpvgwvIvubU24VD7pmPgQneIAx/2eydPgLwL/KSx4mlVahl8qC5IQ wvDG3etnaLuKwJUf7jskMraMJFiQzP1p1oOD/99va0kLza5+GPDJLDywlExGrOSkShT+ gEvk6nJydEy+J8Qa7Mw+CCdx8xR7QZ0FthnmZv/Ch2xOpVBGZbPawQ4geLWvOtQ1JT6i lqCxBM4VWHwtPLxCMZ5AgVAUCjIABI//MbDKP8JUcMidGsqvEviG7FJcaxb2QhCs5AdE qHTg== X-Gm-Message-State: AGi0Puas2hMCDNjWnSk256vBUBJi7vwpMbLL/j/44sPjfp4YzMh+wqVL AdlI19jtPYNzMsoeBWxziD6tTg== X-Google-Smtp-Source: APiQypIA/BhPOSlxxVRft/M3ndyAAD/wbrIqEL1T+jhl+AK/cIZYzzYwO39nyIGbtRrwMvdTRb8hHw== X-Received: by 2002:a7b:c755:: with SMTP id w21mr30469520wmk.120.1589198246663; Mon, 11 May 2020 04:57:26 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id y70sm27811096wmc.36.2020.05.11.04.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 04:57:25 -0700 (PDT) Date: Mon, 11 May 2020 12:57:22 +0100 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v7 03/15] PM / EM: update callback structure and add device pointer Message-ID: <20200511115722.GA13741@google.com> References: <20200511111912.3001-1-lukasz.luba@arm.com> <20200511111912.3001-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511111912.3001-4-lukasz.luba@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_045728_713033_6FA8D967 X-CRM114-Status: GOOD ( 11.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, mka@chromium.org, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 11 May 2020 at 12:19:00 (+0100), Lukasz Luba wrote: > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index 61623e2ff149..11ee24e06d12 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -103,17 +103,12 @@ scmi_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask) > } > > static int __maybe_unused > -scmi_get_cpu_power(unsigned long *power, unsigned long *KHz, int cpu) > +scmi_get_cpu_power(unsigned long *power, unsigned long *KHz, > + struct device *cpu_dev) > { > - struct device *cpu_dev = get_cpu_device(cpu); > unsigned long Hz; > int ret, domain; > > - if (!cpu_dev) { > - pr_err("failed to get cpu%d device\n", cpu); > - return -ENODEV; > - } > - > domain = handle->perf_ops->device_domain_id(cpu_dev); > if (domain < 0) > return domain; > @@ -200,7 +195,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) > > policy->fast_switch_possible = true; > > - em_register_perf_domain(policy->cpus, nr_opp, &em_cb); So this one has no users after this patch right? I suppose you could squash patch 05 in this one. But no big deal. Acked-by: Quentin Perret > + em_dev_register_perf_domain(cpu_dev, nr_opp, &em_cb, policy->cpus); > > return 0; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEFA8C54E4B for ; Tue, 12 May 2020 07:09:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E30920733 for ; Tue, 12 May 2020 07:09:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="TYCFULo2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E30920733 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF9696E843; Tue, 12 May 2020 07:09:32 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C0B06E07B for ; Mon, 11 May 2020 11:57:28 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id m12so12847640wmc.0 for ; Mon, 11 May 2020 04:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ETEJzrILDWcEXSuqI8CJBLVfITRJvsWlV8DeIS56yUg=; b=TYCFULo2Suie8IQQbYjij0fXBQIVOUeI8xv90SKGhM5ONz2C0tOD+JZgJvXZWV8rj1 hVyNLva1zf1dfngbRmXj5nWT2LYLmXJYm7Vc5N0WBGJoZUG4D4sPk5K0DqdkpXUKs68N yNDAJiHCn8A02TXqcQ9lyTuTFNdWzUQNC3me3u/1RYQdyg8ABZSWn/yXuzOWlOc3IBmW kL+9ZFtfe+DRrR5ZQYEZqeLUyuRzdG+R/pYtfjhI/9bYEanyw2jau41e8wJJxf9efG+h 7MEwuIBDRDzZqwEk16N8f4DzETeYRYp8/8fZ1m1afV8wanrkOItDXwjd39jiUMqFuWRK U3+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ETEJzrILDWcEXSuqI8CJBLVfITRJvsWlV8DeIS56yUg=; b=uQQ0c4FDk+rANmjunyTyB+ot+UKXfKzsRhMM+xI3C2jnhDXdWODs3ox/SVPCpAVAbn U2oda0UI3nDYtdumWqVpu0XL/kfCDDGWfqnCNd0ypNBJmaS5pzd+9PDdYLJb9Aaa7+l7 SYlCGbX1IPNICX60pjoTy0erWyspT0GLfp4a8pU0iIUISvfaY3LDVvwSsJCoAfVQbQTs llXqy6qUJv6Qx5X6FQVbZ6W0+qXvePNDK1auF3AfpavGdPIVdIVoRGw0KdxWMUFlRNBb hJEH86GiOOLusEPfVWoXp3hJTe4yTbgiTkAZZyjmeqwvC3tsJ7Tm5A0T4LzfTeYzVXw8 y5FA== X-Gm-Message-State: AGi0PuYvPwZj0nKpMXl780H6brXzkjfJ7ve9GM34BBFJE7umyYBnNh9h Zgi5EJBgqdcv987IC1VaPdHjsg== X-Google-Smtp-Source: APiQypIA/BhPOSlxxVRft/M3ndyAAD/wbrIqEL1T+jhl+AK/cIZYzzYwO39nyIGbtRrwMvdTRb8hHw== X-Received: by 2002:a7b:c755:: with SMTP id w21mr30469520wmk.120.1589198246663; Mon, 11 May 2020 04:57:26 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id y70sm27811096wmc.36.2020.05.11.04.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 04:57:25 -0700 (PDT) Date: Mon, 11 May 2020 12:57:22 +0100 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v7 03/15] PM / EM: update callback structure and add device pointer Message-ID: <20200511115722.GA13741@google.com> References: <20200511111912.3001-1-lukasz.luba@arm.com> <20200511111912.3001-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511111912.3001-4-lukasz.luba@arm.com> X-Mailman-Approved-At: Tue, 12 May 2020 07:09:30 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, mka@chromium.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Monday 11 May 2020 at 12:19:00 (+0100), Lukasz Luba wrote: > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index 61623e2ff149..11ee24e06d12 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -103,17 +103,12 @@ scmi_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask) > } > > static int __maybe_unused > -scmi_get_cpu_power(unsigned long *power, unsigned long *KHz, int cpu) > +scmi_get_cpu_power(unsigned long *power, unsigned long *KHz, > + struct device *cpu_dev) > { > - struct device *cpu_dev = get_cpu_device(cpu); > unsigned long Hz; > int ret, domain; > > - if (!cpu_dev) { > - pr_err("failed to get cpu%d device\n", cpu); > - return -ENODEV; > - } > - > domain = handle->perf_ops->device_domain_id(cpu_dev); > if (domain < 0) > return domain; > @@ -200,7 +195,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) > > policy->fast_switch_possible = true; > > - em_register_perf_domain(policy->cpus, nr_opp, &em_cb); So this one has no users after this patch right? I suppose you could squash patch 05 in this one. But no big deal. Acked-by: Quentin Perret > + em_dev_register_perf_domain(cpu_dev, nr_opp, &em_cb, policy->cpus); > > return 0; _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel