From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jY5qo-0000BD-94 for mharc-qemu-riscv@gnu.org; Mon, 11 May 2020 06:39:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jY5qn-00008f-0Q for qemu-riscv@nongnu.org; Mon, 11 May 2020 06:39:57 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:55169 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jY5qm-0007TA-Br for qemu-riscv@nongnu.org; Mon, 11 May 2020 06:39:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589193595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iNZ95QBBgOhPlpv2+m1T3JOLKUsjDBZXx4buFuBqv10=; b=LrKx5FctdsJjICUcdkLgpGJ2TCaN9xh2uKHfjFi+CSt1yv3dffhRwzaLr7DMW0J19L3yoL G2yv8F8Ru0bchq9rW/7NIFqirQuECae+EB3Ao4XPoS9L/CM7DNmCTfuNDP5Qms6QDs7Z2L dII9HuS0nfs3DbimDDAdt4KEI3EIYLo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-KZmoN46UMAu4kHtyaRNbYA-1; Mon, 11 May 2020 06:39:52 -0400 X-MC-Unique: KZmoN46UMAu4kHtyaRNbYA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 99D20A0BD8; Mon, 11 May 2020 10:39:48 +0000 (UTC) Received: from gondolin (ovpn-112-254.ams2.redhat.com [10.36.112.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E1B31001DC2; Mon, 11 May 2020 10:39:39 +0000 (UTC) Date: Mon, 11 May 2020 12:39:36 +0200 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Laurent Vivier , Mark Cave-Ayland , Max Filippov , "Edgar E. Iglesias" , Palmer Dabbelt , Marcel Apfelbaum , Stafford Horne , Roman Bolshakov , Sagar Karandikar , Eduardo Habkost , qemu-s390x@nongnu.org, Aleksandar Rikalo , Marek Vasut , Alistair Francis , Artyom Tarasenko , Peter Maydell , qemu-riscv@nongnu.org, Aurelien Jarno , Bastian Koppelmann , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Chris Wulff , Richard Henderson , David Gibson , David Hildenbrand , Alex =?UTF-8?B?QmVubsOpZQ==?= Subject: Re: [PATCH 06/11] target/s390x: Only compile decode_basedisp() on system-mode Message-ID: <20200511123936.057dd414.cohuck@redhat.com> In-Reply-To: <20200509130910.26335-7-f4bug@amsat.org> References: <20200509130910.26335-1-f4bug@amsat.org> <20200509130910.26335-7-f4bug@amsat.org> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=207.211.31.120; envelope-from=cohuck@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/11 02:55:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2020 10:39:57 -0000 On Sat, 9 May 2020 15:09:05 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > The decode_basedisp*() methods are only used in ioinst.c, > which is only build in system-mode emulation. I/O instructions are privileged, and other S instructions are decoded elsewhere. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > target/s390x/internal.h | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFFDC47255 for ; Mon, 11 May 2020 10:40:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9244207DD for ; Mon, 11 May 2020 10:40:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LrKx5Fct" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9244207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jY5rP-0000qF-2p for qemu-devel@archiver.kernel.org; Mon, 11 May 2020 06:40:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jY5qn-00009a-I2 for qemu-devel@nongnu.org; Mon, 11 May 2020 06:39:57 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:41362 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jY5qm-0007TB-Ke for qemu-devel@nongnu.org; Mon, 11 May 2020 06:39:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589193595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iNZ95QBBgOhPlpv2+m1T3JOLKUsjDBZXx4buFuBqv10=; b=LrKx5FctdsJjICUcdkLgpGJ2TCaN9xh2uKHfjFi+CSt1yv3dffhRwzaLr7DMW0J19L3yoL G2yv8F8Ru0bchq9rW/7NIFqirQuECae+EB3Ao4XPoS9L/CM7DNmCTfuNDP5Qms6QDs7Z2L dII9HuS0nfs3DbimDDAdt4KEI3EIYLo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-KZmoN46UMAu4kHtyaRNbYA-1; Mon, 11 May 2020 06:39:52 -0400 X-MC-Unique: KZmoN46UMAu4kHtyaRNbYA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 99D20A0BD8; Mon, 11 May 2020 10:39:48 +0000 (UTC) Received: from gondolin (ovpn-112-254.ams2.redhat.com [10.36.112.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E1B31001DC2; Mon, 11 May 2020 10:39:39 +0000 (UTC) Date: Mon, 11 May 2020 12:39:36 +0200 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH 06/11] target/s390x: Only compile decode_basedisp() on system-mode Message-ID: <20200511123936.057dd414.cohuck@redhat.com> In-Reply-To: <20200509130910.26335-7-f4bug@amsat.org> References: <20200509130910.26335-1-f4bug@amsat.org> <20200509130910.26335-7-f4bug@amsat.org> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=207.211.31.120; envelope-from=cohuck@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/11 02:55:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , David Hildenbrand , Mark Cave-Ayland , qemu-devel@nongnu.org, Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Marek Vasut , Aleksandar Markovic , qemu-ppc@nongnu.org, Aleksandar Rikalo , David Gibson , Artyom Tarasenko , Eduardo Habkost , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Stafford Horne , Alex =?UTF-8?B?QmVubsOpZQ==?= , Richard Henderson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Roman Bolshakov , Laurent Vivier , Palmer Dabbelt , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, 9 May 2020 15:09:05 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > The decode_basedisp*() methods are only used in ioinst.c, > which is only build in system-mode emulation. I/O instructions are privileged, and other S instructions are decoded elsewhere. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > target/s390x/internal.h | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Cornelia Huck