From: "J. Bruce Fields" <bfields@fieldses.org>
To: Ma Feng <mafeng.ma@huawei.com>
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: Fix old-style function definition
Date: Mon, 11 May 2020 09:58:06 -0400 [thread overview]
Message-ID: <20200511135806.GC8629@fieldses.org> (raw)
In-Reply-To: <1589198828-11226-1-git-send-email-mafeng.ma@huawei.com>
On Mon, May 11, 2020 at 08:07:08PM +0800, Ma Feng wrote:
> Fix warning:
>
> fs/nfsd/nfssvc.c:604:6: warning: old-style function definition [-Wold-style-definition]
> bool i_am_nfsd()
Applying for 5.8, thanks.--b.
> ^~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
> ---
> fs/nfsd/nfssvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 4f588c0..b603dfc 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -601,7 +601,7 @@ static const struct svc_serv_ops nfsd_thread_sv_ops = {
> .svo_module = THIS_MODULE,
> };
>
> -bool i_am_nfsd()
> +bool i_am_nfsd(void)
> {
> return kthread_func(current) == nfsd;
> }
> --
> 2.6.2
prev parent reply other threads:[~2020-05-11 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 12:07 [PATCH] nfsd: Fix old-style function definition Ma Feng
2020-05-11 13:58 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511135806.GC8629@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mafeng.ma@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.