Re: [PATCH v1 3/4] i2c: designware: Split out ACPI parts into separate module

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, May 11, 2020 at 04:31:18PM +0300, Jarkko Nikula wrote:
> On 5/7/20 4:51 PM, Andy Shevchenko wrote:
> > For better maintenance and possible code reuse in the future,
> > split out ACPI parts into a separate module.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >   drivers/i2c/busses/Makefile                 |   3 +
> >   drivers/i2c/busses/i2c-designware-acpi.c    | 130 +++++++++++++++++
> >   drivers/i2c/busses/i2c-designware-core.h    |   8 ++
> >   drivers/i2c/busses/i2c-designware-platdrv.c | 151 +++-----------------
> >   4 files changed, 163 insertions(+), 129 deletions(-)
> >   create mode 100644 drivers/i2c/busses/i2c-designware-acpi.c
> > 
> Comment to both of this and patch 2/4:
> 
> I'm not so fan of introducing even more i2c-designware modules. No any other
> drivers have so many files as i2c-designware in drivers/i2c/busses/*.c.
> Feeling a bit of hall of shame because of it :-)
> 
> What's the rationale here? Currently i2c-designware-platdrv.c is 512 lines
> of code so it's not too hard to maintain in my opinion.

How to use same functionality in PCI and platform driver? Are you implying that
the common.c is good enough? I would move there, of course.

-- 
With Best Regards,
Andy Shevchenko