From: Sam Ravnborg <sam@ravnborg.org>
To: robh+dt@kernel.org, Tomi Valkeinen <tomi.valkeinen@ti.com>,
kernel@collabora.com, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net,
laurent.pinchart@ideasonboard.com
Subject: Re: [RFC PATCH] dt-bindings: display: ti,tfp410.txt: convert to yaml
Date: Mon, 11 May 2020 18:26:22 +0200 [thread overview]
Message-ID: <20200511162622.GA19798@ravnborg.org> (raw)
In-Reply-To: <20200511145911.2yv3aepofxqwdsju@rcn-XPS-13-9360>
Hi Ricardo.
On Mon, May 11, 2020 at 04:59:11PM +0200, Ricardo Cañuelo wrote:
> Hi Rob,
>
> What's your opinion on this?
I'm not Rob, but anyway.
>
> Some context: It's about bindings that define signed integer properties
> with range checks that go below and above zero. The schema checker fails
> because, apparently, it interprets every cell value as an uint32, which
> makes the range check fail for negative numbers.
>
> > > > b) Redefine this property to be closer to the datasheet description
> > > > (ie. unsigned integers from 0 to 7) and adapt the driver accordingly.
> > > > This would also let us define its range properly using minimum and
> > > > maximum properties for it.
> > > >
> > > > I think (b) is the right thing to do but I want to know your
> > > > opinion. Besides, I don't have this hardware at hand and if I updated
> > > > the driver I wouldn't be able to test it.
Based on the discussions option b) above seems like the best compromise.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: robh+dt@kernel.org, Tomi Valkeinen <tomi.valkeinen@ti.com>,
kernel@collabora.com, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net,
laurent.pinchart@ideasonboard.com
Subject: Re: [RFC PATCH] dt-bindings: display: ti,tfp410.txt: convert to yaml
Date: Mon, 11 May 2020 18:26:22 +0200 [thread overview]
Message-ID: <20200511162622.GA19798@ravnborg.org> (raw)
In-Reply-To: <20200511145911.2yv3aepofxqwdsju@rcn-XPS-13-9360>
Hi Ricardo.
On Mon, May 11, 2020 at 04:59:11PM +0200, Ricardo Cañuelo wrote:
> Hi Rob,
>
> What's your opinion on this?
I'm not Rob, but anyway.
>
> Some context: It's about bindings that define signed integer properties
> with range checks that go below and above zero. The schema checker fails
> because, apparently, it interprets every cell value as an uint32, which
> makes the range check fail for negative numbers.
>
> > > > b) Redefine this property to be closer to the datasheet description
> > > > (ie. unsigned integers from 0 to 7) and adapt the driver accordingly.
> > > > This would also let us define its range properly using minimum and
> > > > maximum properties for it.
> > > >
> > > > I think (b) is the right thing to do but I want to know your
> > > > opinion. Besides, I don't have this hardware at hand and if I updated
> > > > the driver I wouldn't be able to test it.
Based on the discussions option b) above seems like the best compromise.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: robh+dt@kernel.org, Tomi Valkeinen <tomi.valkeinen@ti.com>,
kernel@collabora.com, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net,
laurent.pinchart@ideasonboard.com
Subject: Re: [RFC PATCH] dt-bindings: display: ti,tfp410.txt: convert to yaml
Date: Mon, 11 May 2020 18:26:22 +0200 [thread overview]
Message-ID: <20200511162622.GA19798@ravnborg.org> (raw)
In-Reply-To: <20200511145911.2yv3aepofxqwdsju@rcn-XPS-13-9360>
Hi Ricardo.
On Mon, May 11, 2020 at 04:59:11PM +0200, Ricardo Cañuelo wrote:
> Hi Rob,
>
> What's your opinion on this?
I'm not Rob, but anyway.
>
> Some context: It's about bindings that define signed integer properties
> with range checks that go below and above zero. The schema checker fails
> because, apparently, it interprets every cell value as an uint32, which
> makes the range check fail for negative numbers.
>
> > > > b) Redefine this property to be closer to the datasheet description
> > > > (ie. unsigned integers from 0 to 7) and adapt the driver accordingly.
> > > > This would also let us define its range properly using minimum and
> > > > maximum properties for it.
> > > >
> > > > I think (b) is the right thing to do but I want to know your
> > > > opinion. Besides, I don't have this hardware at hand and if I updated
> > > > the driver I wouldn't be able to test it.
Based on the discussions option b) above seems like the best compromise.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-11 16:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 9:20 [RFC PATCH] dt-bindings: display: ti,tfp410.txt: convert to yaml Ricardo Cañuelo
2020-04-28 9:20 ` Ricardo Cañuelo
2020-04-28 9:20 ` Ricardo Cañuelo
2020-04-28 9:49 ` Tomi Valkeinen
2020-04-28 9:49 ` Tomi Valkeinen
2020-04-28 9:49 ` Tomi Valkeinen
2020-05-06 7:21 ` Ricardo Cañuelo
2020-05-06 7:21 ` Ricardo Cañuelo
2020-05-06 7:21 ` Ricardo Cañuelo
2020-05-06 8:01 ` Tomi Valkeinen
2020-05-06 8:01 ` Tomi Valkeinen
2020-05-06 8:01 ` Tomi Valkeinen
2020-05-06 8:28 ` Ricardo Cañuelo
2020-05-06 8:28 ` Ricardo Cañuelo
2020-05-06 8:28 ` Ricardo Cañuelo
2020-05-06 8:33 ` Tomi Valkeinen
2020-05-06 8:33 ` Tomi Valkeinen
2020-05-06 8:33 ` Tomi Valkeinen
2020-05-06 15:53 ` Laurent Pinchart
2020-05-06 15:53 ` Laurent Pinchart
2020-05-06 15:53 ` Laurent Pinchart
2020-05-11 14:59 ` Ricardo Cañuelo
2020-05-11 14:59 ` Ricardo Cañuelo
2020-05-11 14:59 ` Ricardo Cañuelo
2020-05-11 16:26 ` Sam Ravnborg [this message]
2020-05-11 16:26 ` Sam Ravnborg
2020-05-11 16:26 ` Sam Ravnborg
2020-05-12 2:09 ` Rob Herring
2020-05-12 2:09 ` Rob Herring
2020-05-12 2:09 ` Rob Herring
2020-05-13 11:09 ` Ricardo Cañuelo
2020-05-13 11:09 ` Ricardo Cañuelo
2020-05-13 11:09 ` Ricardo Cañuelo
2020-05-13 14:08 ` Laurent Pinchart
2020-05-13 14:08 ` Laurent Pinchart
2020-05-13 14:08 ` Laurent Pinchart
2020-05-13 14:20 ` Ricardo Cañuelo
2020-05-13 14:20 ` Ricardo Cañuelo
2020-05-13 14:20 ` Ricardo Cañuelo
2020-04-28 19:21 ` Sam Ravnborg
2020-04-28 19:21 ` Sam Ravnborg
2020-04-28 19:21 ` Sam Ravnborg
2020-04-29 8:54 ` Ricardo Cañuelo
2020-04-29 8:54 ` Ricardo Cañuelo
2020-04-29 8:54 ` Ricardo Cañuelo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511162622.GA19798@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason@lakedaemon.net \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.