diff for duplicates of <20200511183704.GA225608@mwanda> diff --git a/a/1.txt b/N1/1.txt index 82347bf..f81e0d5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,10 +17,10 @@ index 00bca6116f930..fd4889f7b3d90 100644 cmd->faults++; } -- if (ret = 0) +- if (ret == 0) - ret = copy_to_user(u64_to_user_ptr(cmd->ptr), bounce.ptr, - bounce.size); -+ if (ret = 0) { ++ if (ret == 0) { + if (copy_to_user(u64_to_user_ptr(cmd->ptr), bounce.ptr, + bounce.size)) + ret = -EFAULT; @@ -56,10 +56,10 @@ index 00bca6116f930..fd4889f7b3d90 100644 mutex_lock(&dmirror->mutex); ret = dmirror_do_read(dmirror, start, end, &bounce); mutex_unlock(&dmirror->mutex); -- if (ret = 0) +- if (ret == 0) - ret = copy_to_user(u64_to_user_ptr(cmd->ptr), bounce.ptr, - bounce.size); -+ if (ret = 0) { ++ if (ret == 0) { + if (copy_to_user(u64_to_user_ptr(cmd->ptr), bounce.ptr, + bounce.size)) + ret = -EFAULT; diff --git a/a/content_digest b/N1/content_digest index e023074..33f8778 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[PATCH] mm/hmm/test: Fix some copy_to_user() error handling\0" - "Date\0Mon, 11 May 2020 18:37:04 +0000\0" + "Date\0Mon, 11 May 2020 21:37:04 +0300\0" "To\0J\303\251r\303\264me Glisse <jglisse@redhat.com>" " Ralph Campbell <rcampbell@nvidia.com>\0" "Cc\0Jason Gunthorpe <jgg@ziepe.ca>" @@ -27,10 +27,10 @@ " \t\tcmd->faults++;\n" " \t}\n" " \n" - "-\tif (ret = 0)\n" + "-\tif (ret == 0)\n" "-\t\tret = copy_to_user(u64_to_user_ptr(cmd->ptr), bounce.ptr,\n" "-\t\t\t\t\tbounce.size);\n" - "+\tif (ret = 0) {\n" + "+\tif (ret == 0) {\n" "+\t\tif (copy_to_user(u64_to_user_ptr(cmd->ptr), bounce.ptr,\n" "+\t\t\t\t bounce.size))\n" "+\t\t\tret = -EFAULT;\n" @@ -66,10 +66,10 @@ " \tmutex_lock(&dmirror->mutex);\n" " \tret = dmirror_do_read(dmirror, start, end, &bounce);\n" " \tmutex_unlock(&dmirror->mutex);\n" - "-\tif (ret = 0)\n" + "-\tif (ret == 0)\n" "-\t\tret = copy_to_user(u64_to_user_ptr(cmd->ptr), bounce.ptr,\n" "-\t\t\t\t\tbounce.size);\n" - "+\tif (ret = 0) {\n" + "+\tif (ret == 0) {\n" "+\t\tif (copy_to_user(u64_to_user_ptr(cmd->ptr), bounce.ptr,\n" "+\t\t\t\t bounce.size))\n" "+\t\t\tret = -EFAULT;\n" @@ -117,4 +117,4 @@ "-- \n" 2.26.2 -8932dd66493d3a63fa491e7a92817b375fef250da9d0d2e61b2a496290016a63 +9b8202cfeda6633b0a11347d4f7e413d7ffb136bbe457ed33ac10ea0308e516f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.