From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8728C47255 for ; Mon, 11 May 2020 17:03:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85028206CC for ; Mon, 11 May 2020 17:03:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="olDnCCIc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85028206CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=woyzTc45stjVuL9dsiA0/0blZ/kYX8QC8+08NBNzwjg=; b=olDnCCIcQWKQYo dpGl+9c9veYyOSepzahiZYltFyXCMH2n9JYMYHTwyNQRt0nOCEXrzo9atOO1JOSBmR/+XP0H5OKsk Bovn8fUwoLYrXCmt6FgSGxGLOE6MOMIP0qR2dpVq/IuA8rDeB/pv04ecuhVN5h2cgQaJaEiAE7SW5 lGkCwib6RVKUAjKW7eaM0JUQv6J3+PwY3Z323eDPYkU+Wrih21BkCHGPhiNRZDtx83nKfJAKbTmq3 gnNulFthyXzFW8zJj5mkWIbXo/1O9hDf77hjUl+7jZC3vBz3NxPCEU/Cvtofq9IfqoO9esGxLK3U+ qmPvNVjdcPMFxQxGjgzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYBqG-000371-Cd; Mon, 11 May 2020 17:03:48 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYBpv-0002bU-Pw for linux-mtd@lists.infradead.org; Mon, 11 May 2020 17:03:29 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 55DAB240005; Mon, 11 May 2020 17:03:22 +0000 (UTC) Date: Mon, 11 May 2020 19:03:21 +0200 From: Miquel Raynal To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas Subject: Re: [PATCH 1/3] nand: brcmnand: rename v4 registers Message-ID: <20200511190321.1091bbf2@xps13> In-Reply-To: <20200510151406.2527856-1-noltari@gmail.com> References: <20200510151406.2527856-1-noltari@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_100327_983090_BF4DC3EE X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, kdasu.kdev@gmail.com, richard@nod.at, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, computersforpeace@gmail.com, sumit.semwal@linaro.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgw4FsdmFybywKCsOBbHZhcm8gRmVybsOhbmRleiBSb2phcyA8bm9sdGFyaUBnbWFpbC5jb20+ IHdyb3RlIG9uIFN1biwgMTAgTWF5IDIwMjAKMTc6MTQ6MDQgKzAyMDA6Cgo+IFRoZXNlIHJlZ2lz dGVycyBhcmUgYWxzbyB1c2VkIG9uIHYzLjMuCj4gCj4gU2lnbmVkLW9mZi1ieTogw4FsdmFybyBG ZXJuw6FuZGV6IFJvamFzIDxub2x0YXJpQGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tdGQv bmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYyB8IDggKysrKy0tLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQv cmF3L2JyY21uYW5kL2JyY21uYW5kLmMKPiBpbmRleCBlNGUzY2VlYWMzOGYuLjZhMDhkZDA3YjA1 OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9icmNtbmFuZC9icmNtbmFuZC5j Cj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYwo+IEBAIC0z MzgsOCArMzM4LDggQEAgZW51bSBicmNtbmFuZF9yZWcgewo+ICAJQlJDTU5BTkRfRkNfQkFTRSwK PiAgfTsKPiAgCj4gLS8qIEJSQ01OQU5EIHY0LjAgKi8KPiAtc3RhdGljIGNvbnN0IHUxNiBicmNt bmFuZF9yZWdzX3Y0MFtdID0gewo+ICsvKiBCUkNNTkFORCB2My4zLXY0LjAgKi8KPiArc3RhdGlj IGNvbnN0IHUxNiBicmNtbmFuZF9yZWdzX3YzM1tdID0gewo+ICAJW0JSQ01OQU5EX0NNRF9TVEFS VF0JCT0gIDB4MDQsCj4gIAlbQlJDTU5BTkRfQ01EX0VYVF9BRERSRVNTXQk9ICAweDA4LAo+ICAJ W0JSQ01OQU5EX0NNRF9BRERSRVNTXQkJPSAgMHgwYywKPiBAQCAtNTkxLDggKzU5MSw4IEBAIHN0 YXRpYyBpbnQgYnJjbW5hbmRfcmV2aXNpb25faW5pdChzdHJ1Y3QgYnJjbW5hbmRfY29udHJvbGxl ciAqY3RybCkKPiAgCQljdHJsLT5yZWdfb2Zmc2V0cyA9IGJyY21uYW5kX3JlZ3NfdjYwOwo+ICAJ ZWxzZSBpZiAoY3RybC0+bmFuZF92ZXJzaW9uID49IDB4MDUwMCkKPiAgCQljdHJsLT5yZWdfb2Zm c2V0cyA9IGJyY21uYW5kX3JlZ3NfdjUwOwo+IC0JZWxzZSBpZiAoY3RybC0+bmFuZF92ZXJzaW9u ID49IDB4MDQwMCkKPiAtCQljdHJsLT5yZWdfb2Zmc2V0cyA9IGJyY21uYW5kX3JlZ3NfdjQwOwo+ ICsJZWxzZSBpZiAoY3RybC0+bmFuZF92ZXJzaW9uID49IDB4MDMwMykKPiArCQljdHJsLT5yZWdf b2Zmc2V0cyA9IGJyY21uYW5kX3JlZ3NfdjMzOwo+ICAKPiAgCS8qIENoaXAtc2VsZWN0IHN0cmlk ZSAqLwo+ICAJaWYgKGN0cmwtPm5hbmRfdmVyc2lvbiA+PSAweDA3MDEpCgpSZXZpZXdlZC1ieTog TWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vz c2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B62BC54E8E for ; Mon, 11 May 2020 17:03:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0ABFD206CC for ; Mon, 11 May 2020 17:03:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730878AbgEKRD1 convert rfc822-to-8bit (ORCPT ); Mon, 11 May 2020 13:03:27 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:61445 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730743AbgEKRD0 (ORCPT ); Mon, 11 May 2020 13:03:26 -0400 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 55DAB240005; Mon, 11 May 2020 17:03:22 +0000 (UTC) Date: Mon, 11 May 2020 19:03:21 +0200 From: Miquel Raynal To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas Cc: computersforpeace@gmail.com, kdasu.kdev@gmail.com, richard@nod.at, vigneshr@ti.com, sumit.semwal@linaro.org, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH 1/3] nand: brcmnand: rename v4 registers Message-ID: <20200511190321.1091bbf2@xps13> In-Reply-To: <20200510151406.2527856-1-noltari@gmail.com> References: <20200510151406.2527856-1-noltari@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Álvaro, Álvaro Fernández Rojas wrote on Sun, 10 May 2020 17:14:04 +0200: > These registers are also used on v3.3. > > Signed-off-by: Álvaro Fernández Rojas > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index e4e3ceeac38f..6a08dd07b058 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -338,8 +338,8 @@ enum brcmnand_reg { > BRCMNAND_FC_BASE, > }; > > -/* BRCMNAND v4.0 */ > -static const u16 brcmnand_regs_v40[] = { > +/* BRCMNAND v3.3-v4.0 */ > +static const u16 brcmnand_regs_v33[] = { > [BRCMNAND_CMD_START] = 0x04, > [BRCMNAND_CMD_EXT_ADDRESS] = 0x08, > [BRCMNAND_CMD_ADDRESS] = 0x0c, > @@ -591,8 +591,8 @@ static int brcmnand_revision_init(struct brcmnand_controller *ctrl) > ctrl->reg_offsets = brcmnand_regs_v60; > else if (ctrl->nand_version >= 0x0500) > ctrl->reg_offsets = brcmnand_regs_v50; > - else if (ctrl->nand_version >= 0x0400) > - ctrl->reg_offsets = brcmnand_regs_v40; > + else if (ctrl->nand_version >= 0x0303) > + ctrl->reg_offsets = brcmnand_regs_v33; > > /* Chip-select stride */ > if (ctrl->nand_version >= 0x0701) Reviewed-by: Miquel Raynal