From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B298FC47255 for ; Mon, 11 May 2020 19:30:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94027206DB for ; Mon, 11 May 2020 19:30:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OzVpqUU6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731216AbgEKTac (ORCPT ); Mon, 11 May 2020 15:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729453AbgEKTab (ORCPT ); Mon, 11 May 2020 15:30:31 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7828C061A0C for ; Mon, 11 May 2020 12:30:31 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id r14so5196240pfg.2 for ; Mon, 11 May 2020 12:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gzyfnO/5LbG2mrH2lA0azbgAQiWtK0agPG/QW/aD0JA=; b=OzVpqUU6k4CDMc0nrbShznwLyn+kmnl+BiPHhPbWnikxGiuco8hPSb3nS1q3qW7Cek TlIdfXMHgEChfZXCfsI3of4zCEHuppr5PoCE3ZmpK0SP1LiofuG1NSTRPyOmD0nbKgGD Bwa03tUplrVt+uaafrpI8WO/Kiw8FLdoImebhEbTRHIm2mxwGlr8SIVV8RSntyAW7IIW m9WJ98M8I/GIgMuti/4gM3KJ4GRCV7VPnkIyNoVSwhRvr8uOQ9XfPJNaLkNucRR21ygo 7yLopUX/fMQxLY0w5Z54iE/yRdh2wOKRkc5CN/QWkO77VCCiI1CCgHTzJiuY46Yq4gJI 1epw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gzyfnO/5LbG2mrH2lA0azbgAQiWtK0agPG/QW/aD0JA=; b=ZLsZjhUCBJGv7j4hv7+U7Hma6xa+jkWi8sYaM/bjffIJkVvX4/StIF2JY8jaiz/spP 4H8lgk9PP43HcoCgBQOJMwLKgxENuBL6Di9TdaigetLL93O007I4huO+UWOhwd8DqE2b 4gHuNGVy9BYwDu5qaKLWOAoaTSQbx6N7UTydiyWS1/2Le6xkTI0O3V8hmBQq0HIzFcnW rHOTYmU+KLZWORBr94fQcTmzggsTlScVC6q0JauGKAxmWJWHGhbikeVxaSGt1NewidFR xuaq0tpFIvi+TPzeDikmlkHCBG85u7E5WBRzdK2Di/DIv8Ojdy9zPeMxhcD/loT7y4z5 mbAg== X-Gm-Message-State: AGi0PuZloCvc/isVfcSTdtG9rTFHD7414nCdF5fH5Xwxh52aZnrMCF+1 Ewfqam3O8jhQR4DOKtllaClrdbAXfGg= X-Google-Smtp-Source: APiQypIOtVLmN26sBLQEPnN3hrhyIv6xvI5WifHGysFUwEmFLrhzINvd3EvqA0ARHr6GkqxEp7LIOw== X-Received: by 2002:a63:750b:: with SMTP id q11mr15767211pgc.138.1589225431230; Mon, 11 May 2020 12:30:31 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id z185sm8726197pgz.26.2020.05.11.12.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 12:30:30 -0700 (PDT) Date: Mon, 11 May 2020 12:31:24 -0700 From: Bjorn Andersson To: Sibi Sankar Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, swboyd@chromium.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, dianders@chromium.org, evgreen@chromium.org, mka@chromium.org Subject: Re: [PATCH v6] iommu/arm-smmu-qcom: Request direct mapping for modem device Message-ID: <20200511193124.GG20625@builder.lan> References: <20200511175532.25874-1-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200511175532.25874-1-sibis@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 11 May 10:55 PDT 2020, Sibi Sankar wrote: > The modem remote processor has two access paths to DDR. One path is > directly connected to DDR and another path goes through an SMMU. The > SMMU path is configured to be a direct mapping because it's used by > various peripherals in the modem subsystem. Typically this direct > mapping is configured statically at EL2 by QHEE (Qualcomm's Hypervisor > Execution Environment) before the kernel is entered. > > In certain firmware configuration, especially when the kernel is already > in full control of the SMMU, defer programming the modem SIDs to the > kernel. Let's add compatibles here so that we can have the kernel > program the SIDs for the modem in these cases. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Sibi Sankar > --- > > V6 > * Rebased on Will's for-joerg/arm-smmu/updates > * Reword commit message and add more details [Stephen] > > drivers/iommu/arm-smmu-qcom.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c > index 5bedf21587a56..cf01d0215a397 100644 > --- a/drivers/iommu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm-smmu-qcom.c > @@ -17,7 +17,9 @@ static const struct of_device_id qcom_smmu_client_of_match[] = { > { .compatible = "qcom,mdp4" }, > { .compatible = "qcom,mdss" }, > { .compatible = "qcom,sc7180-mdss" }, > + { .compatible = "qcom,sc7180-mss-pil" }, > { .compatible = "qcom,sdm845-mdss" }, > + { .compatible = "qcom,sdm845-mss-pil" }, > { } > }; > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDD8C47255 for ; Mon, 11 May 2020 19:37:58 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EE68206DB for ; Mon, 11 May 2020 19:37:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OzVpqUU6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EE68206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0420D86BB9; Mon, 11 May 2020 19:37:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o7X5gtZ6G_2N; Mon, 11 May 2020 19:37:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4B41486BAE; Mon, 11 May 2020 19:37:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 06D21C0178; Mon, 11 May 2020 19:37:57 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2FA03C016F for ; Mon, 11 May 2020 19:37:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 1E63087E1B for ; Mon, 11 May 2020 19:37:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JNoQACgojw7o for ; Mon, 11 May 2020 19:37:54 +0000 (UTC) X-Greylist: delayed 00:07:23 by SQLgrey-1.7.6 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by whitealder.osuosl.org (Postfix) with ESMTPS id 4F30387856 for ; Mon, 11 May 2020 19:37:54 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id f6so5022036pgm.1 for ; Mon, 11 May 2020 12:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gzyfnO/5LbG2mrH2lA0azbgAQiWtK0agPG/QW/aD0JA=; b=OzVpqUU6k4CDMc0nrbShznwLyn+kmnl+BiPHhPbWnikxGiuco8hPSb3nS1q3qW7Cek TlIdfXMHgEChfZXCfsI3of4zCEHuppr5PoCE3ZmpK0SP1LiofuG1NSTRPyOmD0nbKgGD Bwa03tUplrVt+uaafrpI8WO/Kiw8FLdoImebhEbTRHIm2mxwGlr8SIVV8RSntyAW7IIW m9WJ98M8I/GIgMuti/4gM3KJ4GRCV7VPnkIyNoVSwhRvr8uOQ9XfPJNaLkNucRR21ygo 7yLopUX/fMQxLY0w5Z54iE/yRdh2wOKRkc5CN/QWkO77VCCiI1CCgHTzJiuY46Yq4gJI 1epw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gzyfnO/5LbG2mrH2lA0azbgAQiWtK0agPG/QW/aD0JA=; b=c6fhm4Ck2px4DnPh1RyikYRIjLUEeTlvoTr3HxYALCsvZlewF3Bb4Ijf+QMBOsj5kk mx3liyXDUDE0KWIl8Db+IMaO+tt611U1qmBvRH9IjO7aDXjQSmLVPeMz5qdNsk/sQMD8 rk3QdSCCchUpPqi9W+rhNBs/Fk3zcxe6a0zBkOMs8jfkQVePfiWz6lWKEILaPPz+/H5L SUarHYhwu+0B78Qc1SWr7Kjb4oOorZLfgXblzq+LQCX15Xhm2ci05h+/l+A0T/Pcc7Ym /176BoA3V5BZUClUi1PCaP6vHm33MT0Pwkva/THGcUvQUG3j2cq9rf/9l1zOPEqcDaVa 86NQ== X-Gm-Message-State: AGi0PubUw5UAtC3Emf6mkVm8qW+5NzaHiTADQIephHCyhgp7HRokRJh6 QRSAFyEuWrEY0wgXw9Rbt8nI/ai5+Lg= X-Google-Smtp-Source: APiQypIOtVLmN26sBLQEPnN3hrhyIv6xvI5WifHGysFUwEmFLrhzINvd3EvqA0ARHr6GkqxEp7LIOw== X-Received: by 2002:a63:750b:: with SMTP id q11mr15767211pgc.138.1589225431230; Mon, 11 May 2020 12:30:31 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id z185sm8726197pgz.26.2020.05.11.12.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 12:30:30 -0700 (PDT) Date: Mon, 11 May 2020 12:31:24 -0700 From: Bjorn Andersson To: Sibi Sankar Subject: Re: [PATCH v6] iommu/arm-smmu-qcom: Request direct mapping for modem device Message-ID: <20200511193124.GG20625@builder.lan> References: <20200511175532.25874-1-sibis@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511175532.25874-1-sibis@codeaurora.org> Cc: dianders@chromium.org, will@kernel.org, linux-kernel@vger.kernel.org, evgreen@chromium.org, swboyd@chromium.org, iommu@lists.linux-foundation.org, mka@chromium.org, linux-arm-msm@vger.kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon 11 May 10:55 PDT 2020, Sibi Sankar wrote: > The modem remote processor has two access paths to DDR. One path is > directly connected to DDR and another path goes through an SMMU. The > SMMU path is configured to be a direct mapping because it's used by > various peripherals in the modem subsystem. Typically this direct > mapping is configured statically at EL2 by QHEE (Qualcomm's Hypervisor > Execution Environment) before the kernel is entered. > > In certain firmware configuration, especially when the kernel is already > in full control of the SMMU, defer programming the modem SIDs to the > kernel. Let's add compatibles here so that we can have the kernel > program the SIDs for the modem in these cases. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Sibi Sankar > --- > > V6 > * Rebased on Will's for-joerg/arm-smmu/updates > * Reword commit message and add more details [Stephen] > > drivers/iommu/arm-smmu-qcom.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c > index 5bedf21587a56..cf01d0215a397 100644 > --- a/drivers/iommu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm-smmu-qcom.c > @@ -17,7 +17,9 @@ static const struct of_device_id qcom_smmu_client_of_match[] = { > { .compatible = "qcom,mdp4" }, > { .compatible = "qcom,mdss" }, > { .compatible = "qcom,sc7180-mdss" }, > + { .compatible = "qcom,sc7180-mss-pil" }, > { .compatible = "qcom,sdm845-mdss" }, > + { .compatible = "qcom,sdm845-mss-pil" }, > { } > }; > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F49EC47255 for ; Mon, 11 May 2020 19:30:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0C56206DB for ; Mon, 11 May 2020 19:30:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GsDbRl2D"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OzVpqUU6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0C56206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sX2Uw2ZpaGkvmElxu37HsbaijWhYugDk+7aB14Dsz2M=; b=GsDbRl2D5pTAPP MjIC9yt/a/J2ZfXSmyist1pTwzCMCRotknw3WRxN4b+rwbQVgw+F1fL5VD+emo5Tlum0af65rQoG/ munQm7I1tvZ4Vl1wWyo0wIoh3gLMRCXNziHQloMESatO6EttK4o+xxflFwkb61kuIFdU/S8DqHhAN Q9YM2Qq169rCmaiSrdTlkAId0Kn3mU0jGTwThXaWPaIDiDvBtM9oFtT9nPgiJfzPSUcVYM0zuYWCN UWcUaa5iyYTCZICZeQsI+wNt4a735j7S7a8i45YLBRkxuxpVJwkCLzo8ItwDV0TlwHigClyWtZIxS lBndVTVFepbs3csXlm2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYE8K-0007PG-19; Mon, 11 May 2020 19:30:36 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYE8G-0007OQ-Po for linux-arm-kernel@lists.infradead.org; Mon, 11 May 2020 19:30:34 +0000 Received: by mail-pf1-x442.google.com with SMTP id v63so5182943pfb.10 for ; Mon, 11 May 2020 12:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gzyfnO/5LbG2mrH2lA0azbgAQiWtK0agPG/QW/aD0JA=; b=OzVpqUU6k4CDMc0nrbShznwLyn+kmnl+BiPHhPbWnikxGiuco8hPSb3nS1q3qW7Cek TlIdfXMHgEChfZXCfsI3of4zCEHuppr5PoCE3ZmpK0SP1LiofuG1NSTRPyOmD0nbKgGD Bwa03tUplrVt+uaafrpI8WO/Kiw8FLdoImebhEbTRHIm2mxwGlr8SIVV8RSntyAW7IIW m9WJ98M8I/GIgMuti/4gM3KJ4GRCV7VPnkIyNoVSwhRvr8uOQ9XfPJNaLkNucRR21ygo 7yLopUX/fMQxLY0w5Z54iE/yRdh2wOKRkc5CN/QWkO77VCCiI1CCgHTzJiuY46Yq4gJI 1epw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gzyfnO/5LbG2mrH2lA0azbgAQiWtK0agPG/QW/aD0JA=; b=rjjlE8WC4al6ZuGI2EIcnPYNFkDHmm7fIyKB0givUm8y8LCJkcBj+SJqtkLGGHRd5F soG4ZvdzzhFLyvOrS4WqBOV7yLPtTKI89Sk3zM9/vKnzQScTK6fqCh0pbn5lvXTgvrL8 2EiIQIfjFocY2mrb7CQQlw2D2xqRNtIlMH2Dob4yg0vJM6Zm84vJ9lLRrMEc6um1Eh+o W1+fHAHMznxuMi7dVrCcHQfnEBkEkLX660QiuTYH5vc47LcI2hffAa9sF1LcJiCXipWj rmvBG6owgjaMUuN/2y/KAKJhQ/ygd+sPxLvXVjCBAzrczYSGFi/xSVAfLImmRHynS4kM MyfA== X-Gm-Message-State: AGi0Pua0+en585W2uYJZNKhdFEMRy+gnEZX2Aw5RXLNXmu+0X0jqr1BA A0r0QGTAQAWEsDJqjp8sgW7TUw== X-Google-Smtp-Source: APiQypIOtVLmN26sBLQEPnN3hrhyIv6xvI5WifHGysFUwEmFLrhzINvd3EvqA0ARHr6GkqxEp7LIOw== X-Received: by 2002:a63:750b:: with SMTP id q11mr15767211pgc.138.1589225431230; Mon, 11 May 2020 12:30:31 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id z185sm8726197pgz.26.2020.05.11.12.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 12:30:30 -0700 (PDT) Date: Mon, 11 May 2020 12:31:24 -0700 From: Bjorn Andersson To: Sibi Sankar Subject: Re: [PATCH v6] iommu/arm-smmu-qcom: Request direct mapping for modem device Message-ID: <20200511193124.GG20625@builder.lan> References: <20200511175532.25874-1-sibis@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511175532.25874-1-sibis@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_123032_904270_9DA84653 X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dianders@chromium.org, will@kernel.org, joro@8bytes.org, linux-kernel@vger.kernel.org, evgreen@chromium.org, swboyd@chromium.org, iommu@lists.linux-foundation.org, mka@chromium.org, linux-arm-msm@vger.kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 11 May 10:55 PDT 2020, Sibi Sankar wrote: > The modem remote processor has two access paths to DDR. One path is > directly connected to DDR and another path goes through an SMMU. The > SMMU path is configured to be a direct mapping because it's used by > various peripherals in the modem subsystem. Typically this direct > mapping is configured statically at EL2 by QHEE (Qualcomm's Hypervisor > Execution Environment) before the kernel is entered. > > In certain firmware configuration, especially when the kernel is already > in full control of the SMMU, defer programming the modem SIDs to the > kernel. Let's add compatibles here so that we can have the kernel > program the SIDs for the modem in these cases. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Sibi Sankar > --- > > V6 > * Rebased on Will's for-joerg/arm-smmu/updates > * Reword commit message and add more details [Stephen] > > drivers/iommu/arm-smmu-qcom.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c > index 5bedf21587a56..cf01d0215a397 100644 > --- a/drivers/iommu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm-smmu-qcom.c > @@ -17,7 +17,9 @@ static const struct of_device_id qcom_smmu_client_of_match[] = { > { .compatible = "qcom,mdp4" }, > { .compatible = "qcom,mdss" }, > { .compatible = "qcom,sc7180-mdss" }, > + { .compatible = "qcom,sc7180-mss-pil" }, > { .compatible = "qcom,sdm845-mdss" }, > + { .compatible = "qcom,sdm845-mss-pil" }, > { } > }; > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel