All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jeff Chase <jnchase@google.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
	hverkuil-cisco@xs4all.nl, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Add ch7322 as a trivial device
Date: Mon, 11 May 2020 16:20:47 -0500	[thread overview]
Message-ID: <20200511212047.GA21845@bogus> (raw)
In-Reply-To: <20200424053819.220276-1-jnchase@google.com>

On Fri, Apr 24, 2020 at 01:38:18AM -0400, Jeff Chase wrote:
> The ch7322 is a Chrontel CEC controller.
> 
> Signed-off-by: Jeff Chase <jnchase@google.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 4165352a590a..ec2ddc6cdf9a 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -48,6 +48,8 @@ properties:
>            - capella,cm32181
>              # CM3232: Ambient Light Sensor
>            - capella,cm3232
> +            # CH7322: HDMI-CEC Controller
> +          - chrontel,ch7322

I don't think this qualifies as a trivial device. It has HPDI, OE and 
reset signals all likely hooked up to GPIOs. You might not have those 
hooked up for s/w control, but someone will.

And I'd assume if you had multiple instances, they will need to be 
associated with each connector.

Rob

  parent reply	other threads:[~2020-05-11 21:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24  5:38 [PATCH 1/2] dt-bindings: Add ch7322 as a trivial device Jeff Chase
2020-04-24  5:38 ` [PATCH 2/2] media: cec: i2c: ch7322: Add ch7322 CEC controller driver Jeff Chase
2020-04-24 12:24   ` Hans Verkuil
2020-04-24 19:33     ` Jeff Chase
2020-04-25  9:16       ` Hans Verkuil
2020-04-25  9:31         ` Hans Verkuil
2020-05-05 23:26         ` Jeff Chase
2020-05-06  6:42           ` Hans Verkuil
2020-04-25  9:17   ` Hans Verkuil
2020-05-11 21:20 ` Rob Herring [this message]
2020-05-12 23:23   ` [PATCH 1/2] dt-bindings: Add ch7322 as a trivial device Jeff Chase

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511212047.GA21845@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jnchase@google.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.