From: Sascha Hauer <s.hauer@pengutronix.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS
Date: Tue, 12 May 2020 07:37:10 +0200 [thread overview]
Message-ID: <20200512053710.GU5877@pengutronix.de> (raw)
In-Reply-To: <20200509030239.835689-1-masahiroy@kernel.org>
On Sat, May 09, 2020 at 12:02:38PM +0900, Masahiro Yamada wrote:
> - Turn Wstrict-prototypes into an error
> - Add -Werror=implicit-int
> - Use the standard form -Werror=... for implicit-function-declaration
>
> This commit imports the following Linux commits. They should work for
> barebox too.
>
> 80970472179a Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default
> eeb5687a7139 kbuild: add -Werror=strict-prototypes flag unconditionally
> 61a0902a06d6 kbuild: add -Werror=implicit-int flag unconditionally
> b89f25ea7892 kbuild: use -Werror=implicit-... instead of -Werror-implicit-...
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Applied, thanks
Sascha
>
> Makefile | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9485f5551..a732e24d3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -318,9 +318,10 @@ LINUXINCLUDE := -Iinclude -I$(srctree)/dts/include \
>
> KBUILD_CPPFLAGS := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffreestanding
>
> -KBUILD_CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> - -Werror-implicit-function-declaration \
> - -fno-strict-aliasing -fno-common -Os -pipe -Wmissing-prototypes
> +KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
> + -fno-strict-aliasing -fno-common \
> + -Werror=implicit-function-declaration -Werror=implicit-int \
> + -Os -pipe -Wmissing-prototypes
> KBUILD_AFLAGS := -D__ASSEMBLY__
>
> LDFLAGS_barebox := -Map barebox.map
> --
> 2.25.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-05-12 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 3:02 [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS Masahiro Yamada
2020-05-09 3:02 ` [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Masahiro Yamada
2020-05-12 5:37 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512053710.GU5877@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.