From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Date: Tue, 12 May 2020 06:22:38 +0000 Subject: Re: [PATCH] RDMA/rxe: Return -EFAULT if copy_from_user() fails Message-Id: <20200512062238.GD4814@unreal> List-Id: References: <20200511183742.GB225608@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yanjun Zhu Cc: Dan Carpenter , Sudip Mukherjee , Doug Ledford , Jason Gunthorpe , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" On Tue, May 12, 2020 at 01:12:38AM +0000, Yanjun Zhu wrote: > Does this "err = -EFAULT;" make any sense in your commit? Yanjun, please stop top-posting, it is annoying. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A3DC54E4B for ; Tue, 12 May 2020 06:22:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C8A820836 for ; Tue, 12 May 2020 06:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589264564; bh=BxjNkebzRELWBrlQoNKYuJjXKqEOGdzqAH1umRBcOhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=13JDGbNZ9qSrEAo7YmdHrLi7J2pSrRvjxjYoDbpCAlI+0kFEvOsAat8Z6XbZL5ViC gE3YG/8EETpR3mslRfdC/L2in06GSgMls4GDluEqq8yctwnYKVQ5mAEBvb5GyYIoe8 zyJNbviI/4b/XAMusewyfoHlMKpFi5lfC92VCBPg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728085AbgELGWn (ORCPT ); Tue, 12 May 2020 02:22:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:36630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgELGWn (ORCPT ); Tue, 12 May 2020 02:22:43 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D24C20746; Tue, 12 May 2020 06:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589264563; bh=BxjNkebzRELWBrlQoNKYuJjXKqEOGdzqAH1umRBcOhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oWOVCrIR/yLyCPBjfx02nnI2sqixBHfysB5Xppu+td5xqKs+FSUCbEr2BIZvsqJAR ZK6pX1OZVIvrFrB79RpG8w6eksCNecO2euitGBS0P3cou77XnURUlXZXm4jn+/Zulx rjpKeIFQnF/vnE6J8+sIQP2DcBG2aqoqIAjQISkk= Date: Tue, 12 May 2020 09:22:38 +0300 From: Leon Romanovsky To: Yanjun Zhu Cc: Dan Carpenter , Sudip Mukherjee , Doug Ledford , Jason Gunthorpe , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] RDMA/rxe: Return -EFAULT if copy_from_user() fails Message-ID: <20200512062238.GD4814@unreal> References: <20200511183742.GB225608@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, May 12, 2020 at 01:12:38AM +0000, Yanjun Zhu wrote: > Does this "err = -EFAULT;" make any sense in your commit? Yanjun, please stop top-posting, it is annoying. Thanks