From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] mci: stm32_sdmmc2: don't retry commands
Date: Tue, 12 May 2020 09:47:49 +0200 [thread overview]
Message-ID: <20200512074749.GD5877@pengutronix.de> (raw)
In-Reply-To: <20200511164957.21930-1-l.stach@pengutronix.de>
On Mon, May 11, 2020 at 06:49:56PM +0200, Lucas Stach wrote:
> No other MCI does retry failing commands on its own (if at all
> this should be done by the MCI core). Remove the retry, as we
> don't want to paper over board level issues.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/mci/stm32_sdmmc2.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mci/stm32_sdmmc2.c b/drivers/mci/stm32_sdmmc2.c
> index 0c26869b0378..de96f0974489 100644
> --- a/drivers/mci/stm32_sdmmc2.c
> +++ b/drivers/mci/stm32_sdmmc2.c
> @@ -481,11 +481,8 @@ static int stm32_sdmmc2_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
> {
> struct stm32_sdmmc2_priv *priv = to_mci_host(mci);
> u32 cmdat = data ? SDMMC_CMD_CMDTRANS : 0;
> - u32 data_length;
> - int ret, retry = 3;
> -
> -retry_cmd:
> - data_length = 0;
> + u32 data_length = 0;
> + int ret;
>
> if (data) {
> data_length = data->blocks * data->blocksize;
> @@ -530,15 +527,6 @@ retry_cmd:
> writel(SDMMC_ICR_STATIC_FLAGS, priv->base + SDMMC_ICR);
> }
>
> - if (ret && retry) {
> - dev_warn(priv->dev, "%s: cmd %d failed, retrying ...\n",
> - __func__, cmd->cmdidx);
> -
> - retry--;
> -
> - goto retry_cmd;
> - }
> -
> dev_dbg(priv->dev, "%s: end for CMD %d, ret = %d\n", __func__,
> cmd->cmdidx, ret);
>
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-05-12 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 16:49 [PATCH 1/2] mci: stm32_sdmmc2: don't retry commands Lucas Stach
2020-05-11 16:49 ` [PATCH 2/2] mci: stm32_sdmmc2: move command timeout errors to debug level Lucas Stach
2020-05-12 7:47 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512074749.GD5877@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.