From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A14C54E4B for ; Tue, 12 May 2020 07:41:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A7BF20733 for ; Tue, 12 May 2020 07:41:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TbQmb6dB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A7BF20733 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ufUaSAoxGAVXUKXpbZl/gq6ENfA8aoO37Sifk478EM=; b=TbQmb6dB57aQgm wa9F+UIHkYXWigWHrsiscrk63qBbTWgLwfv53hZN/tzGKdBKDneUf0pYNhO18SRAFZawK+/JdoAJI XlxV9WVYQ/ez4TtQb/1alu96UW2Mq7ZVuiEv+JoGflBRuZAqTOTHgQ8U5IW+cRUkKqGZ2iVYjUaF3 VveESlJAcg54AFBYpuEPiVpNtdM/5DfCHqZ6RUhIzMJP3Wr3bx7lhN4VGHen+zZ37PvHVYSFmY1G0 IVr/UiT08ntn9Q9BpUKBbirPuOH9Pki0w7vWSQluEsaUSM2XeLW7TJhKQmc4akTdaRrr7YeJK2GXI nBZWOG8Ly5NoVaE7unxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYPXY-0005u7-Re; Tue, 12 May 2020 07:41:24 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYPXV-0005sa-2f for linux-mtd@lists.infradead.org; Tue, 12 May 2020 07:41:22 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 2440920000F; Tue, 12 May 2020 07:41:13 +0000 (UTC) Date: Tue, 12 May 2020 09:41:12 +0200 From: Miquel Raynal To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas Subject: Re: [PATCH v3 2/2] mtd: rawnand: brcmnand: improve hamming oob layout Message-ID: <20200512094112.0b9c3403@xps13> In-Reply-To: <461FD58F-ACD5-4158-BC0B-8C73C53D5C0D@gmail.com> References: <20200504185945.2776148-1-noltari@gmail.com> <20200512060023.684871-1-noltari@gmail.com> <20200512060023.684871-3-noltari@gmail.com> <20200512090844.21bcaf22@xps13> <5377BB9D-35EB-4531-8E03-A7483D3134E4@gmail.com> <20200512091958.0d153319@xps13> <461FD58F-ACD5-4158-BC0B-8C73C53D5C0D@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200512_004121_392698_746167C4 X-CRM114-Status: GOOD ( 23.32 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, kdasu.kdev@gmail.com, richard@nod.at, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, computersforpeace@gmail.com, sumit.semwal@linaro.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgw4FsdmFybywKCsOBbHZhcm8gRmVybsOhbmRleiBSb2phcyA8bm9sdGFyaUBnbWFpbC5jb20+ IHdyb3RlIG9uIFR1ZSwgMTIgTWF5IDIwMjAKMDk6MjY6MjMgKzAyMDA6Cgo+IEhpIE1pcXXDqGws Cj4gCj4gPiBFbCAxMiBtYXkgMjAyMCwgYSBsYXMgOToxOSwgTWlxdWVsIFJheW5hbCA8bWlxdWVs LnJheW5hbEBib290bGluLmNvbT4gZXNjcmliacOzOgo+ID4gCj4gPiBIaSDDgWx2YXJvLAo+ID4g Cj4gPiDDgWx2YXJvIEZlcm7DoW5kZXogUm9qYXMgPG5vbHRhcmlAZ21haWwuY29tPiB3cm90ZSBv biBUdWUsIDEyIE1heSAyMDIwCj4gPiAwOToxMjoxMCArMDIwMDoKPiA+ICAgCj4gPj4gSGkgTWlx dWVsLAo+ID4+IAo+ID4+IEkgYWxzbyBoYWQgYSBoYXJkIHRpbWUgdW5kZXJzdGFuZGluZyB5b3Vy IGVtYWlsLgo+ID4+IEl0IHdhcyBxdWl0ZSBtaXNsZWFkaW5nLgo+ID4+ICAgCj4gPj4+IEVsIDEy IG1heSAyMDIwLCBhIGxhcyA5OjA4LCBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3Rs aW4uY29tPiBlc2NyaWJpw7M6Cj4gPj4+IAo+ID4+PiBIaSDDgWx2YXJvLAo+ID4+PiAKPiA+Pj4g w4FsdmFybyBGZXJuw6FuZGV6IFJvamFzIDxub2x0YXJpQGdtYWlsLmNvbT4gd3JvdGUgb24gVHVl LCAxMiBNYXkgMjAyMAo+ID4+PiAwODowMDoyMyArMDIwMDoKPiA+Pj4gICAKPiA+Pj4+IFRoZSBj dXJyZW50IGNvZGUgZ2VuZXJhdGVzIDggb29iIHNlY3Rpb25zOgo+ID4+Pj4gUzEJMS01Cj4gPj4+ PiBFQ0MJNi04Cj4gPj4+PiBTMgk5LTE1Cj4gPj4+PiBTMwkxNi0yMQo+ID4+Pj4gRUNDCTIyLTI0 Cj4gPj4+PiBTNAkyNS0zMQo+ID4+Pj4gUzUJMzItMzcKPiA+Pj4+IEVDQwkzOC00MAo+ID4+Pj4g UzYJNDEtNDcKPiA+Pj4+IFM3CTQ4LTUzCj4gPj4+PiBFQ0MJNTQtNTYKPiA+Pj4+IFM4CTU3LTYz Cj4gPj4+PiAKPiA+Pj4+IENoYW5nZSBpdCBieSBtZXJnaW5nIGNvbnRpbnVvdXMgc2VjdGlvbnM6 Cj4gPj4+PiBTMQkxLTUKPiA+Pj4+IEVDQwk2LTgKPiA+Pj4+IFMyCTktMjEKPiA+Pj4+IEVDQwky Mi0yNAo+ID4+Pj4gUzMJMjUtMzcKPiA+Pj4+IEVDQwkzOC00MAo+ID4+Pj4gUzQJNDEtNTMKPiA+ Pj4+IEVDQwk1NC01Ngo+ID4+Pj4gUzUJNTctNjMKPiA+Pj4+IAo+ID4+Pj4gRml4ZXM6IGVmNWVl ZWE2ZTkxMSAoIm10ZDogbmFuZDogYnJjbTogc3dpdGNoIHRvIG10ZF9vb2JsYXlvdXRfb3BzIikg ICAgCj4gPj4+IAo+ID4+PiBTb3JyeSBmb3IgbGVhZGluZyB5b3UgdGhlIHdyb25nIHdheSwgYWN0 dWFsbHkgdGhpcyBwYXRjaCBkb2VzIG5vdAo+ID4+PiBkZXNlcnZlIGEgRml4ZXMgdGFnLiAgICAK PiA+PiAKPiA+PiBEbyBJIG5lZWQgdG8gcmVzZW5kIHRoaXMgYWdhaW4/Cj4gPj4gTG9va3MgbGlr ZSBubyBtYXR0ZXIgd2hhdCBJIGRvIGl04oCZcyBhbHdheXMgd3JvbmcuLi4gIAo+ID4gCj4gPiBQ bGVhc2UgZG9uJ3QgZ2l2ZSB1cCEgSXQgaXMgbm9ybWFsIHRvIHdvcmsgYmFjayBhbmQgZm9ydGgg d2l0aCB0aGUKPiA+IGNvbW11bml0eS4gSSBuZWVkIHRoZSBwYXRjaCB0byBiZSBjbGVhciBhbmQg YnVnLWZyZWUgc28gSSBhc2sgeW91IHRvCj4gPiBtYWtlIGNoYW5nZXMgYW5kIGFzayBxdWVzdGlv bnMsIHRoYXQncyBob3cgaXQgd29ya3MuIEJ1dCBhbGwgeW91cgo+ID4gcGF0Y2hlcyBhcmUgZW5o YW5jaW5nIHRoaXMgZHJpdmVyIHNvIHBsZWFzZSBrZWVwIHBvc3RpbmchCj4gPiAgIAo+ID4+ICAg Cj4gPj4+ICAgCj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiDDgWx2YXJvIEZlcm7DoW5kZXogUm9qYXMg PG5vbHRhcmlAZ21haWwuY29tPgo+ID4+Pj4gLS0tCj4gPj4+PiB2MzogaW52ZXJ0IHBhdGNoIG9y ZGVyCj4gPj4+PiB2Mjoga2VlcCBvcmlnaW5hbCBjb21tZW50IGFuZCBmaXggY29ycmVjdGx5IHNr aXAgYnl0ZSA2IGZvciBzbWFsbC1wYWdlIG5hbmQKPiA+Pj4+IAo+ID4+Pj4gZHJpdmVycy9tdGQv bmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYyB8IDM3ICsrKysrKysrKysrKy0tLS0tLS0tLS0t LQo+ID4+Pj4gMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygt KQo+ID4+Pj4gCj4gPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5h bmQvYnJjbW5hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L2JyY21uYW5kL2JyY21uYW5kLmMK PiA+Pj4+IGluZGV4IDFjMTA3MDExMWViYy4uMGExZDc2ZmRlMzdiIDEwMDY0NAo+ID4+Pj4gLS0t IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYwo+ID4+Pj4gKysrIGIv ZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYwo+ID4+Pj4gQEAgLTExMDAs MzMgKzExMDAsMzIgQEAgc3RhdGljIGludCBicmNtbmFuZF9oYW1taW5nX29vYmxheW91dF9mcmVl KHN0cnVjdCBtdGRfaW5mbyAqbXRkLCBpbnQgc2VjdGlvbiwKPiA+Pj4+IAlzdHJ1Y3QgYnJjbW5h bmRfY2ZnICpjZmcgPSAmaG9zdC0+aHdjZmc7Cj4gPj4+PiAJaW50IHNhcyA9IGNmZy0+c3BhcmVf YXJlYV9zaXplIDw8IGNmZy0+c2VjdG9yX3NpemVfMWs7Cj4gPj4+PiAJaW50IHNlY3RvcnMgPSBj ZmctPnBhZ2Vfc2l6ZSAvICg1MTIgPDwgY2ZnLT5zZWN0b3Jfc2l6ZV8xayk7Cj4gPj4+PiArCXUz MiBuZXh0Owo+ID4+Pj4gCj4gPj4+PiAtCWlmIChzZWN0aW9uID49IHNlY3RvcnMgKiAyKQo+ID4+ Pj4gKwlpZiAoc2VjdGlvbiA+IHNlY3RvcnMpCj4gPj4+PiAJCXJldHVybiAtRVJBTkdFOwo+ID4+ Pj4gCj4gPj4+PiAtCW9vYnJlZ2lvbi0+b2Zmc2V0ID0gKHNlY3Rpb24gLyAyKSAqIHNhczsKPiA+ Pj4+ICsJbmV4dCA9IChzZWN0aW9uICogc2FzKTsKPiA+Pj4+ICsJaWYgKHNlY3Rpb24gPCBzZWN0 b3JzKQo+ID4+Pj4gKwkJbmV4dCArPSA2Owo+ID4+Pj4gCj4gPj4+PiAtCWlmIChzZWN0aW9uICYg MSkgewo+ID4+Pj4gLQkJb29icmVnaW9uLT5vZmZzZXQgKz0gOTsKPiA+Pj4+IC0JCW9vYnJlZ2lv bi0+bGVuZ3RoID0gNzsKPiA+Pj4+ICsJaWYgKHNlY3Rpb24pIHsKPiA+Pj4+ICsJCW9vYnJlZ2lv bi0+b2Zmc2V0ID0gKChzZWN0aW9uIC0gMSkgKiBzYXMpICsgOTsKPiA+Pj4+IAl9IGVsc2Ugewo+ ID4+Pj4gLQkJb29icmVnaW9uLT5sZW5ndGggPSA2Owo+ID4+Pj4gLQo+ID4+Pj4gLQkJLyogRmly c3Qgc2VjdG9yIG9mIGVhY2ggcGFnZSBtYXkgaGF2ZSBCQkkgKi8KPiA+Pj4+IC0JCWlmICghc2Vj dGlvbikgewo+ID4+Pj4gLQkJCS8qCj4gPj4+PiAtCQkJICogU21hbGwtcGFnZSBOQU5EIHVzZSBi eXRlIDYgZm9yIEJCSSB3aGlsZSBsYXJnZS1wYWdlCj4gPj4+PiAtCQkJICogTkFORCB1c2UgYnl0 ZXMgMCBhbmQgMS4KPiA+Pj4+IC0JCQkgKi8KPiA+Pj4+IC0JCQlpZiAoY2ZnLT5wYWdlX3NpemUg PiA1MTIpIHsKPiA+Pj4+IC0JCQkJb29icmVnaW9uLT5vZmZzZXQgKz0gMjsKPiA+Pj4+IC0JCQkJ b29icmVnaW9uLT5sZW5ndGggLT0gMjsKPiA+Pj4+IC0JCQl9IGVsc2Ugewo+ID4+Pj4gLQkJCQlv b2JyZWdpb24tPmxlbmd0aC0tOwo+ID4+Pj4gLQkJCX0KPiA+Pj4+ICsJCS8qCj4gPj4+PiArCQkg KiBTbWFsbC1wYWdlIE5BTkQgdXNlIGJ5dGUgNiBmb3IgQkJJIHdoaWxlIGxhcmdlLXBhZ2UKPiA+ Pj4+ICsJCSAqIE5BTkQgdXNlIGJ5dGVzIDAgYW5kIDEuCj4gPj4+PiArCQkgKi8KPiA+Pj4+ICsJ CWlmIChjZmctPnBhZ2Vfc2l6ZSA+IDUxMikgewo+ID4+Pj4gKwkJCW9vYnJlZ2lvbi0+b2Zmc2V0 ID0gMjsKPiA+Pj4+ICsJCX0gZWxzZSB7Cj4gPj4+PiArCQkJb29icmVnaW9uLT5vZmZzZXQgPSAw Owo+ID4+Pj4gKwkJCW5leHQtLTsgICAgCj4gPj4+IAo+ID4+PiBUaGlzIG5leHQtLSBzZWVtcyB2 ZXJ5IHN0cmFuZ2UsIGNhbiB5b3UgZXhwbGFpbj8gICAgCj4gPj4gCj4gPj4gSW4gdGhpcyBjYXNl IG5leHQgd2lsbCBiZSA2ICh3aGljaCBpcyB0aGUgZmlyc3QgRUNDIGJ5dGUpLgo+ID4+IEhvd2V2 ZXIsIGZvciBzbWFsbCBwYWdlIE5BTkRzIGJ5dGUgNSBpcyByZXNlcnZlZCBmb3IgQkJULCBzbyB3 ZSB3YW50IG5leHQgdG8gYmUgNSBvbmx5IGluIHRoaXMgY2FzZS4gIAo+ID4gCj4gPiBUaGF0J3Mg Y2xlYXIsIHBsZWFzZSBhZGQgYSBjb21tZW50IHRoZXJlIHRoZW4uICAKPiAKPiBJc27igJl0IOKA nFNtYWxsLXBhZ2UgTkFORCB1c2UgYnl0ZSA2IGZvciBCQkkgd2hpbGUgbGFyZ2UtcGFnZSBOQU5E IHVzZSBieXRlcyAwIGFuZCAxLuKAnSBlbm91Z2g/Cj4gRG8gd2UgcmVhbGx5IG5lZWQgYSBzcGVj aWZpYyBjb21tZW50IGJlZm9yZSBuZXh0LS0/CgpHaXZlbiB0aGUgdGltZSBpdCB0b29rIG1lIHRv IHVuZGVyc3RhbmQgdGhlc2UgbGluZXMsIEknZCBzYXkgOiAibm8iIDopCgpKdXN0IGdpdmUgbW9y ZSBpbmZvcm1hdGlvbiBpbiB5b3VyIG1haW4gY29tbWVudCwgZXhwbGFpbmluZyB0aGFuIGluIG9u ZQpjYXNlIHRoZSByZXNlcnZlZCBieXRlcyBhcmUgYXQgdGhlIGJlZ2lubmluZyAoZW5sYXJnaW5n IHRoZSBvZmZzZXQpCndoaWxlIGluIHRoZSBvdGhlciBjYXNlIGl0IGlzIGF0IHRoZSBlbmQsIHNv IHJlZHVjaW5nIHRoZSBzZWN0aW9uLgoKPiAKPiA+ICAgCj4gPj4gICAKPiA+Pj4gICAKPiA+Pj4+ IAkJfQo+ID4+Pj4gCX0KPiA+Pj4+IAo+ID4+Pj4gKwlvb2JyZWdpb24tPmxlbmd0aCA9IG5leHQg LSBvb2JyZWdpb24tPm9mZnNldDsKPiA+Pj4+ICsKPiA+Pj4+IAlyZXR1cm4gMDsKPiA+Pj4+IH0K PiA+Pj4+ICAgCj4gPj4+IAo+ID4+PiAKPiA+Pj4gVGhhbmtzLAo+ID4+PiBNaXF1w6hsICAgIAo+ ID4+IAo+ID4+IFJlZ2FyZHMsCj4gPj4gw4FsdmFyby4gIAo+ID4gCj4gPiAKPiA+IAo+ID4gVGhh bmtzLAo+ID4gTWlxdcOobCAgCj4gCj4gUmVnYXJkcywKPiDDgWx2YXJvLgo+IAoKCgoKVGhhbmtz LApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6726ECA90AF for ; Wed, 13 May 2020 09:10:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47DDA20740 for ; Wed, 13 May 2020 09:10:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47DDA20740 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CF686E9D3; Wed, 13 May 2020 09:09:35 +0000 (UTC) Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4233D6E854 for ; Tue, 12 May 2020 07:41:19 +0000 (UTC) Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 2440920000F; Tue, 12 May 2020 07:41:13 +0000 (UTC) Date: Tue, 12 May 2020 09:41:12 +0200 From: Miquel Raynal To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas Subject: Re: [PATCH v3 2/2] mtd: rawnand: brcmnand: improve hamming oob layout Message-ID: <20200512094112.0b9c3403@xps13> In-Reply-To: <461FD58F-ACD5-4158-BC0B-8C73C53D5C0D@gmail.com> References: <20200504185945.2776148-1-noltari@gmail.com> <20200512060023.684871-1-noltari@gmail.com> <20200512060023.684871-3-noltari@gmail.com> <20200512090844.21bcaf22@xps13> <5377BB9D-35EB-4531-8E03-A7483D3134E4@gmail.com> <20200512091958.0d153319@xps13> <461FD58F-ACD5-4158-BC0B-8C73C53D5C0D@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 13 May 2020 09:09:29 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, kdasu.kdev@gmail.com, richard@nod.at, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, computersforpeace@gmail.com, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgw4FsdmFybywKCsOBbHZhcm8gRmVybsOhbmRleiBSb2phcyA8bm9sdGFyaUBnbWFpbC5jb20+ IHdyb3RlIG9uIFR1ZSwgMTIgTWF5IDIwMjAKMDk6MjY6MjMgKzAyMDA6Cgo+IEhpIE1pcXXDqGws Cj4gCj4gPiBFbCAxMiBtYXkgMjAyMCwgYSBsYXMgOToxOSwgTWlxdWVsIFJheW5hbCA8bWlxdWVs LnJheW5hbEBib290bGluLmNvbT4gZXNjcmliacOzOgo+ID4gCj4gPiBIaSDDgWx2YXJvLAo+ID4g Cj4gPiDDgWx2YXJvIEZlcm7DoW5kZXogUm9qYXMgPG5vbHRhcmlAZ21haWwuY29tPiB3cm90ZSBv biBUdWUsIDEyIE1heSAyMDIwCj4gPiAwOToxMjoxMCArMDIwMDoKPiA+ICAgCj4gPj4gSGkgTWlx dWVsLAo+ID4+IAo+ID4+IEkgYWxzbyBoYWQgYSBoYXJkIHRpbWUgdW5kZXJzdGFuZGluZyB5b3Vy IGVtYWlsLgo+ID4+IEl0IHdhcyBxdWl0ZSBtaXNsZWFkaW5nLgo+ID4+ICAgCj4gPj4+IEVsIDEy IG1heSAyMDIwLCBhIGxhcyA5OjA4LCBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3Rs aW4uY29tPiBlc2NyaWJpw7M6Cj4gPj4+IAo+ID4+PiBIaSDDgWx2YXJvLAo+ID4+PiAKPiA+Pj4g w4FsdmFybyBGZXJuw6FuZGV6IFJvamFzIDxub2x0YXJpQGdtYWlsLmNvbT4gd3JvdGUgb24gVHVl LCAxMiBNYXkgMjAyMAo+ID4+PiAwODowMDoyMyArMDIwMDoKPiA+Pj4gICAKPiA+Pj4+IFRoZSBj dXJyZW50IGNvZGUgZ2VuZXJhdGVzIDggb29iIHNlY3Rpb25zOgo+ID4+Pj4gUzEJMS01Cj4gPj4+ PiBFQ0MJNi04Cj4gPj4+PiBTMgk5LTE1Cj4gPj4+PiBTMwkxNi0yMQo+ID4+Pj4gRUNDCTIyLTI0 Cj4gPj4+PiBTNAkyNS0zMQo+ID4+Pj4gUzUJMzItMzcKPiA+Pj4+IEVDQwkzOC00MAo+ID4+Pj4g UzYJNDEtNDcKPiA+Pj4+IFM3CTQ4LTUzCj4gPj4+PiBFQ0MJNTQtNTYKPiA+Pj4+IFM4CTU3LTYz Cj4gPj4+PiAKPiA+Pj4+IENoYW5nZSBpdCBieSBtZXJnaW5nIGNvbnRpbnVvdXMgc2VjdGlvbnM6 Cj4gPj4+PiBTMQkxLTUKPiA+Pj4+IEVDQwk2LTgKPiA+Pj4+IFMyCTktMjEKPiA+Pj4+IEVDQwky Mi0yNAo+ID4+Pj4gUzMJMjUtMzcKPiA+Pj4+IEVDQwkzOC00MAo+ID4+Pj4gUzQJNDEtNTMKPiA+ Pj4+IEVDQwk1NC01Ngo+ID4+Pj4gUzUJNTctNjMKPiA+Pj4+IAo+ID4+Pj4gRml4ZXM6IGVmNWVl ZWE2ZTkxMSAoIm10ZDogbmFuZDogYnJjbTogc3dpdGNoIHRvIG10ZF9vb2JsYXlvdXRfb3BzIikg ICAgCj4gPj4+IAo+ID4+PiBTb3JyeSBmb3IgbGVhZGluZyB5b3UgdGhlIHdyb25nIHdheSwgYWN0 dWFsbHkgdGhpcyBwYXRjaCBkb2VzIG5vdAo+ID4+PiBkZXNlcnZlIGEgRml4ZXMgdGFnLiAgICAK PiA+PiAKPiA+PiBEbyBJIG5lZWQgdG8gcmVzZW5kIHRoaXMgYWdhaW4/Cj4gPj4gTG9va3MgbGlr ZSBubyBtYXR0ZXIgd2hhdCBJIGRvIGl04oCZcyBhbHdheXMgd3JvbmcuLi4gIAo+ID4gCj4gPiBQ bGVhc2UgZG9uJ3QgZ2l2ZSB1cCEgSXQgaXMgbm9ybWFsIHRvIHdvcmsgYmFjayBhbmQgZm9ydGgg d2l0aCB0aGUKPiA+IGNvbW11bml0eS4gSSBuZWVkIHRoZSBwYXRjaCB0byBiZSBjbGVhciBhbmQg YnVnLWZyZWUgc28gSSBhc2sgeW91IHRvCj4gPiBtYWtlIGNoYW5nZXMgYW5kIGFzayBxdWVzdGlv bnMsIHRoYXQncyBob3cgaXQgd29ya3MuIEJ1dCBhbGwgeW91cgo+ID4gcGF0Y2hlcyBhcmUgZW5o YW5jaW5nIHRoaXMgZHJpdmVyIHNvIHBsZWFzZSBrZWVwIHBvc3RpbmchCj4gPiAgIAo+ID4+ICAg Cj4gPj4+ICAgCj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiDDgWx2YXJvIEZlcm7DoW5kZXogUm9qYXMg PG5vbHRhcmlAZ21haWwuY29tPgo+ID4+Pj4gLS0tCj4gPj4+PiB2MzogaW52ZXJ0IHBhdGNoIG9y ZGVyCj4gPj4+PiB2Mjoga2VlcCBvcmlnaW5hbCBjb21tZW50IGFuZCBmaXggY29ycmVjdGx5IHNr aXAgYnl0ZSA2IGZvciBzbWFsbC1wYWdlIG5hbmQKPiA+Pj4+IAo+ID4+Pj4gZHJpdmVycy9tdGQv bmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYyB8IDM3ICsrKysrKysrKysrKy0tLS0tLS0tLS0t LQo+ID4+Pj4gMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygt KQo+ID4+Pj4gCj4gPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5h bmQvYnJjbW5hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L2JyY21uYW5kL2JyY21uYW5kLmMK PiA+Pj4+IGluZGV4IDFjMTA3MDExMWViYy4uMGExZDc2ZmRlMzdiIDEwMDY0NAo+ID4+Pj4gLS0t IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYwo+ID4+Pj4gKysrIGIv ZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYwo+ID4+Pj4gQEAgLTExMDAs MzMgKzExMDAsMzIgQEAgc3RhdGljIGludCBicmNtbmFuZF9oYW1taW5nX29vYmxheW91dF9mcmVl KHN0cnVjdCBtdGRfaW5mbyAqbXRkLCBpbnQgc2VjdGlvbiwKPiA+Pj4+IAlzdHJ1Y3QgYnJjbW5h bmRfY2ZnICpjZmcgPSAmaG9zdC0+aHdjZmc7Cj4gPj4+PiAJaW50IHNhcyA9IGNmZy0+c3BhcmVf YXJlYV9zaXplIDw8IGNmZy0+c2VjdG9yX3NpemVfMWs7Cj4gPj4+PiAJaW50IHNlY3RvcnMgPSBj ZmctPnBhZ2Vfc2l6ZSAvICg1MTIgPDwgY2ZnLT5zZWN0b3Jfc2l6ZV8xayk7Cj4gPj4+PiArCXUz MiBuZXh0Owo+ID4+Pj4gCj4gPj4+PiAtCWlmIChzZWN0aW9uID49IHNlY3RvcnMgKiAyKQo+ID4+ Pj4gKwlpZiAoc2VjdGlvbiA+IHNlY3RvcnMpCj4gPj4+PiAJCXJldHVybiAtRVJBTkdFOwo+ID4+ Pj4gCj4gPj4+PiAtCW9vYnJlZ2lvbi0+b2Zmc2V0ID0gKHNlY3Rpb24gLyAyKSAqIHNhczsKPiA+ Pj4+ICsJbmV4dCA9IChzZWN0aW9uICogc2FzKTsKPiA+Pj4+ICsJaWYgKHNlY3Rpb24gPCBzZWN0 b3JzKQo+ID4+Pj4gKwkJbmV4dCArPSA2Owo+ID4+Pj4gCj4gPj4+PiAtCWlmIChzZWN0aW9uICYg MSkgewo+ID4+Pj4gLQkJb29icmVnaW9uLT5vZmZzZXQgKz0gOTsKPiA+Pj4+IC0JCW9vYnJlZ2lv bi0+bGVuZ3RoID0gNzsKPiA+Pj4+ICsJaWYgKHNlY3Rpb24pIHsKPiA+Pj4+ICsJCW9vYnJlZ2lv bi0+b2Zmc2V0ID0gKChzZWN0aW9uIC0gMSkgKiBzYXMpICsgOTsKPiA+Pj4+IAl9IGVsc2Ugewo+ ID4+Pj4gLQkJb29icmVnaW9uLT5sZW5ndGggPSA2Owo+ID4+Pj4gLQo+ID4+Pj4gLQkJLyogRmly c3Qgc2VjdG9yIG9mIGVhY2ggcGFnZSBtYXkgaGF2ZSBCQkkgKi8KPiA+Pj4+IC0JCWlmICghc2Vj dGlvbikgewo+ID4+Pj4gLQkJCS8qCj4gPj4+PiAtCQkJICogU21hbGwtcGFnZSBOQU5EIHVzZSBi eXRlIDYgZm9yIEJCSSB3aGlsZSBsYXJnZS1wYWdlCj4gPj4+PiAtCQkJICogTkFORCB1c2UgYnl0 ZXMgMCBhbmQgMS4KPiA+Pj4+IC0JCQkgKi8KPiA+Pj4+IC0JCQlpZiAoY2ZnLT5wYWdlX3NpemUg PiA1MTIpIHsKPiA+Pj4+IC0JCQkJb29icmVnaW9uLT5vZmZzZXQgKz0gMjsKPiA+Pj4+IC0JCQkJ b29icmVnaW9uLT5sZW5ndGggLT0gMjsKPiA+Pj4+IC0JCQl9IGVsc2Ugewo+ID4+Pj4gLQkJCQlv b2JyZWdpb24tPmxlbmd0aC0tOwo+ID4+Pj4gLQkJCX0KPiA+Pj4+ICsJCS8qCj4gPj4+PiArCQkg KiBTbWFsbC1wYWdlIE5BTkQgdXNlIGJ5dGUgNiBmb3IgQkJJIHdoaWxlIGxhcmdlLXBhZ2UKPiA+ Pj4+ICsJCSAqIE5BTkQgdXNlIGJ5dGVzIDAgYW5kIDEuCj4gPj4+PiArCQkgKi8KPiA+Pj4+ICsJ CWlmIChjZmctPnBhZ2Vfc2l6ZSA+IDUxMikgewo+ID4+Pj4gKwkJCW9vYnJlZ2lvbi0+b2Zmc2V0 ID0gMjsKPiA+Pj4+ICsJCX0gZWxzZSB7Cj4gPj4+PiArCQkJb29icmVnaW9uLT5vZmZzZXQgPSAw Owo+ID4+Pj4gKwkJCW5leHQtLTsgICAgCj4gPj4+IAo+ID4+PiBUaGlzIG5leHQtLSBzZWVtcyB2 ZXJ5IHN0cmFuZ2UsIGNhbiB5b3UgZXhwbGFpbj8gICAgCj4gPj4gCj4gPj4gSW4gdGhpcyBjYXNl IG5leHQgd2lsbCBiZSA2ICh3aGljaCBpcyB0aGUgZmlyc3QgRUNDIGJ5dGUpLgo+ID4+IEhvd2V2 ZXIsIGZvciBzbWFsbCBwYWdlIE5BTkRzIGJ5dGUgNSBpcyByZXNlcnZlZCBmb3IgQkJULCBzbyB3 ZSB3YW50IG5leHQgdG8gYmUgNSBvbmx5IGluIHRoaXMgY2FzZS4gIAo+ID4gCj4gPiBUaGF0J3Mg Y2xlYXIsIHBsZWFzZSBhZGQgYSBjb21tZW50IHRoZXJlIHRoZW4uICAKPiAKPiBJc27igJl0IOKA nFNtYWxsLXBhZ2UgTkFORCB1c2UgYnl0ZSA2IGZvciBCQkkgd2hpbGUgbGFyZ2UtcGFnZSBOQU5E IHVzZSBieXRlcyAwIGFuZCAxLuKAnSBlbm91Z2g/Cj4gRG8gd2UgcmVhbGx5IG5lZWQgYSBzcGVj aWZpYyBjb21tZW50IGJlZm9yZSBuZXh0LS0/CgpHaXZlbiB0aGUgdGltZSBpdCB0b29rIG1lIHRv IHVuZGVyc3RhbmQgdGhlc2UgbGluZXMsIEknZCBzYXkgOiAibm8iIDopCgpKdXN0IGdpdmUgbW9y ZSBpbmZvcm1hdGlvbiBpbiB5b3VyIG1haW4gY29tbWVudCwgZXhwbGFpbmluZyB0aGFuIGluIG9u ZQpjYXNlIHRoZSByZXNlcnZlZCBieXRlcyBhcmUgYXQgdGhlIGJlZ2lubmluZyAoZW5sYXJnaW5n IHRoZSBvZmZzZXQpCndoaWxlIGluIHRoZSBvdGhlciBjYXNlIGl0IGlzIGF0IHRoZSBlbmQsIHNv IHJlZHVjaW5nIHRoZSBzZWN0aW9uLgoKPiAKPiA+ICAgCj4gPj4gICAKPiA+Pj4gICAKPiA+Pj4+ IAkJfQo+ID4+Pj4gCX0KPiA+Pj4+IAo+ID4+Pj4gKwlvb2JyZWdpb24tPmxlbmd0aCA9IG5leHQg LSBvb2JyZWdpb24tPm9mZnNldDsKPiA+Pj4+ICsKPiA+Pj4+IAlyZXR1cm4gMDsKPiA+Pj4+IH0K PiA+Pj4+ICAgCj4gPj4+IAo+ID4+PiAKPiA+Pj4gVGhhbmtzLAo+ID4+PiBNaXF1w6hsICAgIAo+ ID4+IAo+ID4+IFJlZ2FyZHMsCj4gPj4gw4FsdmFyby4gIAo+ID4gCj4gPiAKPiA+IAo+ID4gVGhh bmtzLAo+ID4gTWlxdcOobCAgCj4gCj4gUmVnYXJkcywKPiDDgWx2YXJvLgo+IAoKCgoKVGhhbmtz LApNaXF1w6hsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 253AAC54E8B for ; Tue, 12 May 2020 07:41:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F2BE2075E for ; Tue, 12 May 2020 07:41:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726008AbgELHlU convert rfc822-to-8bit (ORCPT ); Tue, 12 May 2020 03:41:20 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:59683 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbgELHlU (ORCPT ); Tue, 12 May 2020 03:41:20 -0400 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 2440920000F; Tue, 12 May 2020 07:41:13 +0000 (UTC) Date: Tue, 12 May 2020 09:41:12 +0200 From: Miquel Raynal To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas Cc: computersforpeace@gmail.com, kdasu.kdev@gmail.com, richard@nod.at, vigneshr@ti.com, sumit.semwal@linaro.org, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v3 2/2] mtd: rawnand: brcmnand: improve hamming oob layout Message-ID: <20200512094112.0b9c3403@xps13> In-Reply-To: <461FD58F-ACD5-4158-BC0B-8C73C53D5C0D@gmail.com> References: <20200504185945.2776148-1-noltari@gmail.com> <20200512060023.684871-1-noltari@gmail.com> <20200512060023.684871-3-noltari@gmail.com> <20200512090844.21bcaf22@xps13> <5377BB9D-35EB-4531-8E03-A7483D3134E4@gmail.com> <20200512091958.0d153319@xps13> <461FD58F-ACD5-4158-BC0B-8C73C53D5C0D@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Álvaro, Álvaro Fernández Rojas wrote on Tue, 12 May 2020 09:26:23 +0200: > Hi Miquèl, > > > El 12 may 2020, a las 9:19, Miquel Raynal escribió: > > > > Hi Álvaro, > > > > Álvaro Fernández Rojas wrote on Tue, 12 May 2020 > > 09:12:10 +0200: > > > >> Hi Miquel, > >> > >> I also had a hard time understanding your email. > >> It was quite misleading. > >> > >>> El 12 may 2020, a las 9:08, Miquel Raynal escribió: > >>> > >>> Hi Álvaro, > >>> > >>> Álvaro Fernández Rojas wrote on Tue, 12 May 2020 > >>> 08:00:23 +0200: > >>> > >>>> The current code generates 8 oob sections: > >>>> S1 1-5 > >>>> ECC 6-8 > >>>> S2 9-15 > >>>> S3 16-21 > >>>> ECC 22-24 > >>>> S4 25-31 > >>>> S5 32-37 > >>>> ECC 38-40 > >>>> S6 41-47 > >>>> S7 48-53 > >>>> ECC 54-56 > >>>> S8 57-63 > >>>> > >>>> Change it by merging continuous sections: > >>>> S1 1-5 > >>>> ECC 6-8 > >>>> S2 9-21 > >>>> ECC 22-24 > >>>> S3 25-37 > >>>> ECC 38-40 > >>>> S4 41-53 > >>>> ECC 54-56 > >>>> S5 57-63 > >>>> > >>>> Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops") > >>> > >>> Sorry for leading you the wrong way, actually this patch does not > >>> deserve a Fixes tag. > >> > >> Do I need to resend this again? > >> Looks like no matter what I do it’s always wrong... > > > > Please don't give up! It is normal to work back and forth with the > > community. I need the patch to be clear and bug-free so I ask you to > > make changes and ask questions, that's how it works. But all your > > patches are enhancing this driver so please keep posting! > > > >> > >>> > >>>> Signed-off-by: Álvaro Fernández Rojas > >>>> --- > >>>> v3: invert patch order > >>>> v2: keep original comment and fix correctly skip byte 6 for small-page nand > >>>> > >>>> drivers/mtd/nand/raw/brcmnand/brcmnand.c | 37 ++++++++++++------------ > >>>> 1 file changed, 18 insertions(+), 19 deletions(-) > >>>> > >>>> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > >>>> index 1c1070111ebc..0a1d76fde37b 100644 > >>>> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > >>>> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > >>>> @@ -1100,33 +1100,32 @@ static int brcmnand_hamming_ooblayout_free(struct mtd_info *mtd, int section, > >>>> struct brcmnand_cfg *cfg = &host->hwcfg; > >>>> int sas = cfg->spare_area_size << cfg->sector_size_1k; > >>>> int sectors = cfg->page_size / (512 << cfg->sector_size_1k); > >>>> + u32 next; > >>>> > >>>> - if (section >= sectors * 2) > >>>> + if (section > sectors) > >>>> return -ERANGE; > >>>> > >>>> - oobregion->offset = (section / 2) * sas; > >>>> + next = (section * sas); > >>>> + if (section < sectors) > >>>> + next += 6; > >>>> > >>>> - if (section & 1) { > >>>> - oobregion->offset += 9; > >>>> - oobregion->length = 7; > >>>> + if (section) { > >>>> + oobregion->offset = ((section - 1) * sas) + 9; > >>>> } else { > >>>> - oobregion->length = 6; > >>>> - > >>>> - /* First sector of each page may have BBI */ > >>>> - if (!section) { > >>>> - /* > >>>> - * Small-page NAND use byte 6 for BBI while large-page > >>>> - * NAND use bytes 0 and 1. > >>>> - */ > >>>> - if (cfg->page_size > 512) { > >>>> - oobregion->offset += 2; > >>>> - oobregion->length -= 2; > >>>> - } else { > >>>> - oobregion->length--; > >>>> - } > >>>> + /* > >>>> + * Small-page NAND use byte 6 for BBI while large-page > >>>> + * NAND use bytes 0 and 1. > >>>> + */ > >>>> + if (cfg->page_size > 512) { > >>>> + oobregion->offset = 2; > >>>> + } else { > >>>> + oobregion->offset = 0; > >>>> + next--; > >>> > >>> This next-- seems very strange, can you explain? > >> > >> In this case next will be 6 (which is the first ECC byte). > >> However, for small page NANDs byte 5 is reserved for BBT, so we want next to be 5 only in this case. > > > > That's clear, please add a comment there then. > > Isn’t “Small-page NAND use byte 6 for BBI while large-page NAND use bytes 0 and 1.” enough? > Do we really need a specific comment before next--? Given the time it took me to understand these lines, I'd say : "no" :) Just give more information in your main comment, explaining than in one case the reserved bytes are at the beginning (enlarging the offset) while in the other case it is at the end, so reducing the section. > > > > >> > >>> > >>>> } > >>>> } > >>>> > >>>> + oobregion->length = next - oobregion->offset; > >>>> + > >>>> return 0; > >>>> } > >>>> > >>> > >>> > >>> Thanks, > >>> Miquèl > >> > >> Regards, > >> Álvaro. > > > > > > > > Thanks, > > Miquèl > > Regards, > Álvaro. > Thanks, Miquèl