From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrea.Ho@advantech.com.tw,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Thomas Gleixner <tglx@linutronix.de>,
Maximilian Luz <luzmaximilian@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
voyandrea@gmail.com, amy.shih@advantech.com.tw,
oakley.ding@advantech.com.tw, HY.Lee@advantech.com.tw
Subject: Re: [V3,1/1] Input/misc: add support for Advantech software defined button
Date: Tue, 12 May 2020 12:15:11 +0200 [thread overview]
Message-ID: <20200512101511.GA3991701@kroah.com> (raw)
In-Reply-To: <CAK8P3a1gKHir-hVoX_mFzqcOF=9NfM1NqO96kC-=6ZHf6Lojdg@mail.gmail.com>
On Tue, May 12, 2020 at 12:08:08PM +0200, Arnd Bergmann wrote:
> > +MODULE_LICENSE("GPL");
>
> These generally go at the bottom of the file.
>
> The license tag here does not match the one in the SPDX header, after
> you changed the other one to v2-only.
Yes it does, they mean the same thing, see modules.h for the details if
you are curious.
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-12 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200512043149.10719-1-Andrea.Ho@advantech.com.tw>
2020-05-12 10:08 ` [V3,1/1] Input/misc: add support for Advantech software defined button Arnd Bergmann
2020-05-12 10:15 ` Greg Kroah-Hartman [this message]
2020-05-12 10:28 ` Arnd Bergmann
2020-03-04 2:24 Andrea Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512101511.GA3991701@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Andrea.Ho@advantech.com.tw \
--cc=HY.Lee@advantech.com.tw \
--cc=amy.shih@advantech.com.tw \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=oakley.ding@advantech.com.tw \
--cc=tglx@linutronix.de \
--cc=voyandrea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.