From: Wolfram Sang <wsa@kernel.org>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 2/4] i2c: pxa: avoid complaints with non-responsive slaves
Date: Tue, 12 May 2020 12:35:14 +0200 [thread overview]
Message-ID: <20200512103514.GC1393@ninjato> (raw)
In-Reply-To: <E1jYFh2-0007K5-ET@rmk-PC.armlinux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Mon, May 11, 2020 at 10:10:32PM +0100, Russell King wrote:
> Running i2cdetect on a PXA I2C adapter is very noisy; it complains
> whenever a slave fails to respond to the address cycle. Since it is
> normal to probe for slaves in this way, we should not fill the kernel
> log. This is especially true with SFP modules that take a while to
> respond on the I2C bus, and probing via the I2C bus is the only way to
> detect that they are ready.
>
> Fix this by changing the internal transfer return code from I2C_RETRY
> to a new NO_SLAVE code (mapped to -ENXIO, as per the I2C documentation
> for this condition, but we still return -EREMOTEIO to the I2C stack to
> maintain long established driver behaviour.)
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-12 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 21:09 [PATCH v2 0/4] Further i2c-pxa cleanups Russell King - ARM Linux admin
2020-05-11 21:10 ` [PATCH v2 1/4] i2c: pxa: consolidate i2c_pxa_*xfer() implementations Russell King
2020-05-12 10:35 ` Wolfram Sang
2020-05-11 21:10 ` [PATCH v2 2/4] i2c: pxa: avoid complaints with non-responsive slaves Russell King
2020-05-12 10:35 ` Wolfram Sang [this message]
2020-05-11 21:10 ` [PATCH v2 3/4] i2c: pxa: ensure timeout messages are unique Russell King
2020-05-12 10:35 ` Wolfram Sang
2020-05-11 21:10 ` [PATCH v2 4/4] i2c: pxa: remove some unnecessary debug Russell King
2020-05-12 10:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512103514.GC1393@ninjato \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.