From: Wolfram Sang <wsa@kernel.org>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: pxa: clear all master action bits in i2c_pxa_stop_message()
Date: Tue, 12 May 2020 12:38:53 +0200 [thread overview]
Message-ID: <20200512103853.GF1393@ninjato> (raw)
In-Reply-To: <E1jWGTm-0000VI-N1@rmk-PC.armlinux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On Wed, May 06, 2020 at 10:36:38AM +0100, Russell King wrote:
> If we timeout during a message transfer, the control register may
> contain bits that cause an action to be set. Read-modify-writing the
> register leaving these bits set may trigger the hardware to attempt
> one of these actions unintentionally.
>
> Always clear these bits when cleaning up after a message or after
> a timeout.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied to for-next, thanks! I was considering for-current, though, but
there have been no real bug reports, so for-next it is.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-12 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 9:36 [PATCH 0/2] Use master-abort for slave probes Russell King - ARM Linux admin
2020-05-06 9:36 ` [PATCH 1/2] i2c: pxa: clear all master action bits in i2c_pxa_stop_message() Russell King
2020-05-12 10:38 ` Wolfram Sang [this message]
2020-05-06 9:36 ` [PATCH 2/2] i2c: pxa: use master-abort for device probes Russell King
2020-05-12 10:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512103853.GF1393@ninjato \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.