From: Rob Herring <robh@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: lee.jones@linaro.org, broonie@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, jdelvare@suse.com,
linux@roeck-us.net, linus.walleij@linaro.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v2 5/5] mfd: lochnagar: Move binding over to dtschema
Date: Tue, 12 May 2020 08:49:49 -0500 [thread overview]
Message-ID: <20200512134949.GA14057@bogus> (raw)
In-Reply-To: <20200504154757.17519-5-ckeepax@opensource.cirrus.com>
On Mon, May 04, 2020 at 04:47:57PM +0100, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>
> Changes since v1:
> - Removed contains on the compatible
> - Moved all sub-nodes into here directly only using $ref for properties
> - As the regulator binding only contained subnodes that file is now deleted
> - Removed some pointless descriptions
>
> A little nervous about the amount of clock and regulator stuff this
> pulls into the MFD file, any comments on that welcome? Would it be worth
> looking into something along the lines of the definitions stuff to keep
> some of that out in the clock and regulator bindings?
It's fine like this. Other than my comments on patch 3, looks fine.
Respin and I'll apply.
>
> Thanks,
> Charles
>
> .../devicetree/bindings/mfd/cirrus,lochnagar.txt | 85 -----
> .../devicetree/bindings/mfd/cirrus,lochnagar.yaml | 352 +++++++++++++++++++++
> .../bindings/regulator/cirrus,lochnagar.txt | 82 -----
> MAINTAINERS | 11 +-
> 4 files changed, 357 insertions(+), 173 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/cirrus,lochnagar.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/cirrus,lochnagar.txt
next prev parent reply other threads:[~2020-05-12 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 15:47 [PATCH v2 1/5] hwmon: lochnagar: Move binding over to dtschema Charles Keepax
2020-05-04 15:47 ` [PATCH v2 2/5] ASoC: " Charles Keepax
2020-05-04 15:47 ` [PATCH v2 3/5] pinctrl: " Charles Keepax
2020-05-12 13:06 ` Linus Walleij
2020-05-12 13:33 ` Rob Herring
2020-05-12 13:44 ` Rob Herring
2020-05-04 15:47 ` [PATCH v2 4/5] clk: " Charles Keepax
2020-05-04 15:47 ` [PATCH v2 5/5] mfd: " Charles Keepax
2020-05-12 13:49 ` Rob Herring [this message]
2020-05-12 15:06 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512134949.GA14057@bogus \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.cirrus.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.