All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f
Date: Tue, 12 May 2020 18:46:01 +0800	[thread overview]
Message-ID: <20200512184601.40b1758a@xhacker.debian> (raw)

The PHY Register Accessible Interrupt is enabled by default, so
there's such an interrupt during init. In PHY POLL mode case, the
INTB/PMEB pin is alway active, it is not good. Clear the interrupt by
calling rtl8211f_ack_interrupt().

Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
---
 drivers/net/phy/realtek.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 2d99e9de6ee1..398607268a3c 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -179,6 +179,10 @@ static int rtl8211f_config_init(struct phy_device *phydev)
 	u16 val_txdly, val_rxdly;
 	int ret;
 
+	ret = rtl8211f_ack_interrupt(phydev);
+	if (ret < 0)
+		return ret;
+
 	switch (phydev->interface) {
 	case PHY_INTERFACE_MODE_RGMII:
 		val_txdly = 0;
-- 
2.26.2


             reply	other threads:[~2020-05-12 10:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 10:46 Jisheng Zhang [this message]
2020-05-12 18:43 ` [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f Heiner Kallweit
2020-05-13  6:51   ` Jisheng Zhang
2020-05-13 18:45     ` Heiner Kallweit
2020-05-14  6:25       ` Jisheng Zhang
2020-05-14 19:50         ` Heiner Kallweit
2020-05-15  7:41           ` Jisheng Zhang
2020-05-15 16:18             ` Florian Fainelli
2020-05-15 17:30               ` Heiner Kallweit
2020-06-17  9:09                 ` Jisheng Zhang
2020-06-21 20:16                   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512184601.40b1758a@xhacker.debian \
    --to=jisheng.zhang@synaptics.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.