From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jYqpu-0007Ka-58 for mharc-grub-devel@gnu.org; Wed, 13 May 2020 08:50:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYqps-0007Gm-Kd for grub-devel@gnu.org; Wed, 13 May 2020 08:50:08 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:41310) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYqpo-0000RC-5e for grub-devel@gnu.org; Wed, 13 May 2020 08:50:08 -0400 Received: by mail-wr1-x442.google.com with SMTP id h17so11840847wrc.8 for ; Wed, 13 May 2020 05:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=m8aMfIJEWvGyD5f5aL3dT2mqgXdqWQt1BtZDyaCb52Y=; b=ZbLmxuuK2ABbjqjlyAKgv821yixVZ7FQ9SBPUoJKm9VmuStqUOWMaInjPpUz71v+QB wH7cVM2jFUIgUpW5/Il7EQH1K591uciXqh5uTf07SXGppQ+XF8Y3lYORq7ZvpVjb4kg5 jVYnwoiMp8VMCRCZMUNtYL4+vxfAMscvuJWPcZR/yyuIAYx/l+H2EugfrQ5VFIKDwkVf qt4eEQjSLngn0GnVf2yULq+mnwCsHRPpwm27JiCokRKXkmN4oJvyfHS1xkV69VGTZr+5 1DHn3UaAtjQEoRuYxhCWKt/PzY5IaJvbfv5LrPwfM+JzOXFypyGBFM+iLcxlex3tSCYv pLhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=m8aMfIJEWvGyD5f5aL3dT2mqgXdqWQt1BtZDyaCb52Y=; b=YEsW8epEGw7YWvo5I56Y2JZ81SAdBZsAAkP2QolJTPMnRieIABqeRQofAfgDMHfp+e Epy9kUXIo7n45s2eTEDsZ2hzwEVU/Lsen1SwBRMj4bfYK9b5A6fk0ziF1gCf6iCFD1qQ WJNuVMqma+ThIvFPCVOvB3ZRJX7OZHgFPLDubd9QnIbMpZZGNgCUKbTc0rxLk9XBn7Cd NMh48n+wZs2dw1WwD0Boqnqb5STVZeoIsQitvAcNG30WhGtWy6Lz2cTvcRVS6JeJSZwX CmBZpxQqnSj5pSCmcPgmWyHg1gE2YK2nxyDu7H6rix6zIOB4U7BhEvJ8H6FKGNvYQi0R Aq8g== X-Gm-Message-State: AOAM531XYVQjaYS+mFqL1ngq+ttW4j1wgItu352/rJMU+BYGvgtxslTP JyBn6g+KRPbjBuRBi/uOieS3dw== X-Google-Smtp-Source: ABdhPJxXLnpgkpc+iRLh4Ez0Q9IZRin3koXxKXfK6YEF4DX1U0EpC6QMbMyVLx1L9i1HhJ0S6FNFIA== X-Received: by 2002:a5d:504b:: with SMTP id h11mr1289461wrt.85.1589374201922; Wed, 13 May 2020 05:50:01 -0700 (PDT) Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id n25sm36554426wmk.9.2020.05.13.05.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2020 05:50:01 -0700 (PDT) Date: Wed, 13 May 2020 13:49:59 +0100 From: Leif Lindholm To: Daniel Kiper Cc: grub-devel@gnu.org, eschwartz@archlinux.org, floppym@gentoo.org, glaubitz@physik.fu-berlin.de, javierm@redhat.com, olaf@aepfle.de, phcoder@gmail.com, pjones@redhat.com Subject: Re: [PATCH v3 0/5] Various build and doc fixes Message-ID: <20200513124959.GP21486@vanye> References: <20200513120251.9861-1-daniel.kiper@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513120251.9861-1-daniel.kiper@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=leif@nuviainc.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2020 12:50:08 -0000 On Wed, May 13, 2020 at 14:02:46 +0200, Daniel Kiper wrote: > Hey, > > As in subject... Please review... Hi Daniel, This looks good to me. For the series: Reviewed-by: Leif Lindholm > Daniel > > INSTALL | 47 +++++++++++++++++++++++++++++++---------------- > autogen.sh | 2 +- > configure.ac | 19 ++++++++++++++----- > 3 files changed, 46 insertions(+), 22 deletions(-) > > Daniel Kiper (5): > configure: Drop unneeded TARGET_CFLAGS expansion > configure: Set gnu99 C language standard by default > INSTALL/configure: Update install doc and configure comment > INSTALL: Update configure example > autogen: Replace -iname with -ipath in find command >