From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls: Fix issues around calling syscalls with old timespec
Date: Wed, 13 May 2020 14:54:28 +0200 [thread overview]
Message-ID: <20200513125428.GA15868@dell5510> (raw)
In-Reply-To: <20200513114239.roy5hqu26lm2of4l@vireshk-i7>
Hi Viresh,
> > > #ifndef __kernel_timex
> > > +#if defined(__x86_64__) && defined(__ILP32__)
> > > +typedef long long __kernel_long_t;
> > > +#else
> > > +typedef long __kernel_long_t;
> > > +#endif
> > > +
> > > +typedef __kernel_long_t __kernel_old_time_t;
> > It's caused by this fallback definition ^, which is already in
> > include/tst_timer.h. Simple deleting it should fix the problem
> But tst_timer.h isn't included here in clock_adjtime at all. What's
tst_timer.h has been included in clock_adjtime.h since 5085e14c7e
> special with Centos that failure is seen there only ?
> Any idea ?
Not sure why it's only for old CentOS 6. Usually there is some bug in the
headers (conflicting headers which has been fixed in newer distros) or something
simply missing.
And we should really drop CentOS 6 from travis CI, we agreed to discontinue gcc
4 support (10 years old). But I wanted to drop it after the release.
BTW typedef long long __kernel_long_t; is in <asm/posix_types_x32.h>
which you include via <asm/posix_types.h>. But redefining typedef is not a
problem.
Kind regards,
Petr
next prev parent reply other threads:[~2020-05-13 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 9:45 [LTP] [PATCH] syscalls: Fix issues around calling syscalls with old timespec Viresh Kumar
2020-05-13 11:33 ` Petr Vorel
2020-05-13 11:42 ` Viresh Kumar
2020-05-13 12:54 ` Petr Vorel [this message]
2020-05-14 5:38 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513125428.GA15868@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.