From: Kalle Valo <kvalo@codeaurora.org>
To: <yhchuang@realtek.com>
Cc: <linux-wireless@vger.kernel.org>, <pkshih@realtek.com>,
<bigeasy@linutronix.de>, <kevin_yang@realtek.com>,
<briannorris@chromium.org>
Subject: Re: [PATCH v3 1/7] rtw88: extract: export symbols used in chip functionalities
Date: Wed, 13 May 2020 15:51:08 +0000 (UTC) [thread overview]
Message-ID: <20200513155108.596DEC433F2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200512103120.5280-2-yhchuang@realtek.com>
<yhchuang@realtek.com> wrote:
> From: Zong-Zhe Yang <kevin_yang@realtek.com>
>
> In the current design, various chip functions and tables
> are built into rtw88 core. That causes kernel to load its
> functionalities even if a chip isn't currently used. We
> plan to make each chip's functionalities a separate
> kernel module to reduce rtw88 core. And kernel will be
> able to load the necessary.
>
> Before extracting chip functionalities, we export symbols
> inside rtw88 core which will be used in chip modules.
>
> Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Fails to compile:
ERROR: modpost: "rtw_read8_physical_efuse" [drivers/net/wireless/realtek/rtw88/rtw88_8822c.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
7 patches set to Changes Requested.
11542857 [v3,1/7] rtw88: extract: export symbols used in chip functionalities
11542851 [v3,2/7] rtw88: extract: export symbols about pci interface
11542861 [v3,3/7] rtw88: extract: make 8822c an individual kernel module
11542853 [v3,4/7] rtw88: extract: make 8822b an individual kernel module
11542859 [v3,5/7] rtw88: extract: make 8723d an individual kernel module
11542849 [v3,6/7] rtw88: extract: remove the unused after extracting
11542855 [v3,7/7] rtw88: rename rtw88.ko/rtwpci.ko to rtw88_core.ko/rtw88_pci.ko
--
https://patchwork.kernel.org/patch/11542857/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-13 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 10:31 [PATCH v3 0/7] rtw88: extract chip tables from core module yhchuang
2020-05-12 10:31 ` [PATCH v3 1/7] rtw88: extract: export symbols used in chip functionalities yhchuang
2020-05-13 15:51 ` Kalle Valo [this message]
2020-05-12 10:31 ` [PATCH v3 2/7] rtw88: extract: export symbols about pci interface yhchuang
2020-05-12 10:31 ` [PATCH v3 3/7] rtw88: extract: make 8822c an individual kernel module yhchuang
2020-05-12 10:31 ` [PATCH v3 4/7] rtw88: extract: make 8822b " yhchuang
2020-05-12 10:31 ` [PATCH v3 5/7] rtw88: extract: make 8723d " yhchuang
2020-05-12 10:31 ` [PATCH v3 6/7] rtw88: extract: remove the unused after extracting yhchuang
2020-05-12 10:31 ` [PATCH v3 7/7] rtw88: rename rtw88.ko/rtwpci.ko to rtw88_core.ko/rtw88_pci.ko yhchuang
2020-05-13 9:58 ` [PATCH v3 0/7] rtw88: extract chip tables from core module Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513155108.596DEC433F2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bigeasy@linutronix.de \
--cc=briannorris@chromium.org \
--cc=kevin_yang@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.