From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35420C433DF for ; Wed, 13 May 2020 16:03:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 672492065D for ; Wed, 13 May 2020 16:03:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="GyeuYrQH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730657AbgEMQD1 (ORCPT ); Wed, 13 May 2020 12:03:27 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:50547 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730291AbgEMQD0 (ORCPT ); Wed, 13 May 2020 12:03:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589385806; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=IBcvEQR1Lr6n5Ys8KKpqQ3yJ5ww8Rfql4MzxV2zjol8=; b=GyeuYrQHGFXA2FYlvBzgz4ecwAak7endtsthBf/ZpPPOgGR8C/I/Bhhw2bWkV9aujpcQqYL7 pYplXbJDcUYUG6IA8ypY7JzAeOwCuhnS/kHLAdNxj/fwcfgo5yNkprvYUi3+OKnWplj3PYlU 21pBgCzedhzB1/Z9MHdic/wxzN4= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ebc1a02.7f1cb31d5ed8-smtp-out-n01; Wed, 13 May 2020 16:02:10 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8CABBC433BA; Wed, 13 May 2020 16:02:09 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 92CB0C433BA; Wed, 13 May 2020 16:02:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 92CB0C433BA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath11k: fix htt stats module not handle multiple skbs From: Kalle Valo In-Reply-To: <1589221074-28778-1-git-send-email-pradeepc@codeaurora.org> References: <1589221074-28778-1-git-send-email-pradeepc@codeaurora.org> To: Pradeep Kumar Chitrapu Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Pradeep Kumar Chitrapu , Miles Hu User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200513160209.8CABBC433BA@smtp.codeaurora.org> Date: Wed, 13 May 2020 16:02:09 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Pradeep Kumar Chitrapu wrote: > HTT EXT stats comes in stream of TLVs spanning over multiple > messages. Currently completion is being sent for each message > which is creating a race where stats_req is being accessed > for filling in second message after the memory is already > freed in release operation. Fix this by issuing completion > once all the messages are received and processed. Driver > knows this info from DONE bit set in htt msg. > > Also fix locking required for htt stats. > > Co-developed-by: Miles Hu > Signed-off-by: Miles Hu > Signed-off-by: Pradeep Kumar Chitrapu > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 012f81456818 ath11k: fix htt stats module not handle multiple skbs -- https://patchwork.kernel.org/patch/11541413/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches