From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Kamal Heib <kamalheib1@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH for-rc] RDMA/srpt: Fix disabling device management
Date: Wed, 13 May 2020 15:08:23 -0300 [thread overview]
Message-ID: <20200513180823.GF29989@ziepe.ca> (raw)
In-Reply-To: <e205763f-b36f-484e-3b16-8363fc438242@acm.org>
On Wed, May 13, 2020 at 11:07:10AM -0700, Bart Van Assche wrote:
> On 2020-05-13 11:02, Jason Gunthorpe wrote:
> > On Wed, May 13, 2020 at 08:25:41AM -0700, Bart Van Assche wrote:
> >> In other words, on my setup the ib_srpt driver was working find with SR-IOV.
> >
> > But it won't be properly discoverable without the
> > IB_PORT_DEVICE_MGMT_SUP flag being set on the physical port?
>
> That matches my understanding. Even if srp_daemon can't discover an SRP
> target, it is still possible to log in by writing the proper login
> parameters into /sys/class/infiniband_srp/*/add_target.
It is probably worth revising the warning message to reflect the
actual harm
Jason
next prev parent reply other threads:[~2020-05-13 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 22:29 [PATCH for-rc] RDMA/srpt: Fix disabling device management Kamal Heib
2020-05-13 7:22 ` Leon Romanovsky
2020-05-13 10:02 ` Kamal Heib
2020-05-13 10:21 ` Leon Romanovsky
2020-05-13 10:45 ` Kamal Heib
2020-05-13 10:50 ` Leon Romanovsky
2020-05-13 11:14 ` Kamal Heib
2020-05-13 11:31 ` Leon Romanovsky
2020-05-13 12:38 ` Kamal Heib
2020-05-13 12:43 ` Jason Gunthorpe
2020-05-13 15:25 ` Bart Van Assche
2020-05-13 18:02 ` Jason Gunthorpe
2020-05-13 18:07 ` Bart Van Assche
2020-05-13 18:08 ` Jason Gunthorpe [this message]
2020-05-13 11:59 ` Gal Pressman
2020-05-13 12:54 ` Kamal Heib
2020-05-13 12:48 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513180823.GF29989@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=kamalheib1@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.