All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/linux-tools: introduce spi linux tools
Date: Wed, 13 May 2020 21:58:40 +0200	[thread overview]
Message-ID: <20200513195840.GZ12536@scaer> (raw)
In-Reply-To: <87r1vn6840.fsf@tarshish>

On 2020-05-13 20:46 +0300, Baruch Siach spake thusly:
> Hi Eugen,
> 
> On Wed, May 13 2020, Eugen.Hristev at microchip.com wrote:
> > On 13.05.2020 18:21, Baruch Siach wrote:
> >> On Wed, May 13 2020, Eugen Hristev wrote:
> >>> Add new linux tools package : spi. This is present in the Linux Kernel since
> >>> 4.5.
> >>> It now includes spidev_test and spidev_fdx tools.
> >> We have a package for spidev_test already. Consider adding spidev_fdx to
> >> that package instead.
> > While I understand your point, you should also consider that all linux 
> > tools have a specific way to build in buildroot, and this I think should 
> > be consistent.
> Agreed.
> > And spi tools would be not just spidev_test and might include future 
> > applications, which may or may not have their place in the same spot as 
> > spidev_test .
> In that case I think you should remove the spidev_test package.

Yes, I like it that we can drop spidev_test.

But do it multi-step:

  - intropduce spidev as a linux-tool
  - drop the standalone spidev_test

Do not forget to add legacy handling for it, though; see Config.in.legacy.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-05-13 19:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 15:03 [Buildroot] [PATCH] package/linux-tools: introduce spi linux tools Eugen Hristev
2020-05-13 15:21 ` Baruch Siach
2020-05-13 15:59   ` Eugen.Hristev at microchip.com
2020-05-13 17:46     ` Baruch Siach
2020-05-13 19:58       ` Yann E. MORIN [this message]
2020-06-04 14:27         ` Eugen.Hristev at microchip.com
2020-06-04 15:35           ` Baruch Siach
2020-06-04 21:59             ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513195840.GZ12536@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.