From: Marek Behun <marek.behun@nic.cz>
To: Domenico Andreoli <domenico.andreoli@linux.com>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>,
arm@kernel.org, Leigh Brown <leigh@solinno.co.uk>,
soc@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH mvebu-dt64] arm64: dts: armada-3720-turris-mox.dts: fix sdhci1 pins
Date: Wed, 13 May 2020 21:08:25 +0200 [thread overview]
Message-ID: <20200513210825.0f8bc9ec@nic.cz> (raw)
In-Reply-To: <20200513175648.GA7561@dumbo>
Hi Domenico,
I am not aware of such bug. The link from you message does not work (it
says Message-ID <165fdeb5583069d893436e95cac5436@solinno.co.uk> not
found).
Could you please resend the message describing the problem?
Marek
On Wed, 13 May 2020 19:56:48 +0200
Domenico Andreoli <domenico.andreoli@linux.com> wrote:
> From: Domenico Andreoli <domenico.andreoli@linux.com>
>
> In order to use the sdcard slot on Turris MOX it is necessary to mux
> the sdio0 pins in the north-bridge, which are herein also added.
>
> This fixes the boot problem reported at [0].
>
> Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: "Marek Behún" <marek.behun@nic.cz>
> Cc: linux-arm-kernel@lists.infradead.org
>
> [0] https://lore.kernel.org/linux-arm-kernel/165fdeb5583069d893436e95cac5436@solinno.co.uk/
>
> ---
> arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +-
> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> Index: b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> ===================================================================
> --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> @@ -173,7 +173,7 @@
>
> &sdhci1 {
> pinctrl-names = "default";
> - pinctrl-0 = <&sdio_pins>;
> + pinctrl-0 = <&sdio0_pins &sdio_pins>;
> non-removable;
> bus-width = <4>;
> marvell,pad-type = "sd";
> Index: b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> ===================================================================
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -244,6 +244,11 @@
> groups = "emmc_nb";
> function = "emmc";
> };
> +
> + sdio0_pins: sdio0-pins {
> + groups = "sdio0";
> + function = "sdio";
> + };
> };
>
> nb_pm: syscon@14000 {
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-13 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 17:56 [PATCH mvebu-dt64] arm64: dts: armada-3720-turris-mox.dts: fix sdhci1 pins Domenico Andreoli
2020-05-13 19:08 ` Marek Behun [this message]
2020-05-13 19:25 ` Leigh Brown
2020-05-13 22:15 ` Domenico Andreoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513210825.0f8bc9ec@nic.cz \
--to=marek.behun@nic.cz \
--cc=arm@kernel.org \
--cc=domenico.andreoli@linux.com \
--cc=gregory.clement@bootlin.com \
--cc=leigh@solinno.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.