From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jZ6O6-0000QI-CQ for mharc-grub-devel@gnu.org; Thu, 14 May 2020 01:26:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZ6O5-0000QB-BI for grub-devel@gnu.org; Thu, 14 May 2020 01:26:29 -0400 Received: from mailout01.mx.bawue.net ([193.7.176.62]:40629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZ6O2-0004td-56 for grub-devel@gnu.org; Thu, 14 May 2020 01:26:28 -0400 Received: from n-dimensional.de (p5B17584C.dip0.t-ipconnect.de [91.23.88.76]) (Authenticated sender: pdim@bawue.de) by smtp.bawue.net (Postfix) with ESMTPSA id 04AC122644 for ; Thu, 14 May 2020 07:26:19 +0200 (CEST) Date: Thu, 14 May 2020 07:26:18 +0200 From: Hans Ulrich Niedermann To: grub-devel@gnu.org Subject: Re: [MULTIBOOT2 SPEC PATCH v3 3/4] multiboot2: Make example kernel build at least for i386 Message-ID: <20200514072618.4f084b36@n-dimensional.de> In-Reply-To: <20200513162428.o2fvck445yxiknwh@tomti.i.net-space.pl> References: <20200508045049.397997-1-hun@n-dimensional.de> <20200508045049.397997-4-hun@n-dimensional.de> <20200513162428.o2fvck445yxiknwh@tomti.i.net-space.pl> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanner: SAV Dynamic Interface 2.6.0, Engine: 3.77.1, SAV: 5.75 (4D93ACB7) on relay01.mx.bawue.net using milter-sssp 0.1.0 X-Virus-Scan: Found to be clean. Received-SPF: pass client-ip=193.7.176.62; envelope-from=hun@n-dimensional.de; helo=mailout01.mx.bawue.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/14 01:26:23 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2020 05:26:29 -0000 On Wed, 13 May 2020 18:24:28 +0200 Daniel Kiper wrote: > On Fri, May 08, 2020 at 06:50:48AM +0200, Hans Ulrich Niedermann > wrote: > > The example kernel has assembly language boot code for both > > i386 and mips, but the mips assembly code used to be built > > unconditionally, even if the build is using non-mips build > > tools such as for x86_64 or i386. > > > > This makes the example kernel build at least for i386, both > > on i386 and on x86_64 hosts. > > > > * renames the i386 boot code from boot.S to boot_i386.S > > to go along with the mips boot code in boot_mips.S > > > > * adds AC_CANONICAL_HOST to select the proper boot code: > > > > * i386 if building on x86_64 (adds -m32) or on i[3456]86 > > * mips if building for mips* > > * do not build the kernel if building for another system > > > > * adds m4 quoting and uses AS_HELP_STRING use in configure.ac > > > > * fixes the name of the constants used in boot_i386.S > > to use the actual constant names from multiboot2.h > > > > * documents both boot_i386.S and boot_mips.S in the > > multiboot.texi page > > May I ask you to split this patch into logical parts? Being a little slow on the uptake, I only just figured out why I ended up with that big of a patch. When given a building and working source tree, I usually make my commits such that they are small, self-contained and keep the source tree in a building and working state. That is why I usually add changes until it finally builds/works. However, that is a useless argument here, as the state of the source tree *before* my change is non-building maybe-working, so if the source tree does not build *after* my small, self-contained change, my change has not made it worse and can thusly still be considered good. Changing my normal modus operandi accordingly; considering failing builds as normal for now. Expect a good dozen patches in a day or two. Uli