From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F09CFC433E0 for ; Thu, 14 May 2020 10:18:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F059206DA for ; Thu, 14 May 2020 10:18:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ZDsALvKY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="D3zjKHn8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F059206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BBC4C165F; Thu, 14 May 2020 12:17:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BBC4C165F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589451509; bh=Hjnqtf6r7/XeH0rPJKhpaCd250LS4mEfzl1RNp4Sfyo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZDsALvKYbAw3v6UjzTUroLOAg+pdzijkiiYOIB7rUFYSv9CI3ndNTUym4XpMXzGEt GOz5lunnIW+92KxXMpbyCoI6GnDJOXqJxqVNwkDz7kUDgFqq9P0Otg2Jn6kU1qvcZ6 yuKaVVEOcS7zh6PKN2lixPH4q+HRMEtHCA3uBejc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6C5D4F801DB; Thu, 14 May 2020 12:17:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B4E75F801F2; Thu, 14 May 2020 12:17:17 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 21BAEF800E3 for ; Thu, 14 May 2020 12:17:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 21BAEF800E3 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="D3zjKHn8" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1810F2065D; Thu, 14 May 2020 10:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589451433; bh=Hjnqtf6r7/XeH0rPJKhpaCd250LS4mEfzl1RNp4Sfyo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D3zjKHn8NR/8To9fLf0fHyreRT1kzJk58Z3fWsPILa95k5xHi5sL0y9TYFLy/u5Ep h7KFg/LqEovaeVIZR1hHa7K2rles1Q0eg1sKhJzdrbkdn1DjbBFRAGNkLLQwVomqNk LVXINSpYITqJsfUS0gxo9b8dgpaQQUYOItfCEdf8= Date: Thu, 14 May 2020 11:17:11 +0100 From: Mark Brown To: Tzung-Bi Shih Subject: Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver Message-ID: <20200514101711.GC5127@sirena.org.uk> References: <20200513074523.21086-1-steves.lee@maximintegrated.com> <20200513105144.GC4803@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2/5bycvrmDh4d1IB" Content-Disposition: inline In-Reply-To: X-Cookie: I think we're in trouble. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: jack.yu@realtek.com, ALSA development , ryan.lee.maxim@gmail.com, ckeepax@opensource.cirrus.com, ryans.lee@maximintegrated.com, Steve Lee , Liam Girdwood , Linux Kernel Mailing List , Krzysztof Kozlowski , Takashi Iwai , Srini Kandagatla , geert@linux-m68k.org, dmurphy@ti.com, Shuming =?utf-8?B?W+iMg+abuOmKmF0=?= , steves.lee@maximintegrated.com, nuno.sa@analog.com, rf@opensource.wolfsonmicro.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --2/5bycvrmDh4d1IB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote: > On Wed, May 13, 2020 at 6:53 PM Mark Brown wrote: > > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote: > > > Changes since V2: > > > * Removed warn massage in max98390_dsm_calib_get func > > > and add comment. > > The problem isn't the warning, the problem is that you have an empty > > operation. You should either implement the function (eg, by caching the > > value written) or remove it and fix whatever problems you were running > > into further up the stack when it's missing. > The purpose for the mixer control is: to signal max98390 to start to > calibrate from userspace. > Thus, > max98390_dsm_calib_get() -> do nothing. > max98390_dsm_calib_put() -> call max98390_dsm_calibrate(). In that case it should probably do something like read back if a callibration is currently running. --2/5bycvrmDh4d1IB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl69GqYACgkQJNaLcl1U h9DNxQf/QQdNXRHEhFVhciOu10vEivLtB4etHg6e0+9DlP5UaqQzSlo8qhxUVOLg vvn1YSiYncGYeehx+d2wpZHDsRTuC7t6l8fmJPgX5dU9U8cuaCfEL6MpLTRxWvtd 70W0gvdgF06FJsCQQW/vdFxXMYQrnSULSVbsXP+WTSntRA1q0UgT39iVNB4oLLJa YfnwI6H8B9V/0BLvGNJeQh0CeboCekKQxF02A1gPld096jo3CA0OYae75LLtgV9A 4rkEwexhCG14FuzijzZ56w2JSVjqaqgOHQXtZBcv6zMthny2y08q9Y1+iYTOydAY O9da5PaWDFoscL0AYaMZemx8ryXTYg== =hO61 -----END PGP SIGNATURE----- --2/5bycvrmDh4d1IB-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A168FC433DF for ; Thu, 14 May 2020 10:17:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75E8F206B6 for ; Thu, 14 May 2020 10:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589451435; bh=Hjnqtf6r7/XeH0rPJKhpaCd250LS4mEfzl1RNp4Sfyo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=l+8BjcBC94E8ftVcUbuzSm8q1XXvFUCXGkmzEuBCV6Yh6rU5hr/YZkB1bIiZmCwJv ZZD8qt/gdYCdRft0pMbxyPSdh3ynrM1KAxgVCpZCncas7mWBNLOCVEzFUdkJTCFy7P /onlmbWNmH6jLpWAnAO0lKP2rHAoOYsGNqvlM550= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726203AbgENKRO (ORCPT ); Thu, 14 May 2020 06:17:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:42268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbgENKRO (ORCPT ); Thu, 14 May 2020 06:17:14 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1810F2065D; Thu, 14 May 2020 10:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589451433; bh=Hjnqtf6r7/XeH0rPJKhpaCd250LS4mEfzl1RNp4Sfyo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D3zjKHn8NR/8To9fLf0fHyreRT1kzJk58Z3fWsPILa95k5xHi5sL0y9TYFLy/u5Ep h7KFg/LqEovaeVIZR1hHa7K2rles1Q0eg1sKhJzdrbkdn1DjbBFRAGNkLLQwVomqNk LVXINSpYITqJsfUS0gxo9b8dgpaQQUYOItfCEdf8= Date: Thu, 14 May 2020 11:17:11 +0100 From: Mark Brown To: Tzung-Bi Shih Cc: Steve Lee , jack.yu@realtek.com, ALSA development , ryan.lee.maxim@gmail.com, ckeepax@opensource.cirrus.com, ryans.lee@maximintegrated.com, steves.lee@maximintegrated.com, Linux Kernel Mailing List , Takashi Iwai , Krzysztof Kozlowski , Liam Girdwood , nuno.sa@analog.com, geert@linux-m68k.org, dmurphy@ti.com, Shuming =?utf-8?B?W+iMg+abuOmKmF0=?= , Srini Kandagatla , rf@opensource.wolfsonmicro.com Subject: Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver Message-ID: <20200514101711.GC5127@sirena.org.uk> References: <20200513074523.21086-1-steves.lee@maximintegrated.com> <20200513105144.GC4803@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2/5bycvrmDh4d1IB" Content-Disposition: inline In-Reply-To: X-Cookie: I think we're in trouble. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2/5bycvrmDh4d1IB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote: > On Wed, May 13, 2020 at 6:53 PM Mark Brown wrote: > > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote: > > > Changes since V2: > > > * Removed warn massage in max98390_dsm_calib_get func > > > and add comment. > > The problem isn't the warning, the problem is that you have an empty > > operation. You should either implement the function (eg, by caching the > > value written) or remove it and fix whatever problems you were running > > into further up the stack when it's missing. > The purpose for the mixer control is: to signal max98390 to start to > calibrate from userspace. > Thus, > max98390_dsm_calib_get() -> do nothing. > max98390_dsm_calib_put() -> call max98390_dsm_calibrate(). In that case it should probably do something like read back if a callibration is currently running. --2/5bycvrmDh4d1IB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl69GqYACgkQJNaLcl1U h9DNxQf/QQdNXRHEhFVhciOu10vEivLtB4etHg6e0+9DlP5UaqQzSlo8qhxUVOLg vvn1YSiYncGYeehx+d2wpZHDsRTuC7t6l8fmJPgX5dU9U8cuaCfEL6MpLTRxWvtd 70W0gvdgF06FJsCQQW/vdFxXMYQrnSULSVbsXP+WTSntRA1q0UgT39iVNB4oLLJa YfnwI6H8B9V/0BLvGNJeQh0CeboCekKQxF02A1gPld096jo3CA0OYae75LLtgV9A 4rkEwexhCG14FuzijzZ56w2JSVjqaqgOHQXtZBcv6zMthny2y08q9Y1+iYTOydAY O9da5PaWDFoscL0AYaMZemx8ryXTYg== =hO61 -----END PGP SIGNATURE----- --2/5bycvrmDh4d1IB--