From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:ee01:0:0:0:0:0 with SMTP id g1csp1211279lfb; Thu, 14 May 2020 02:54:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxapECQlbDprMwvLgz6dnKlnv0Zmowmo4FkLMcXJBhaqJCnyvlo6VReRG+HyOZU9lkHFW85 X-Received: by 2002:a37:a455:: with SMTP id n82mr4123641qke.258.1589450074238; Thu, 14 May 2020 02:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589450074; cv=none; d=google.com; s=arc-20160816; b=lZlmsHlqHJAT9yL1S+Jv9FE98mEL2Sz7K6Dn+FovnkPWQVwcHWbi7vg7gGhSmh1CEt RpTorOj8molDhh6/LeXkuFGbJDxUaISnFuxHVlBjaFmIads5ODCuSaO/uf2uRB+jDLvj 0P9PFM4AzYpnzJElgX6Ao5yd+rJTRXuKpGiLUFhLqSNdLQMoVUGRdp6QgePViGX4/azE +9nNvxVPsk2pdSl354Lt1jYRSrPjEXCtI/+RJo6dqP8HrLW8icIM+k3mII1mbYpFqfiF 4TVdYOserYReBcTNnyoNSKiGthygsHDhjb659ekRLlxMLxbaLE/R8dRb5aA4ZKCktd0J 6rrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:subject:to:from:date :dkim-signature; bh=D9bQ/+wADHy8k8J1S1DOC1vh6nehYdWd0tEA0ASmkQY=; b=KwridgfO4ZkNWE9RZOWhWDTVGLyYTyio2DDWRC1T7pCEVXufbLsRWJ9vU9GR+fMedj yM/5Ktc7yRTg0ExSUH0VNeSAMRwpO1nwqKAt3Mg80/kNyUjiPEMJiukNx0PnY6NlZ6fn Ox9Vak1warL/MAYsky0qvdImraiddp+a9g7EF3I3/3C7+9DqVtdlgkGZ5B/FxKmBVZ9i o8NHMKrr97VJIjcT5eN4enAU2glKjc7BAibi5DcSZq0irIbgya3d9hmSpjva3WW9jaK1 uls9AGpqiw5vKasScIVimKQS4TDxm4mf1IT1Ux6R+glSJCuJLhlnmLXPQBvAy0SbrhV2 HC4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="K/w9V1dY"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t28si1388313qth.151.2020.05.14.02.54.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 May 2020 02:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="K/w9V1dY"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:32890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZAZV-0005b6-ML for alex.bennee@linaro.org; Thu, 14 May 2020 05:54:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZAYQ-0004wF-OI for qemu-devel@nongnu.org; Thu, 14 May 2020 05:53:26 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:22507 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZAYP-0002VU-VA for qemu-devel@nongnu.org; Thu, 14 May 2020 05:53:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589450004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D9bQ/+wADHy8k8J1S1DOC1vh6nehYdWd0tEA0ASmkQY=; b=K/w9V1dYdIdGVZcYG5NYn7BiVJvGmWN8Y7R2Gh4x3pEOszYV/CP2LXHLTGAO5QA5X/V8QY shAiP0oAqsBS9lxi13l5A5ufub5yGC+AAMUuTPump20ZWyqzYqWA7p1t9IegyEEA0e10JM Hmj21CkeJv76i0Pl1UcyHIyCF3zYZic= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-pcbXPw7rPAe5hiPMoGAKpQ-1; Thu, 14 May 2020 05:53:23 -0400 X-MC-Unique: pcbXPw7rPAe5hiPMoGAKpQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CBE1F8014D7; Thu, 14 May 2020 09:53:21 +0000 (UTC) Received: from localhost (unknown [10.40.208.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC44661F50; Thu, 14 May 2020 09:53:08 +0000 (UTC) Date: Thu, 14 May 2020 11:53:04 +0200 From: Igor Mammedov To: Auger Eric Subject: Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part Message-ID: <20200514115304.6ddb5e34@redhat.com> In-Reply-To: <3dfdf504-7fc2-40cf-8387-c4abb8133792@redhat.com> References: <20200505144419.29174-1-eric.auger@redhat.com> <20200505144419.29174-2-eric.auger@redhat.com> <20200506063314.4qvnyfonjixcknuj@kamzik.brq.redhat.com> <20200506055747-mutt-send-email-mst@kernel.org> <20200512161447.07b76de2@redhat.com> <3dfdf504-7fc2-40cf-8387-c4abb8133792@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 22:25:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Andrew Jones , gshan@redhat.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, shannon.zhaosl@gmail.com, qemu-arm@nongnu.org, marcandre.lureau@redhat.com, eric.auger.pro@gmail.com, lersek@redhat.com, ardb@kernel.org, stefanb@linux.ibm.com Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: KrFChxkcIlZo On Tue, 12 May 2020 17:59:25 +0200 Auger Eric wrote: > Hi Igor, > > On 5/12/20 4:14 PM, Igor Mammedov wrote: > > On Wed, 6 May 2020 05:58:25 -0400 > > "Michael S. Tsirkin" wrote: > > > >> On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: > >>> I realize this function is just getting moved, but maybe it should get > >>> converted to the build_append* API while being moved? > >> > >> I'd rather refactoring was done in a separate patch - > >> easier to review. > > maybe first convert and then move > > > > PS: > > me wonders if we have test with TPM enabled, if not maybe it's time to add them > > i.e. first goes testcase in bios-tables and then refactoring/moving > > in that case review is simpler. > Do you mean tests checking the ACPI table content when TPM is > instantiated? I don't think so otherwise it would have failed I guess. yes, I've meant that. > Otherwise we have functional tests with TPM (MMIO access), ie qtest > tests tpm-tis-device-test and tpm-tis-device-swtpm-test. > > Thanks > > Eric > > > >