From: Christoph Hellwig <hch@lst.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>, Hillf Danton <hdanton@sina.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jeremy Linton <jeremy.linton@arm.com>,
syzbot+353be47c9ce21b68b7ed@syzkaller.appspotmail.com,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] USB: usbfs: fix mmap dma mismatch
Date: Thu, 14 May 2020 13:58:29 +0200 [thread overview]
Message-ID: <20200514115829.GA15995@lst.de> (raw)
In-Reply-To: <20200514112711.1858252-1-gregkh@linuxfoundation.org>
On Thu, May 14, 2020 at 01:27:11PM +0200, Greg Kroah-Hartman wrote:
> + if (hcd->localmem_pool || !hcd_uses_dma(hcd)) {
> + if (remap_pfn_range(vma, vma->vm_start,
> + virt_to_phys(usbm->mem) >> PAGE_SHIFT,
> + size, vma->vm_page_prot) < 0) {
> + dec_usb_memory_use_count(usbm, &usbm->vma_use_count);
> + return -EAGAIN;
> + }
> + } else {
> + if (dma_mmap_coherent(hcd->self.sysdev, vma, mem, dma_handle,
> + size)) {
> + dec_usb_memory_use_count(usbm, &usbm->vma_use_count);
> + return -EAGAIN;
> + }
What about a goto label to share the error handling path?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-05-14 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 11:27 [PATCH] USB: usbfs: fix mmap dma mismatch Greg Kroah-Hartman
2020-05-14 11:37 ` Jeremy Linton
2020-05-14 11:58 ` Christoph Hellwig [this message]
2020-05-14 12:09 ` Greg Kroah-Hartman
2020-05-14 14:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514115829.GA15995@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+353be47c9ce21b68b7ed@syzkaller.appspotmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.